ramon
/
skillbox
1
0
Fork 0
Code Issues 1 Pull Requests 1 Packages Projects 1 Releases 1 Wiki Activity

Fix unit tests

This commit is contained in:
Ramon Wenger 2022-06-14 14:33:17 +02:00
parent e5641b7f93
commit 0d7b948e44
3 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
server/books/schema/mutations/snapshot.py
View File

@ -1,5 +1,4 @@
import graphene import graphene
from django.db.models import Q
from graphene import relay from graphene import relay
from api.types import FailureNode, SuccessNode from api.types import FailureNode, SuccessNode
@ -93,7 +92,7 @@ class DeleteSnapshot(relay.ClientIDMutation):
return cls(result=NotOwnerFailure) return cls(result=NotOwnerFailure)
snapshot.delete() snapshot.delete()
return cls(result=DeleteSnapshotResult) return cls(result=DeleteSnapshotSuccess)
class ApplySnapshot(relay.ClientIDMutation): class ApplySnapshot(relay.ClientIDMutation):

9
server/books/tests/queries.py
View File

@ -154,13 +154,16 @@ mutation UpdateSnapshot($input: UpdateSnapshotInput!) {
""" """
DELETE_SNAPSHOT_MUTATION = """ DELETE_SNAPSHOT_MUTATION = """
mutation DeleteSnapshot($id: ID!) { mutation DeleteSnapshot($input: DeleteSnapshotInput!) {
deleteSnapshot(id: $id) { deleteSnapshot(input: $input) {
result { result {
success __typename
...on NotOwner { ...on NotOwner {
reason reason
} }
...on Success {
message
}
} }
} }
} }

16
server/books/tests/test_snapshots.py
View File

@ -451,11 +451,21 @@ class SnapshotTestCase(SkillboxTestCase):
def test_delete_snapshot(self): def test_delete_snapshot(self):
result = self.get_client().execute(DELETE_SNAPSHOT_MUTATION, variables={ result = self.get_client().execute(DELETE_SNAPSHOT_MUTATION, variables={
'input': { 'input': {
'id': self.snapshot 'id': to_global_id('Snapshot', self.snapshot.id),
} }
}) })
self.assertIsNone(result.errors) self.assertIsNone(result.errors)
self.assertEqual(result.data.get('deleteSnapshot').get('result').get('__typename'), 'SuccessNode') self.assertEqual(result.data.get('deleteSnapshot').get('result').get('__typename'), 'Success')
def test_delete_snapshot_not_owner_fails(self): def test_delete_snapshot_not_owner_fails(self):
self.assertTrue(False) self.snapshot.creator = self.teacher2
self.snapshot.save()
result = self.get_client().execute(DELETE_SNAPSHOT_MUTATION, variables={
'input': {
'id': to_global_id('Snapshot', self.snapshot.id),
}
})
self.assertIsNone(result.errors)
result = result.data.get('deleteSnapshot').get('result')
self.assertEqual(result.get('__typename'), 'NotOwner')
self.assertEqual(result.get('reason'), 'Not the owner')