Refactor cypress tests

client/cypress/fixtures/me.minimal.js

@@ -4,7 +4,6 @@ const minimalMe = {
   lastName: '',
   avatarUrl: '',
   email: '',
-  onboardingVisited: true,
   schoolClasses: {},
   id: '',
   readOnly: false,

client/cypress/fixtures/mocks.js

@@ -41,7 +41,8 @@ export default {
     solution: 'Assignment Solution',
   }),
   PrivateUserNode: () => ({
-    readOnly: false
+    readOnly: false,
+    onboardingVisited: true
   }),
   SchoolClassNode: () => ({
     readOnly: false

client/cypress/integration/frontend/assignment.spec.js

@@ -5,31 +5,24 @@ const operations = {
       title: 'Ein Auftragstitel',
       solution: '<p>Eine Lösung</p>',
       assignment: 'Ein Auftrag',
-      submissions: []
+      submissions: [],
-    }
+    },
   },
   MeQuery: {
-    me: {
+    me: {},
-      onboardingVisited: true
-    },
   },
 };
 
 describe('Assignments', () => {
-  before(() => {
+  beforeEach(() => {
-    cy.task('getSchema').then(schema => {
+    cy.setup();
-      cy.mockGraphql({
+
-        schema,
+    cy.mockGraphqlOps({
-        mocks: {},
+      operations,
-        operations,
-      });
     });
   });
 
   it('it does not display HTML tags', () => {
-    cy.server();
-    cy.viewport('macbook-15');
-    cy.fakeLogin('ross.geller', 'test');
     cy.visit('/module/lohn-und-budget/submissions/QXNzaWdubWVudE5vZGU6MQ==');
     cy.getByDataCy('assignment-solution').should('have.text', 'Eine Lösung');
   });

client/cypress/integration/frontend/new-project.spec.js

@@ -25,7 +25,6 @@ const operations = {
   },
   MeQuery: {
     me: {
-      onboardingVisited: true
     }
   },
   AddProject: variables => ({

client/cypress/integration/frontend/project-entry.spec.js

@@ -3,7 +3,6 @@ const operations = {
   MeQuery: {
     me: {
       id: 'VXNlck5vZGU6NQ==',
-      onboardingVisited: true,
       permissions: [],
     },
   },

client/cypress/integration/frontend/read-only/assignment-feedback.teacher.spec.js

@@ -1,11 +1,8 @@
-import mocks from '../../../fixtures/mocks';
-
 const myText = 'Mein Feedback';
 
 const getOperations = ({readOnly, classReadOnly = false}) => ({
   MeQuery: {
     me: {
-      onboardingVisited: true,
       readOnly,
       selectedClass: {
         id: 'selectedClassId',
@@ -37,14 +34,7 @@ const getOperations = ({readOnly, classReadOnly = false}) => ({
 
 describe('Assignment feedback read-only - Teacher', () => {
   beforeEach(() => {
-    cy.fakeLogin('nico.teacher', 'test');
+    cy.setup();
-    cy.server();
-    cy.task('getSchema').then(schema => {
-      cy.mockGraphql({
-        schema,
-        mocks,
-      });
-    });
   });
 
   it('can not edit', () => {
@@ -53,10 +43,6 @@ describe('Assignment feedback read-only - Teacher', () => {
     });
 
     cy.visit('submission/submission-id');
-    // cy.get('.submission-form__textarea--readonly').as('textarea');
-    //
-    // cy.get('@textarea').invoke('val').should('contain', myText);
-    // cy.get('@textarea').should('have.attr', 'readonly');
 
     cy.isSubmissionReadOnly(myText);
     cy.getByDataCy('final-submission-reopen').should('not.exist');

client/cypress/integration/frontend/read-only/assignment.student.spec.js

@@ -36,7 +36,6 @@ const myText = 'submission text';
 const getOperations = ({final, readOnly, classReadOnly = false}) => ({
   MeQuery: {
     me: {
-      onboardingVisited: true,
       readOnly,
       selectedClass: {
         id: 'selectedClassId',

client/cypress/integration/frontend/read-only/room.spec.js

@@ -5,7 +5,6 @@ const SELECTED_CLASS_ID = 'selectedClassId';
 const getOperations = ({readOnly, classReadOnly}) => ({
   MeQuery: {
     me: {
-      onboardingVisited: true,
       readOnly,
       isTeacher: true,
       selectedClass: {

client/cypress/integration/frontend/read-only/rooms.spec.js

@@ -5,7 +5,6 @@ const SELECTED_CLASS_ID = 'selectedClassId';
 const getOperations = ({readOnly, classReadOnly}) => ({
   MeQuery: {
     me: {
-      onboardingVisited: true,
       readOnly,
       isTeacher: true,
       selectedClass: {

client/cypress/integration/frontend/read-only/school-class-team.spec.js

@@ -5,7 +5,6 @@ const selectedClassName = 'My Class';
 const getOperations = ({readOnly}) => ({
   MeQuery: {
     me: {
-      onboardingVisited: true,
       readOnly,
       isTeacher: true,
     },

client/cypress/integration/frontend/spellcheck.spec.js

@@ -7,8 +7,7 @@ const operations = {
   MeQuery: {
     me: {
       permissions: [],
-      onboardingVisited: true,
+      readOnly: false,
-      readOnly: false
     },
   },
   AssignmentQuery: {
@@ -131,19 +130,15 @@ const operations = {
 };
 
 describe('Spellcheck', () => {
-  before(() => {
+  beforeEach(() => {
-    cy.server();
+    cy.setup();
-    cy.task('getSchema').then(schema => {
+    cy.mockGraphqlOps({
-      cy.mockGraphql({
+      operations,
-        schema,
-        operations,
-      });
     });
   });
 
   // todo: unskip me
-  it.skip('should highlight three errors', () => {
+  it('should highlight three errors', () => {
-    cy.fakeLogin('rachel.green', 'test');
     cy.visit('/module/lohn-und-budget/');
 
     cy.getByDataCy('spellcheck-correction').should('have.length', 0);

client/cypress/integration/frontend/survey.spec.js

@@ -13,7 +13,6 @@ describe('Survey', () => {
         MeQuery: {
           me: {
             permissions: [],
-            onboardingVisited: true
           }
         },
         ModuleQuery: variables => ({module}),

client/cypress/support/helpers.js

@@ -3,7 +3,6 @@
 export const getMinimalMe = ({readOnly = false, classReadOnly = false, isTeacher = true}) => ({
   me: {
     id: 'meId',
-    onboardingVisited: true,
     readOnly,
     isTeacher,
     selectedClass: {