From 38e99e4747223463188f9f06ff3c6f164e4f8290 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Thu, 7 May 2020 18:02:33 +0200
Subject: [PATCH] Add and fix some more rules

---
 client/.eslintrc.js                                           | 2 +-
 .../content-forms/ContentBlockElementChooserWidget.vue        | 2 +-
 client/src/components/profile/Avatar.vue                      | 2 +-
 client/src/components/rooms/RoomWidget.vue                    | 2 +-
 client/src/components/videos/SrfEmbed.vue                     | 4 ++--
 client/src/pages/editProject.vue                              | 2 +-
 client/src/pages/editRoom.vue                                 | 2 +-
 client/src/pages/project.vue                                  | 4 ++--
 client/src/pages/room.vue                                     | 2 +-
 client/src/pages/survey.vue                                   | 2 +-
 10 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/client/.eslintrc.js b/client/.eslintrc.js
index 92ad96bd..2603e167 100644
--- a/client/.eslintrc.js
+++ b/client/.eslintrc.js
@@ -11,7 +11,7 @@ module.exports = {
   extends: [
     // https://github.com/vuejs/eslint-plugin-vue#priority-a-essential-error-prevention
     // consider switching to `plugin:vue/strongly-recommended` or `plugin:vue/recommended` for stricter rules.
-    'plugin:vue/strongly-recommended',
+    'plugin:vue/recommended',
     // 'plugin:vue/recommended',
     // https://github.com/standard/standard/blob/master/docs/RULES-en.md
     'standard'
diff --git a/client/src/components/content-forms/ContentBlockElementChooserWidget.vue b/client/src/components/content-forms/ContentBlockElementChooserWidget.vue
index 4d756297..b8896044 100644
--- a/client/src/components/content-forms/ContentBlockElementChooserWidget.vue
+++ b/client/src/components/content-forms/ContentBlockElementChooserWidget.vue
@@ -1,6 +1,6 @@
 <template>
   <div
-    :class="{'content-block-element-chooser-widget--no-assignment': this.hideAssignment}"
+    :class="{'content-block-element-chooser-widget--no-assignment': hideAssignment}"
     class="content-block-element-chooser-widget">
     <div
       class="content-block-element-chooser-widget__link content-block-element-chooser-widget__link--link"
diff --git a/client/src/components/profile/Avatar.vue b/client/src/components/profile/Avatar.vue
index b8595f8a..b4e68998 100644
--- a/client/src/components/profile/Avatar.vue
+++ b/client/src/components/profile/Avatar.vue
@@ -8,7 +8,7 @@
     </transition>
     <transition name="show">
       <div
-        :style="{'background-image': `url(${this.avatarUrl})`}"
+        :style="{'background-image': `url(${avatarUrl})`}"
         class="avatar__image"
         v-show="isAvatarLoaded"
         ref="avatarImage"/>
diff --git a/client/src/components/rooms/RoomWidget.vue b/client/src/components/rooms/RoomWidget.vue
index 7ba73ac8..951020cf 100644
--- a/client/src/components/rooms/RoomWidget.vue
+++ b/client/src/components/rooms/RoomWidget.vue
@@ -11,7 +11,7 @@
       <entry-count-widget :entry-count="entryCount"/>
     </router-link>
     <widget-footer v-if="canEditRoom">
-      <room-actions :id="this.id"/>
+      <room-actions :id="id"/>
     </widget-footer>
   </div>
 </template>
diff --git a/client/src/components/videos/SrfEmbed.vue b/client/src/components/videos/SrfEmbed.vue
index dd7f6c1a..c21fa6b6 100644
--- a/client/src/components/videos/SrfEmbed.vue
+++ b/client/src/components/videos/SrfEmbed.vue
@@ -1,9 +1,9 @@
 <template>
   <iframe
-    :src='`https://tp.srgssr.ch/p/srf/embed?urn=urn:srf:video:${videoId}`'
+    :src="`https://tp.srgssr.ch/p/srf/embed?urn=urn:srf:video:${videoId}`"
     class="srf-embed"
     allowfullscreen
-    frameborder='0'/>
+    frameborder="0"/>
 </template>
 
 <script>
diff --git a/client/src/pages/editProject.vue b/client/src/pages/editProject.vue
index 19b9e390..cadad0c3 100644
--- a/client/src/pages/editProject.vue
+++ b/client/src/pages/editProject.vue
@@ -2,7 +2,7 @@
   <div class="edit-project-page">
     <edit-project
       :project="project"
-      v-if="this.project.id"/>
+      v-if="project.id"/>
   </div>
 </template>
 
diff --git a/client/src/pages/editRoom.vue b/client/src/pages/editRoom.vue
index cacacc03..6878a2f4 100644
--- a/client/src/pages/editRoom.vue
+++ b/client/src/pages/editRoom.vue
@@ -2,7 +2,7 @@
   <div class="edit-room-page">
     <edit-room
       :room="room"
-      v-if="this.room.id"/>
+      v-if="room.id"/>
   </div>
 </template>
 
diff --git a/client/src/pages/project.vue b/client/src/pages/project.vue
index f77036bc..77ea2430 100644
--- a/client/src/pages/project.vue
+++ b/client/src/pages/project.vue
@@ -17,8 +17,8 @@
       </ul>
 
       <div class="project__meta">
-        <project-actions :id="this.project.id"/>
-        <owner-widget :owner="this.project.student"/>
+        <project-actions :id="project.id"/>
+        <owner-widget :owner="project.student"/>
         <entry-count-widget :entry-count="projectEntryCount"/>
       </div>
 
diff --git a/client/src/pages/room.vue b/client/src/pages/room.vue
index ca01c34b..5680b251 100644
--- a/client/src/pages/room.vue
+++ b/client/src/pages/room.vue
@@ -6,7 +6,7 @@
         {{ room.description }}
       </p>
       <div class="room__meta">
-        <room-actions :id="this.room.id"/>
+        <room-actions :id="room.id"/>
         <room-group-widget v-bind="room.schoolClass"/>
         <entry-count-widget :entry-count="roomEntryCount"/>
       </div>
diff --git a/client/src/pages/survey.vue b/client/src/pages/survey.vue
index 91028b5f..c4715861 100644
--- a/client/src/pages/survey.vue
+++ b/client/src/pages/survey.vue
@@ -1,7 +1,7 @@
 <template>
   <div class="survey-page">
     <h1 class="survey-page__title">{{ title }}</h1>
-    <survey :survey='survey'/>
+    <survey :survey="survey"/>
 
     <solution
       :value="solution"