ramon
/
skillbox
1
0
Fork 0
Code Issues 1 Pull Requests 1 Packages Projects 1 Releases 1 Wiki Activity

Fix hidden default group bug

This commit is contained in:
Lorenz Padberg 2024-02-26 11:34:19 +01:00
parent 55fc5da9a7
commit 3e86d9a620
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server/books/management/commands/migrate_objectives_to_content.py
View File

@ -50,6 +50,12 @@ def migrate_objectives_to_content():
else: else:
default_content_block = created_default_content_blocks[default_objectives_ids] default_content_block = created_default_content_blocks[default_objectives_ids]
# set visibility for objective_group
if objective_group.hidden_for.exists():
default_content_block.hidden_for.add(*objective_group.hidden_for.all())
default_content_block.save_revision().publish()
default_content_block.save()
custom_objectives_by_owner = get_objectives_by_owner(objective_group) custom_objectives_by_owner = get_objectives_by_owner(objective_group)
if default_objectives or custom_objectives_by_owner: if default_objectives or custom_objectives_by_owner:

12
server/books/tests/test_objectives_migration.py
View File

@ -92,14 +92,14 @@ class TestObjectivesMigration(SkillboxTestCase):
}) })
module = result.data['module'] module = result.data['module']
chapter1 = module['chapters'][0] chapter1 = module['chapters'][0]
hidden_custom, _, _, _ = chapter1['contentBlocks'] hidden_default, _, _, _ = chapter1['contentBlocks']
# default content block (Verlagsinhalte) exists but is hidden (since one objective is hidden for this class) # default content block (Verlagsinhalte) exists but is hidden (since one objective is hidden for this class)
self.assertEqual(hidden_custom['title'], 'Sprache & Kommunikation') self.assertEqual(hidden_default['title'], 'Sprache & Kommunikation')
self.assertTrue(hidden_custom['originalCreator'] is None) self.assertTrue(hidden_default['originalCreator'] is None)
self.assertEqual(hidden_custom['hiddenFor'], [{'name': 'skillbox'}]) self.assertEqual(hidden_default['hiddenFor'], [{'name': 'skillbox'}])
self.assertEqual(hidden_custom['visibleFor'], []) self.assertEqual(hidden_default['visibleFor'], [])
self.assertEqual(hidden_custom['contents'][0]['value']['text'], '<ul><li>objective1</li></ul>') self.assertEqual(hidden_default['contents'][0]['value']['text'], '<ul><li>objective1</li></ul>')
def test_objectives_order(self): def test_objectives_order(self):
"""The correct oder of the objectives is: """The correct oder of the objectives is: