ramon
/
skillbox
1
0
Fork 0
Code Issues 1 Pull Requests 1 Packages Projects 1 Releases 1 Wiki Activity

Fix some typing issues

This commit is contained in:
Ramon Wenger 2024-01-08 22:31:21 +01:00
parent 99ce0ab84d
commit 4584cb860e
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/src/components/ContentBlock.vue
View File

@ -269,7 +269,7 @@ onUnmounted(() => {
if (element !== null) { if (element !== null) {
console.log('unmounting'); console.log('unmounting');
element.removeEventListener('mouseup', getSelectionHandler); element.removeEventListener('mouseup', getSelectionHandler(element, props.contentBlock));
} }
}); });

4
client/src/directives/highlight.ts
View File

@ -102,13 +102,13 @@ export const getSelectionHandler = (el: HTMLElement, contentBlock: ContentBlockN
const paragraph = findClosestAncestorWithTag(startContainer, 'p'); const paragraph = findClosestAncestorWithTag(startContainer, 'p');
const endAncestor = findClosestAncestorWithTag(endContainer, 'p'); const endAncestor = findClosestAncestorWithTag(endContainer, 'p');
if (paragraph === endAncestor) { if (paragraph && paragraph === endAncestor) {
// todo: rename this variable, `parent` is not correct anymore // todo: rename this variable, `parent` is not correct anymore
const contentComponent = findClosestAncestorWithClass(startContainer, 'content-component'); const contentComponent = findClosestAncestorWithClass(startContainer, 'content-component');
if (contentComponent) { if (contentComponent) {
// our selection is wholly inside the container node, we continue with it // our selection is wholly inside the container node, we continue with it
const position = findPositionInParent(contentComponent); const position = findPositionInParent(contentComponent);
const siblings = Array.from(paragraph.parentElement.children); const siblings = Array.from(paragraph.parentElement?.children || []);
const positionInTextBlock = siblings.indexOf(paragraph); const positionInTextBlock = siblings.indexOf(paragraph);
const numOfParagraphs = Array.from(contentComponent.children[1].children).filter( const numOfParagraphs = Array.from(contentComponent.children[1].children).filter(