ramon
/
skillbox
1
0
Fork 0
Code Issues 1 Pull Requests 1 Packages Projects 1 Releases 1 Wiki Activity

Add clearer messages to command

This commit is contained in:
Ramon Wenger 2023-08-30 16:38:15 +02:00
parent 8dc080a9fc
commit 5a71a9cec8
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
server/core/convert_page_translation.py
View File

@ -29,11 +29,14 @@ def convert_page_to_translation(slug: str, original_slug: str, language_code="en
""" """
try: try:
module = Module.objects.get(slug=slug) module = Module.objects.get(slug=slug)
original = Module.objects.get(slug=original_slug)
if original.translation_key == module.translation_key:
raise AlreadyTranslatedException
except Module.DoesNotExist: except Module.DoesNotExist:
raise ModuleDoesNotExistException raise ModuleDoesNotExistException(slug)
try:
original = Module.objects.get(slug=original_slug)
except Module.DoesNotExist:
raise ModuleDoesNotExistException(original_slug)
if original.translation_key == module.translation_key:
raise AlreadyTranslatedException
locale, _ = Locale.objects.get_or_create(language_code=language_code) locale, _ = Locale.objects.get_or_create(language_code=language_code)
logger.debug("Starting conversion") logger.debug("Starting conversion")
topic: Topic = module.get_parent() topic: Topic = module.get_parent()

8
server/core/management/commands/migrate_translation.py
View File

@ -35,7 +35,9 @@ class Command(BaseCommand):
slug=slug, original_slug=original_slug, language_code=language_code slug=slug, original_slug=original_slug, language_code=language_code
) )
self.stdout.write(result) self.stdout.write(result)
except ModuleDoesNotExistException: except ModuleDoesNotExistException as e:
raise CommandError("Module does not exist") raise CommandError(f"Module does not exist: {e}")
except AlreadyTranslatedException: except AlreadyTranslatedException:
raise CommandError("Pages already are translations of each other") raise CommandError(
f"Pages {slug} and {original_slug} already are translations of each other"
)