From b4c9e01fcb540b9b8b5f5e8434a7f264ac6dae00 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Mon, 18 Oct 2021 15:38:57 +0200
Subject: [PATCH 01/20] Add command to export assignments

---
 server/assignments/admin.py                   | 12 +++------
 server/assignments/helpers.py                 | 13 +++++++++
 server/assignments/management/__init__.py     |  0
 .../management/commands/__init__.py           |  0
 .../commands/export_assignment_submissions.py | 27 +++++++++++++++++++
 5 files changed, 43 insertions(+), 9 deletions(-)
 create mode 100644 server/assignments/helpers.py
 create mode 100644 server/assignments/management/__init__.py
 create mode 100644 server/assignments/management/commands/__init__.py
 create mode 100644 server/assignments/management/commands/export_assignment_submissions.py

diff --git a/server/assignments/admin.py b/server/assignments/admin.py
index e6b8e1e0..2a19d341 100644
--- a/server/assignments/admin.py
+++ b/server/assignments/admin.py
@@ -7,6 +7,7 @@ from django.http import HttpResponse
 from django.urls import reverse
 from django.utils.html import format_html
 
+from assignments.helpers import write_assignments_to_csv, write_submissions_to_csv
 from assignments.models import Assignment, StudentSubmission, SubmissionFeedback
 
 
@@ -38,10 +39,7 @@ class AssignmentAdmin(admin.ModelAdmin):
         response['Content-Disposition'] = 'attachment;filename=assignment-export.csv'
 
         writer = csv.writer(response)
-        field_names = ['ID', 'Titel', 'Auftragstext', 'Modul']
-        writer.writerow(field_names)
-        for assignment in queryset.all():
-            writer.writerow([assignment.id, assignment.title, assignment.assignment, assignment.module])
+        write_assignments_to_csv(writer, queryset)
 
         return response
 
@@ -52,11 +50,7 @@ class AssignmentAdmin(admin.ModelAdmin):
         response['Content-Disposition'] = 'attachment;filename=assignment-submission-export.csv'
 
         writer = csv.writer(response)
-        field_names = ['Assignment-ID', 'Text', 'Mit Lehrer geteilt',]
-        writer.writerow(field_names)
-        for assignment in queryset.all():
-            for submission in assignment.submissions.filter(final=True):
-                writer.writerow([submission.assignment.id, submission.text, submission.final])
+        write_submissions_to_csv(writer, queryset)
 
         return response
 
diff --git a/server/assignments/helpers.py b/server/assignments/helpers.py
new file mode 100644
index 00000000..2ab0860a
--- /dev/null
+++ b/server/assignments/helpers.py
@@ -0,0 +1,13 @@
+
+
+def write_assignments_to_csv(writer, queryset):
+    field_names = ['ID', 'Titel', 'Auftragstext', 'Modul']
+    writer.writerow(field_names)
+    for assignment in queryset.all():
+        writer.writerow([assignment.id, assignment.title, assignment.assignment, assignment.module])
+
+def write_submissions_to_csv(writer, queryset):
+    field_names = ['Assignment-ID', 'Text', 'Mit Lehrer geteilt', ]
+    writer.writerow(field_names)
+    for submission in queryset.all():
+        writer.writerow([submission.assignment.id, submission.text, submission.final])
diff --git a/server/assignments/management/__init__.py b/server/assignments/management/__init__.py
new file mode 100644
index 00000000..e69de29b
diff --git a/server/assignments/management/commands/__init__.py b/server/assignments/management/commands/__init__.py
new file mode 100644
index 00000000..e69de29b
diff --git a/server/assignments/management/commands/export_assignment_submissions.py b/server/assignments/management/commands/export_assignment_submissions.py
new file mode 100644
index 00000000..bf903456
--- /dev/null
+++ b/server/assignments/management/commands/export_assignment_submissions.py
@@ -0,0 +1,27 @@
+import csv
+
+from django.core.management.base import BaseCommand
+
+from assignments.helpers import write_assignments_to_csv, write_submissions_to_csv
+from assignments.models import Assignment, StudentSubmission
+
+
+class Command(BaseCommand):
+    help = """
+    Export assignments with submissions
+    """
+
+    def handle(self, *args, **options):
+        ids = [171, 112, 113, 114, 272, 246, 250, 348, 598]
+
+        assignments = Assignment.objects.filter(id__in=ids)
+
+        with open('./export-assignments.csv', 'w') as f:
+            writer = csv.writer(f)
+            write_assignments_to_csv(writer, assignments)
+
+        submissions = StudentSubmission.objects.filter(assignment__id__in=ids)
+
+        with open('./export-submissions.csv', 'w') as f:
+            writer = csv.writer(f)
+            write_submissions_to_csv(writer, submissions)

From 60e3cc264c63c15c1524d8eb1a6585d214e12995 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Mon, 18 Oct 2021 17:30:56 +0200
Subject: [PATCH 02/20] Update documentation

---
 README.md             | 15 +--------------
 docs/heroku-backup.md | 22 +++++++++++++++++++++-
 2 files changed, 22 insertions(+), 15 deletions(-)

diff --git a/README.md b/README.md
index d03b1e65..f3db19b6 100644
--- a/README.md
+++ b/README.md
@@ -128,21 +128,8 @@ Change DATABASE URL (e.g after a rollback)
 
 ### Backup
 
-Create a backup
+See [Docs](./docs/heroku-backup.md)
 
-`heroku pg:backups:capture --app <appname>`
-
-The following command will provide a URL to where the backup can be downloaded (expires after 60 minutes)
-
-`heroku pg:backups:url b001 --app <appname>`
-
-To restore a backup, use
-
-`heroku pg:backups:restore b001 DATABASE_URL --app <appname>`
-
-To see the backup schedule
-
-`heroku pg:backus:schedules --app <appname>`
 
 ## AWS
 
diff --git a/docs/heroku-backup.md b/docs/heroku-backup.md
index b7ee97f5..a3b72d9b 100644
--- a/docs/heroku-backup.md
+++ b/docs/heroku-backup.md
@@ -1,6 +1,26 @@
-### list backups
+### List backups
 
 ```
 heroku login
 heroku pg:backups --app skillbox-prod
 ```
+
+
+### Create a backup
+
+`heroku pg:backups:capture --app <appname>`
+
+The following command will provide a URL to where the backup can be downloaded (expires after 60 minutes)
+
+`heroku pg:backups:url b001 --app <appname>`
+
+To restore a backup, use
+
+`heroku pg:backups:restore b001 DATABASE_URL --app <appname>`
+
+To see the backup schedule
+
+`heroku pg:backus:schedules --app <appname>`
+
+To download a backup use
+`heroku pg:backups:download --app <appname>`

From 3c03e3c741b25a83632ddd3d3812dd0e3ec5cf19 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Mon, 18 Oct 2021 17:46:45 +0200
Subject: [PATCH 03/20] Add new test, update naming

---
 .../frontend/instruments-page.spec.js           | 17 +++++++++++++++++
 .../gql/queries/instrumentsByTypeQuery.gql      |  2 +-
 .../graphql/gql/queries/instrumentsQuery.gql    | 16 ++++++----------
 3 files changed, 24 insertions(+), 11 deletions(-)
 create mode 100644 client/cypress/integration/frontend/instruments-page.spec.js

diff --git a/client/cypress/integration/frontend/instruments-page.spec.js b/client/cypress/integration/frontend/instruments-page.spec.js
new file mode 100644
index 00000000..1a7cfa19
--- /dev/null
+++ b/client/cypress/integration/frontend/instruments-page.spec.js
@@ -0,0 +1,17 @@
+describe('Instruments Page', () => {
+  beforeEach(() => {
+    cy.setup();
+  });
+
+  it('opens the instruments page', () => {
+    cy.mockGraphqlOps({
+      operations: {
+        MeQuery: {},
+        InstrumentsQuery: {
+          instruments: []
+        }
+      }
+    });
+    cy.visit('instruments/');
+  });
+});
diff --git a/client/src/graphql/gql/queries/instrumentsByTypeQuery.gql b/client/src/graphql/gql/queries/instrumentsByTypeQuery.gql
index 6024c799..aa84aca6 100644
--- a/client/src/graphql/gql/queries/instrumentsByTypeQuery.gql
+++ b/client/src/graphql/gql/queries/instrumentsByTypeQuery.gql
@@ -1,4 +1,4 @@
-query InstrumentQuery($type: String!){
+query InstrumentsQuery($type: String!){
   instruments(type: $type) {
     edges {
       node {
diff --git a/client/src/graphql/gql/queries/instrumentsQuery.gql b/client/src/graphql/gql/queries/instrumentsQuery.gql
index bed2a520..c87588ba 100644
--- a/client/src/graphql/gql/queries/instrumentsQuery.gql
+++ b/client/src/graphql/gql/queries/instrumentsQuery.gql
@@ -1,13 +1,9 @@
-query InstrumentQuery {
+query InstrumentsQuery {
   instruments {
-    edges {
-      node {
-        id
-        title
-        contents
-        slug
-        type
-      }
-    }
+    id
+    title
+    contents
+    slug
+    type
   }
 }

From 5fd5a5be4ad428c1506e20abfe5ed441914450dc Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Wed, 20 Oct 2021 13:57:32 +0200
Subject: [PATCH 04/20] Add new test for instruments page, start refactor and
 style changes

---
 client/build/webpack.base.conf.js             | 10 ++--
 client/cypress/fixtures/mocks.js              |  8 ++++
 .../frontend/instruments-page.spec.js         | 12 ++++-
 client/package-lock.json                      | 14 ++++++
 .../components/instruments/FilterGroup.vue    | 25 ++++++++++
 .../instruments/InstrumentFilter.vue          | 48 +++++++++++--------
 client/src/pages/instrumentOverview.vue       | 25 ++--------
 7 files changed, 96 insertions(+), 46 deletions(-)
 create mode 100644 client/src/components/instruments/FilterGroup.vue

diff --git a/client/build/webpack.base.conf.js b/client/build/webpack.base.conf.js
index b70630b9..81b79aca 100644
--- a/client/build/webpack.base.conf.js
+++ b/client/build/webpack.base.conf.js
@@ -2,7 +2,7 @@
 const path = require('path');
 const config = require('../config');
 
-const VueLoaderPlugin = require('vue-loader/lib/plugin');
+const {VueLoaderPlugin} = require('vue-loader');
 
 const {isDev, styleRule, assetsPath} = require('./utils');
 
@@ -42,7 +42,7 @@ module.exports = {
     alias: {
       '@': resolve('src'),
       styles: resolve('src/styles'),
-      gql: resolve('src/graphql/gql')
+      gql: resolve('src/graphql/gql'),
     },
   },
   module: {
@@ -64,9 +64,9 @@ module.exports = {
         test: /\.tsx?$/,
         loader: 'ts-loader',
         options: {
-          appendTsSuffixTo: [/\.vue$/]
+          appendTsSuffixTo: [/\.vue$/],
         },
-        exclude: /node_modules/
+        exclude: /node_modules/,
       },
       {
         test: /\.js$/,
@@ -79,7 +79,7 @@ module.exports = {
       {
         test: /\.(gql|graphql)$/,
         loader: 'graphql-tag/loader',
-        exclude: /node_modules/
+        exclude: /node_modules/,
       },
       {
         test: /\.(png|jpe?g|gif|svg)(\?.*)?$/,
diff --git a/client/cypress/fixtures/mocks.js b/client/cypress/fixtures/mocks.js
index f66111a1..61cddee1 100644
--- a/client/cypress/fixtures/mocks.js
+++ b/client/cypress/fixtures/mocks.js
@@ -20,11 +20,13 @@ const classMemberIdIterator = idGenerator('ClassMemberNode');
 const chapterIdIterator = idGenerator('ChapterNode');
 const moduleIdIterator = idGenerator('ModuleNode');
 const contentBlockIdIterator = idGenerator('ContentBlockNode');
+const instrumentIdGenerator = idGenerator('InstrumentNode');
 
 const getClassMemberId = () => classMemberIdIterator.next().value;
 const getChapterId = () => chapterIdIterator.next().value;
 const getModuleId = () => moduleIdIterator.next().value;
 const getContentBlockId = () => contentBlockIdIterator.next().value;
+const getInstrumentId = () => instrumentIdGenerator.next().value;
 
 export default {
   UUID: () => '123-456-789',
@@ -109,4 +111,10 @@ export default {
     title: 'A Room Entry',
     contents: [],
   }),
+  InstrumentNode: () => ({
+    contents: [],
+    title: 'instrument-title',
+    slug: 'instrument-slug',
+    id: getInstrumentId(),
+  })
 };
diff --git a/client/cypress/integration/frontend/instruments-page.spec.js b/client/cypress/integration/frontend/instruments-page.spec.js
index 1a7cfa19..66e15e2b 100644
--- a/client/cypress/integration/frontend/instruments-page.spec.js
+++ b/client/cypress/integration/frontend/instruments-page.spec.js
@@ -8,10 +8,20 @@ describe('Instruments Page', () => {
       operations: {
         MeQuery: {},
         InstrumentsQuery: {
-          instruments: []
+          instruments: [
+            {},
+            {}
+          ]
         }
       }
     });
     cy.visit('instruments/');
+
+    cy.getByDataCy('filter-all-instruments').should('exist');
+    cy.getByDataCy('filter-language-communication').should('exist');
+    cy.getByDataCy('filter-society').should('exist');
+    cy.getByDataCy('filter-interdisciplinary').should('exist');
+    cy.getByDataCy('filter-analysis').should('exist');
+    cy.getByDataCy('filter-ethics').should('exist');
   });
 });
diff --git a/client/package-lock.json b/client/package-lock.json
index d8001d86..723c1d84 100644
--- a/client/package-lock.json
+++ b/client/package-lock.json
@@ -18294,6 +18294,13 @@
       "integrity": "sha512-q8GgAIPU7xHCsUhB1PUgR//8GoI0bUdMRUKd69jw2UcKy7pGuu0NbJsOGqdSpdpvhO4LY/dgqohPEkE1TrBwKQ==",
       "requires": {
         "vue": "^2.1.10"
+      },
+      "dependencies": {
+        "vue": {
+          "version": "2.6.14",
+          "resolved": "https://registry.npmjs.org/vue/-/vue-2.6.14.tgz",
+          "integrity": "sha512-x2284lgYvjOMj3Za7kqzRcUSxBboHqtgRE2zlos1qWaOye5yUmHn42LB1250NJBLRwEcdrB0JRwyPTEPhfQjiQ=="
+        }
       }
     },
     "svgo": {
@@ -19724,6 +19731,13 @@
         "babel-preset-env": "^1.6.0",
         "rollup-plugin-babel": "^3.0.2",
         "vue": "^2.4.4"
+      },
+      "dependencies": {
+        "vue": {
+          "version": "2.6.14",
+          "resolved": "https://registry.npmjs.org/vue/-/vue-2.6.14.tgz",
+          "integrity": "sha512-x2284lgYvjOMj3Za7kqzRcUSxBboHqtgRE2zlos1qWaOye5yUmHn42LB1250NJBLRwEcdrB0JRwyPTEPhfQjiQ=="
+        }
       }
     },
     "vuejs-logger": {
diff --git a/client/src/components/instruments/FilterGroup.vue b/client/src/components/instruments/FilterGroup.vue
new file mode 100644
index 00000000..e9313a58
--- /dev/null
+++ b/client/src/components/instruments/FilterGroup.vue
@@ -0,0 +1,25 @@
+<template>
+  <div class="filter-group">
+    <a v-bind="$attrs">{{ title }}</a>
+  </div>
+</template>
+
+<script>
+  export default {
+    props: {
+      title: {
+        type: String,
+        default: ''
+      }
+    },
+    inheritAttrs: false
+  };
+</script>
+
+<style scoped lang="scss">
+  @import '~styles/helpers';
+
+  .filter-group {
+    border-bottom: 1px solid black;
+  }
+</style>
diff --git a/client/src/components/instruments/InstrumentFilter.vue b/client/src/components/instruments/InstrumentFilter.vue
index 82f8e082..9591c40c 100644
--- a/client/src/components/instruments/InstrumentFilter.vue
+++ b/client/src/components/instruments/InstrumentFilter.vue
@@ -1,24 +1,33 @@
 <template>
   <div class="instrument-filter">
-    <checkbox
-      :checked="type.enabled"
-      :class="`instrument-filter__checkbox--${type.cls}`"
-      :label="type.label"
-      :key="i"
-      class="instrument-filter__checkbox"
-      v-for="(type, i) in types"
-      @input="change($event, i)"
-    />
+    <filter-group
+      title="Alle Instrumente"
+      data-cy="filter-all-instruments"/>
+
+    <filter-group
+      title="Sprache und Kommunikation"
+      data-cy="filter-language-communication"/>
+
+    <filter-group
+      title="Gesellschaft"
+      data-cy="filter-society"/>
+
+    <filter-group
+      title="Überfachliche Instrumente"
+      data-cy="filter-society"/>
+
   </div>
 </template>
 
 <script>
   import Checkbox from '@/components/ui/Checkbox';
+  import FilterGroup from '@/components/instruments/FilterGroup';
 
   export default {
 
     components: {
-      Checkbox
+      FilterGroup,
+      Checkbox,
     },
     data() {
       return {
@@ -28,21 +37,21 @@
             label: 'Sprache und Kommunikation',
             enabled: true,
             prop: 'LANGUAGE_COMMUNICATION',
-            cls: 'language'
+            cls: 'language',
           },
           {
             label: 'Gesellschaft',
             enabled: true,
             prop: 'SOCIETY',
-            cls: 'society'
+            cls: 'society',
           },
           {
             label: 'Überfachliches Instrument',
             enabled: true,
             prop: 'INTERDISCIPLINARY',
-            cls: 'interdisciplinary'
+            cls: 'interdisciplinary',
           },
-        ]
+        ],
       };
     },
 
@@ -53,26 +62,27 @@
           ...this.types.slice(0, index),
           {
             ...type,
-            enabled
+            enabled,
           },
           ...this.types.slice(index + 1),
         ];
         this.$emit('filter',
           this.types
             .filter(t => t.enabled)
-            .map(t => t.prop)
+            .map(t => t.prop),
         );
-      }
+      },
     },
   };
 </script>
 
 <style scoped lang="scss">
-  @import "@/styles/_variables.scss";
+  @import "~styles/helpers";
 
   .instrument-filter {
     display: flex;
-    align-content: center;
+    flex-direction: column;
+    //align-content: center;
 
     &__checkbox {
       &--language {
diff --git a/client/src/pages/instrumentOverview.vue b/client/src/pages/instrumentOverview.vue
index c28387de..228530f3 100644
--- a/client/src/pages/instrumentOverview.vue
+++ b/client/src/pages/instrumentOverview.vue
@@ -1,10 +1,5 @@
 <template>
   <div class="instrument-overview">
-    <div class="instrument-overview__heading">
-      <h1 class="instrument-overview__title">
-        Instrumente
-      </h1>
-    </div>
     <instrument-filter
       class="instrument-overview__filter"
       @filter="updateFilter"/>
@@ -65,24 +60,12 @@
 
   .instrument-overview {
     display: grid;
-    grid-template-rows: auto auto 1fr;
-    @include centered(800px);
-
-    &__heading {
-      padding: 2*$large-spacing 0;
-      width: 100%;
-      display: flex;
-      justify-content: flex-start;
-    }
-
-    &__title {
-      max-width: $screen-width;
-      line-height: 1.2;
-      margin-bottom: 0;
-    }
+    //grid-template-rows: auto auto 1fr;
+    grid-template-columns: 300px auto;
+    //@include centered(800px);
 
     &__filter {
-      justify-self: start;
+
     }
 
     &__list {

From 14e9a4d6ecb3587435b8cc161ef6c58f53e650ef Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Wed, 20 Oct 2021 14:02:31 +0200
Subject: [PATCH 05/20] Update BasicKnowledge model with new type property

---
 server/api/schema.py                          |  2 +-
 .../migrations/0008_auto_20211020_1202.py     | 27 ++++++++++++++
 server/basicknowledge/models.py               | 36 ++++++++++++-------
 server/basicknowledge/queries.py              |  2 +-
 server/schema.graphql                         |  2 +-
 5 files changed, 53 insertions(+), 16 deletions(-)
 create mode 100644 server/basicknowledge/migrations/0008_auto_20211020_1202.py

diff --git a/server/api/schema.py b/server/api/schema.py
index 2bfb147c..f52cc2dd 100644
--- a/server/api/schema.py
+++ b/server/api/schema.py
@@ -27,7 +27,7 @@ from users.mutations import ProfileMutations
 
 
 class CustomQuery(UsersQuery, AllUsersQuery, ModuleRoomsQuery, RoomsQuery, ObjectivesQuery, BookQuery, AssignmentsQuery,
-            StudentSubmissionQuery, BasicKnowledgeQuery, PortfolioQuery, SurveysQuery, AllNewsTeasersQuery, graphene.ObjectType):
+                  StudentSubmissionQuery, BasicKnowledgeQuery, PortfolioQuery, SurveysQuery, AllNewsTeasersQuery, graphene.ObjectType):
     node = relay.Node.Field()
 
     if settings.DEBUG:
diff --git a/server/basicknowledge/migrations/0008_auto_20211020_1202.py b/server/basicknowledge/migrations/0008_auto_20211020_1202.py
new file mode 100644
index 00000000..5194e011
--- /dev/null
+++ b/server/basicknowledge/migrations/0008_auto_20211020_1202.py
@@ -0,0 +1,27 @@
+# Generated by Django 2.2.24 on 2021-10-20 12:02
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('basicknowledge', '0007_basicknowledge_intro'),
+    ]
+
+    operations = [
+        migrations.CreateModel(
+            name='InstrumentType',
+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('name', models.CharField(max_length=255)),
+                ('category', models.CharField(choices=[('language_communication', 'Sprache & Kommunikation'), ('society', 'Gesellschaft'), ('interdisciplinary', 'Überfachliches Instrument')], max_length=100)),
+            ],
+        ),
+        migrations.AddField(
+            model_name='basicknowledge',
+            name='new_type',
+            field=models.ForeignKey(null=True, on_delete=django.db.models.deletion.PROTECT, to='basicknowledge.InstrumentType'),
+        ),
+    ]
diff --git a/server/basicknowledge/models.py b/server/basicknowledge/models.py
index 128b95f3..dc317e7e 100644
--- a/server/basicknowledge/models.py
+++ b/server/basicknowledge/models.py
@@ -1,13 +1,31 @@
 from django.db import models
 from wagtail.admin.edit_handlers import FieldPanel, StreamFieldPanel
-from wagtail.core.fields import StreamField, RichTextField
+from wagtail.core.fields import RichTextField, StreamField
 from wagtail.images.blocks import ImageChooserBlock
 
-from books.blocks import LinkBlock, VideoBlock, DocumentBlock, SectionTitleBlock, InfogramBlock, \
-    GeniallyBlock, InstrumentTextBlock, SubtitleBlock, ThinglinkBlock
+from books.blocks import DocumentBlock, GeniallyBlock, InfogramBlock, InstrumentTextBlock, LinkBlock, SectionTitleBlock, \
+    SubtitleBlock, ThinglinkBlock, VideoBlock
 from core.constants import DEFAULT_RICH_TEXT_FEATURES
 from core.wagtail_utils import StrictHierarchyPage
 
+LANGUAGE_COMMUNICATION = 'language_communication'
+SOCIETY = 'society'
+INTERDISCIPLINARY = 'interdisciplinary'
+
+CATEGORY_CHOICES = (
+    (LANGUAGE_COMMUNICATION, 'Sprache & Kommunikation'),
+    (SOCIETY, 'Gesellschaft'),
+    (INTERDISCIPLINARY, 'Überfachliches Instrument'),
+)
+
+
+class InstrumentType(models.Model):
+    name = models.CharField(max_length=255)
+    category = models.CharField(
+        max_length=100,
+        choices=CATEGORY_CHOICES
+    )
+
 
 class BasicKnowledge(StrictHierarchyPage):
     parent_page_types = ['books.book']
@@ -27,19 +45,11 @@ class BasicKnowledge(StrictHierarchyPage):
         ('subtitle', SubtitleBlock()),
     ], null=True, blank=True)
 
-    LANGUAGE_COMMUNICATION = 'language_communication'
-    SOCIETY = 'society'
-    INTERDISCIPLINARY = 'interdisciplinary'
-
-    TYPE_CHOICES = (
-        (LANGUAGE_COMMUNICATION, 'Sprache & Kommunikation'),
-        (SOCIETY, 'Gesellschaft'),
-        (INTERDISCIPLINARY, 'Überfachliches Instrument'),
-    )
+    new_type = models.ForeignKey(InstrumentType, null=True, on_delete=models.PROTECT)
 
     type = models.CharField(
         max_length=100,
-        choices=TYPE_CHOICES
+        choices=CATEGORY_CHOICES
     )
 
     content_panels = [
diff --git a/server/basicknowledge/queries.py b/server/basicknowledge/queries.py
index 3481c057..73cd774d 100644
--- a/server/basicknowledge/queries.py
+++ b/server/basicknowledge/queries.py
@@ -28,7 +28,7 @@ class InstrumentNode(DjangoObjectType):
 
 class BasicKnowledgeQuery(object):
     instrument = graphene.Field(InstrumentNode, slug=graphene.String(), id=graphene.ID())
-    instruments = DjangoFilterConnectionField(InstrumentNode)
+    instruments = graphene.List(InstrumentNode)
 
     def resolve_instrument(self, info, **kwargs):
         slug = kwargs.get('slug')
diff --git a/server/schema.graphql b/server/schema.graphql
index 2ca10551..b835edf2 100644
--- a/server/schema.graphql
+++ b/server/schema.graphql
@@ -461,7 +461,7 @@ type CustomQuery {
   project(id: ID, slug: String): ProjectNode
   projects: [ProjectNode]
   instrument(slug: String, id: ID): InstrumentNode
-  instruments(offset: Int, before: String, after: String, first: Int, last: Int, slug: String, type: String): InstrumentNodeConnection
+  instruments: [InstrumentNode]
   studentSubmission(id: ID!): StudentSubmissionNode
   assignment(id: ID!): AssignmentNode
   assignments(offset: Int, before: String, after: String, first: Int, last: Int): AssignmentNodeConnection

From 072258fac0d8dedc08b127dd7794a8ee796750ba Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Wed, 20 Oct 2021 14:03:33 +0200
Subject: [PATCH 06/20] Rename BasicKnowledgeQuery to InstrumentQuery

---
 server/api/schema.py             | 4 ++--
 server/basicknowledge/queries.py | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/server/api/schema.py b/server/api/schema.py
index f52cc2dd..9a290a61 100644
--- a/server/api/schema.py
+++ b/server/api/schema.py
@@ -7,7 +7,7 @@ from graphene_django.debug import DjangoDebug
 from api import graphene_wagtail  # Keep this import exactly here, it's necessary for StreamField conversion
 from assignments.schema.mutations import AssignmentMutations
 from assignments.schema.queries import AssignmentsQuery, StudentSubmissionQuery
-from basicknowledge.queries import BasicKnowledgeQuery
+from basicknowledge.queries import InstrumentQuery
 from books.schema.mutations import BookMutations
 from books.schema.queries import BookQuery
 from news.schema import AllNewsTeasersQuery
@@ -27,7 +27,7 @@ from users.mutations import ProfileMutations
 
 
 class CustomQuery(UsersQuery, AllUsersQuery, ModuleRoomsQuery, RoomsQuery, ObjectivesQuery, BookQuery, AssignmentsQuery,
-                  StudentSubmissionQuery, BasicKnowledgeQuery, PortfolioQuery, SurveysQuery, AllNewsTeasersQuery, graphene.ObjectType):
+                  StudentSubmissionQuery, InstrumentQuery, PortfolioQuery, SurveysQuery, AllNewsTeasersQuery, graphene.ObjectType):
     node = relay.Node.Field()
 
     if settings.DEBUG:
diff --git a/server/basicknowledge/queries.py b/server/basicknowledge/queries.py
index 73cd774d..702e8133 100644
--- a/server/basicknowledge/queries.py
+++ b/server/basicknowledge/queries.py
@@ -26,7 +26,7 @@ class InstrumentNode(DjangoObjectType):
             instrument=self
         )
 
-class BasicKnowledgeQuery(object):
+class InstrumentQuery(object):
     instrument = graphene.Field(InstrumentNode, slug=graphene.String(), id=graphene.ID())
     instruments = graphene.List(InstrumentNode)
 

From ab60aaf9b8f06e6f3e246118fb3f6fbfa94414ba Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Mon, 25 Oct 2021 11:48:43 +0200
Subject: [PATCH 07/20] Add new types

---
 .../migrations/0009_auto_20211020_1213.py     | 56 +++++++++++++++++++
 server/basicknowledge/models.py               | 19 ++++---
 server/basicknowledge/queries.py              |  5 ++
 3 files changed, 72 insertions(+), 8 deletions(-)
 create mode 100644 server/basicknowledge/migrations/0009_auto_20211020_1213.py

diff --git a/server/basicknowledge/migrations/0009_auto_20211020_1213.py b/server/basicknowledge/migrations/0009_auto_20211020_1213.py
new file mode 100644
index 00000000..0090f5c5
--- /dev/null
+++ b/server/basicknowledge/migrations/0009_auto_20211020_1213.py
@@ -0,0 +1,56 @@
+# Generated by Django 2.2.24 on 2021-10-20 12:13
+
+from django.db import migrations
+
+from basicknowledge.models import INTERDISCIPLINARY, LANGUAGE_COMMUNICATION, SOCIETY
+
+
+def create_types(apps, schema_editor):
+    BasicKnowledge = apps.get_model('basicknowledge', 'BasicKnowledge')
+    InstrumentType = apps.get_model('basicknowledge', 'InstrumentType')
+    language_type=InstrumentType.objects.create(
+        name='Sprache & Kommunikation',
+        category=LANGUAGE_COMMUNICATION
+    )
+    society_type=InstrumentType.objects.create(
+        name='Gesellschaft',
+        category=SOCIETY
+    )
+    interdisciplinary_type=InstrumentType.objects.create(
+        name='Überfachliches Instrument',
+        category=INTERDISCIPLINARY
+    )
+    instruments = []
+    for instrument in BasicKnowledge.objects.filter(type=LANGUAGE_COMMUNICATION):
+        instrument.new_type=language_type
+        instruments.append(instrument)
+    for instrument in BasicKnowledge.objects.filter(type=SOCIETY):
+        instrument.new_type=society_type
+        instruments.append(instrument)
+    for instrument in BasicKnowledge.objects.filter(type=INTERDISCIPLINARY):
+        instrument.new_type=interdisciplinary_type
+        instruments.append(instrument)
+
+    BasicKnowledge.objects.bulk_update(instruments, ['new_type'])
+
+
+def delete_types(apps, schema_editor):
+    BasicKnowledge = apps.get_model('basicknowledge', 'BasicKnowledge')
+    InstrumentType = apps.get_model('basicknowledge', 'InstrumentType')
+    instruments = []
+    for instrument in BasicKnowledge.objects.all():
+        instrument.new_type = None
+        instruments.append(instrument)
+    BasicKnowledge.objects.bulk_update(instruments, ['new_type'])
+    InstrumentType.objects.all().delete()
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('basicknowledge', '0008_auto_20211020_1202'),
+    ]
+
+    operations = [
+        migrations.RunPython(create_types, delete_types)
+    ]
diff --git a/server/basicknowledge/models.py b/server/basicknowledge/models.py
index dc317e7e..b45b5aa0 100644
--- a/server/basicknowledge/models.py
+++ b/server/basicknowledge/models.py
@@ -12,20 +12,23 @@ LANGUAGE_COMMUNICATION = 'language_communication'
 SOCIETY = 'society'
 INTERDISCIPLINARY = 'interdisciplinary'
 
-CATEGORY_CHOICES = (
-    (LANGUAGE_COMMUNICATION, 'Sprache & Kommunikation'),
-    (SOCIETY, 'Gesellschaft'),
-    (INTERDISCIPLINARY, 'Überfachliches Instrument'),
-)
-
 
 class InstrumentType(models.Model):
+    CATEGORY_CHOICES = (
+        (LANGUAGE_COMMUNICATION, 'Sprache & Kommunikation'),
+        (SOCIETY, 'Gesellschaft'),
+        (INTERDISCIPLINARY, 'Überfachliches Instrument'),
+    )
+
     name = models.CharField(max_length=255)
     category = models.CharField(
         max_length=100,
         choices=CATEGORY_CHOICES
     )
 
+    def __str__(self):
+        return self.name
+
 
 class BasicKnowledge(StrictHierarchyPage):
     parent_page_types = ['books.book']
@@ -47,9 +50,9 @@ class BasicKnowledge(StrictHierarchyPage):
 
     new_type = models.ForeignKey(InstrumentType, null=True, on_delete=models.PROTECT)
 
-    type = models.CharField(
+    old_type = models.CharField(
         max_length=100,
-        choices=CATEGORY_CHOICES
+        choices=InstrumentType.CATEGORY_CHOICES
     )
 
     content_panels = [
diff --git a/server/basicknowledge/queries.py b/server/basicknowledge/queries.py
index 702e8133..0098b34f 100644
--- a/server/basicknowledge/queries.py
+++ b/server/basicknowledge/queries.py
@@ -11,6 +11,7 @@ from .models import BasicKnowledge
 
 class InstrumentNode(DjangoObjectType):
     bookmarks = graphene.List(InstrumentBookmarkNode)
+    type = graphene.String()
 
     class Meta:
         model = BasicKnowledge
@@ -20,6 +21,10 @@ class InstrumentNode(DjangoObjectType):
             'slug', 'title', 'intro', 'type', 'contents',
         ]
 
+    @staticmethod
+    def resolve_type(root: BasicKnowledge, info, **kwargs):
+        return root.new_type.name
+
     def resolve_bookmarks(self, info, **kwargs):
         return InstrumentBookmark.objects.filter(
             user=info.context.user,

From 26b1c3e8afd7b1edc35462cd9bdd81b7e75d99ad Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Mon, 25 Oct 2021 12:10:10 +0200
Subject: [PATCH 08/20] Fix model definition

---
 server/basicknowledge/models.py  | 2 +-
 server/basicknowledge/queries.py | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/server/basicknowledge/models.py b/server/basicknowledge/models.py
index b45b5aa0..b1d3755f 100644
--- a/server/basicknowledge/models.py
+++ b/server/basicknowledge/models.py
@@ -57,7 +57,7 @@ class BasicKnowledge(StrictHierarchyPage):
 
     content_panels = [
         FieldPanel('title', classname="full title"),
-        FieldPanel('type'),
+        FieldPanel('new_type'),
         FieldPanel('intro'),
         StreamFieldPanel('contents')
     ]
diff --git a/server/basicknowledge/queries.py b/server/basicknowledge/queries.py
index 0098b34f..d6809bf7 100644
--- a/server/basicknowledge/queries.py
+++ b/server/basicknowledge/queries.py
@@ -15,10 +15,10 @@ class InstrumentNode(DjangoObjectType):
 
     class Meta:
         model = BasicKnowledge
-        filter_fields = ['slug', 'type']
+        filter_fields = ['slug']
         interfaces = (relay.Node,)
         only_fields = [
-            'slug', 'title', 'intro', 'type', 'contents',
+            'slug', 'title', 'intro', 'contents',
         ]
 
     @staticmethod

From 66a0427183026b90848556f3e713e0abed20e4fc Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Sat, 30 Oct 2021 21:56:52 +0200
Subject: [PATCH 09/20] Update sidebar test

---
 .../integration/frontend/sidebar.spec.js      | 21 +++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/client/cypress/integration/frontend/sidebar.spec.js b/client/cypress/integration/frontend/sidebar.spec.js
index b4802f59..9163015f 100644
--- a/client/cypress/integration/frontend/sidebar.spec.js
+++ b/client/cypress/integration/frontend/sidebar.spec.js
@@ -6,21 +6,34 @@ describe('Sidebar', () => {
   });
 
   it('should open sidebar and stay open', () => {
+    const {me} = getMinimalMe({});
     const operations = {
-      MeQuery: getMinimalMe({}),
+      MeQuery: {
+        me: {
+          ...me,
+          schoolClasses: {
+            edges: [
+              ...me.schoolClasses.edges,
+              {node: {}},
+            ],
+          },
+        },
+      },
       ProjectsQuery: {
-        projects: []
-      }
+        projects: [],
+      },
     };
 
     cy.mockGraphqlOps({
-      operations
+      operations,
     });
 
     cy.visit('/portfolio');
     cy.getByDataCy('sidebar').should('not.exist');
     cy.getByDataCy('user-widget-avatar').click();
     cy.getByDataCy('sidebar').should('exist');
+    cy.getByDataCy('class-selection').click();
+    cy.getByDataCy('class-selection-entry').should('have.length', 2);
     cy.getByDataCy('close-profile-sidebar-link').click();
     cy.getByDataCy('sidebar').should('not.exist');
   });

From ac6c60f8c32843972a2ea8ce8a3b22d081269cad Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Sat, 30 Oct 2021 22:29:31 +0200
Subject: [PATCH 10/20] Add instrument type query

---
 .../instruments/InstrumentFilter.vue          |  8 +++++++
 .../gql/queries/instrumentTypesQuery.gql      |  6 +++++
 .../gql/queries/instrumentsByTypeQuery.gql    | 12 ----------
 .../graphql/gql/queries/instrumentsQuery.gql  |  1 +
 .../migrations/0010_auto_20211030_2004.py     | 18 +++++++++++++++
 server/basicknowledge/queries.py              | 19 ++++++++++++++-
 server/schema.graphql                         | 23 ++++++++++++-------
 7 files changed, 66 insertions(+), 21 deletions(-)
 create mode 100644 client/src/graphql/gql/queries/instrumentTypesQuery.gql
 delete mode 100644 client/src/graphql/gql/queries/instrumentsByTypeQuery.gql
 create mode 100644 server/basicknowledge/migrations/0010_auto_20211030_2004.py

diff --git a/client/src/components/instruments/InstrumentFilter.vue b/client/src/components/instruments/InstrumentFilter.vue
index 9591c40c..9e7e356b 100644
--- a/client/src/components/instruments/InstrumentFilter.vue
+++ b/client/src/components/instruments/InstrumentFilter.vue
@@ -23,6 +23,8 @@
   import Checkbox from '@/components/ui/Checkbox';
   import FilterGroup from '@/components/instruments/FilterGroup';
 
+  import INSTRUMENT_TYPES_QUERY from 'gql/queries/instrumentTypesQuery';
+
   export default {
 
     components: {
@@ -55,6 +57,12 @@
       };
     },
 
+    apollo: {
+      instrumentTypes: {
+        query: INSTRUMENT_TYPES_QUERY
+      }
+    },
+
     methods: {
       change(enabled, index) {
         let type = this.types[index];
diff --git a/client/src/graphql/gql/queries/instrumentTypesQuery.gql b/client/src/graphql/gql/queries/instrumentTypesQuery.gql
new file mode 100644
index 00000000..60ea4ad9
--- /dev/null
+++ b/client/src/graphql/gql/queries/instrumentTypesQuery.gql
@@ -0,0 +1,6 @@
+query InstrumentTypesQuery {
+  instrumentTypes {
+    name
+    category
+  }
+}
diff --git a/client/src/graphql/gql/queries/instrumentsByTypeQuery.gql b/client/src/graphql/gql/queries/instrumentsByTypeQuery.gql
deleted file mode 100644
index aa84aca6..00000000
--- a/client/src/graphql/gql/queries/instrumentsByTypeQuery.gql
+++ /dev/null
@@ -1,12 +0,0 @@
-query InstrumentsQuery($type: String!){
-  instruments(type: $type) {
-    edges {
-      node {
-        id
-        title
-        contents
-        slug
-      }
-    }
-  }
-}
diff --git a/client/src/graphql/gql/queries/instrumentsQuery.gql b/client/src/graphql/gql/queries/instrumentsQuery.gql
index c87588ba..bf7c9c49 100644
--- a/client/src/graphql/gql/queries/instrumentsQuery.gql
+++ b/client/src/graphql/gql/queries/instrumentsQuery.gql
@@ -5,5 +5,6 @@ query InstrumentsQuery {
     contents
     slug
     type
+    category
   }
 }
diff --git a/server/basicknowledge/migrations/0010_auto_20211030_2004.py b/server/basicknowledge/migrations/0010_auto_20211030_2004.py
new file mode 100644
index 00000000..19a987f5
--- /dev/null
+++ b/server/basicknowledge/migrations/0010_auto_20211030_2004.py
@@ -0,0 +1,18 @@
+# Generated by Django 2.2.24 on 2021-10-30 20:04
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('basicknowledge', '0009_auto_20211020_1213'),
+    ]
+
+    operations = [
+        migrations.RenameField(
+            model_name='basicknowledge',
+            old_name='type',
+            new_name='old_type',
+        ),
+    ]
diff --git a/server/basicknowledge/queries.py b/server/basicknowledge/queries.py
index d6809bf7..e1339205 100644
--- a/server/basicknowledge/queries.py
+++ b/server/basicknowledge/queries.py
@@ -6,12 +6,21 @@ from graphene_django.filter import DjangoFilterConnectionField
 from api.utils import get_object
 from notes.models import InstrumentBookmark
 from notes.schema import InstrumentBookmarkNode
-from .models import BasicKnowledge
+from .models import BasicKnowledge, InstrumentType
+
+
+class InstrumentTypeNode(DjangoObjectType):
+    class Meta:
+        model = InstrumentType
+        only_fields = [
+            'name', 'category'
+        ]
 
 
 class InstrumentNode(DjangoObjectType):
     bookmarks = graphene.List(InstrumentBookmarkNode)
     type = graphene.String()
+    category = graphene.String()
 
     class Meta:
         model = BasicKnowledge
@@ -25,6 +34,10 @@ class InstrumentNode(DjangoObjectType):
     def resolve_type(root: BasicKnowledge, info, **kwargs):
         return root.new_type.name
 
+    @staticmethod
+    def resolve_category(root: BasicKnowledge, info, **kwargs):
+        return root.new_type.category
+
     def resolve_bookmarks(self, info, **kwargs):
         return InstrumentBookmark.objects.filter(
             user=info.context.user,
@@ -34,6 +47,7 @@ class InstrumentNode(DjangoObjectType):
 class InstrumentQuery(object):
     instrument = graphene.Field(InstrumentNode, slug=graphene.String(), id=graphene.ID())
     instruments = graphene.List(InstrumentNode)
+    instrument_types = graphene.List(InstrumentTypeNode)
 
     def resolve_instrument(self, info, **kwargs):
         slug = kwargs.get('slug')
@@ -47,3 +61,6 @@ class InstrumentQuery(object):
 
     def resolve_instruments(self, info, **kwargs):
         return BasicKnowledge.objects.all().live()
+
+    def resolve_instrument_types(self, info, **kwargs):
+        return InstrumentType.objects.all()
diff --git a/server/schema.graphql b/server/schema.graphql
index b835edf2..105ff4ce 100644
--- a/server/schema.graphql
+++ b/server/schema.graphql
@@ -206,12 +206,6 @@ type AssignmentNodeEdge {
   cursor: String!
 }
 
-enum BasicKnowledgeType {
-  LANGUAGE_COMMUNICATION
-  SOCIETY
-  INTERDISCIPLINARY
-}
-
 type ChapterBookmarkNode implements Node {
   user: PrivateUserNode!
   note: NoteNode
@@ -462,6 +456,7 @@ type CustomQuery {
   projects: [ProjectNode]
   instrument(slug: String, id: ID): InstrumentNode
   instruments: [InstrumentNode]
+  instrumentTypes: [InstrumentTypeNode]
   studentSubmission(id: ID!): StudentSubmissionNode
   assignment(id: ID!): AssignmentNode
   assignments(offset: Int, before: String, after: String, first: Int, last: Int): AssignmentNodeConnection
@@ -484,7 +479,7 @@ type CustomQuery {
   me: PrivateUserNode
   allUsers(offset: Int, before: String, after: String, first: Int, last: Int, username: String, email: String): PrivateUserNodeConnection
   myActivity(offset: Int, before: String, after: String, first: Int, last: Int, slug: String, slug_Icontains: String, slug_In: [String], title: String, title_Icontains: String, title_In: [String]): ModuleNodeConnection
-  myInstrumentActivity(offset: Int, before: String, after: String, first: Int, last: Int, slug: String, type: String): InstrumentNodeConnection
+  myInstrumentActivity(offset: Int, before: String, after: String, first: Int, last: Int, slug: String): InstrumentNodeConnection
   _debug: DjangoDebug
 }
 
@@ -609,9 +604,10 @@ type InstrumentNode implements Node {
   slug: String!
   intro: String!
   contents: GenericStreamFieldType
-  type: BasicKnowledgeType!
   id: ID!
   bookmarks: [InstrumentBookmarkNode]
+  type: String
+  category: String
 }
 
 type InstrumentNodeConnection {
@@ -624,6 +620,17 @@ type InstrumentNodeEdge {
   cursor: String!
 }
 
+enum InstrumentTypeCategory {
+  LANGUAGE_COMMUNICATION
+  SOCIETY
+  INTERDISCIPLINARY
+}
+
+type InstrumentTypeNode {
+  name: String!
+  category: InstrumentTypeCategory!
+}
+
 scalar JSONString
 
 input JoinClassInput {

From 08c4a6f7e12a2a6550aa8af519b652df0c817b46 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Tue, 26 Oct 2021 10:33:09 +0200
Subject: [PATCH 11/20] Fix permissions on project page

---
 .../frontend/portfolio/project-page.spec.js    | 18 ++++++++++++++++++
 client/src/graphql/client.js                   |  1 -
 client/src/pages/portfolio/project.vue         |  9 ++++++---
 3 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/client/cypress/integration/frontend/portfolio/project-page.spec.js b/client/cypress/integration/frontend/portfolio/project-page.spec.js
index 0105f9cf..2a03aa3e 100644
--- a/client/cypress/integration/frontend/portfolio/project-page.spec.js
+++ b/client/cypress/integration/frontend/portfolio/project-page.spec.js
@@ -144,6 +144,24 @@ describe('Project Page', () => {
     cy.getByDataCy('project-share-link').should('contain', unsharedText);
   });
 
+  it('cannot edit or delete the project as a teacher', () => {
+    cy.mockGraphqlOps({
+      operations: {
+        ...operations,
+        MeQuery: {
+          me: {
+            id: 'not-the-same',
+            isTeacher: true
+          },
+        },
+      },
+    });
+    cy.visit('/portfolio/groot');
+    cy.getByDataCy('project-actions').should('not.exist');
+    cy.getByDataCy('project-entry').should('have.length', 1);
+    cy.getByDataCy('project-entry-more').should('not.exist');
+  });
+
   describe('Project Entry', () => {
     it('should create a new project entry', () => {
       cy.visit('/portfolio');
diff --git a/client/src/graphql/client.js b/client/src/graphql/client.js
index 3ed2ec5c..2bfabfc8 100644
--- a/client/src/graphql/client.js
+++ b/client/src/graphql/client.js
@@ -107,7 +107,6 @@ export default function (uri, networkErrorCallback) {
         objectiveGroup: (_, args, {getCacheKey}) => getCacheKey({__typename: 'ObjectiveGroupNode', id: args.id}),
         projectEntry: (_, args, {getCacheKey}) => getCacheKey({__typename: 'ProjectEntryNode', id: args.id}),
         project: (_, args, {getCacheKey}) => {
-          console.log(args);
           if (args.slug) {
             return getCacheKey({__typename: 'ProjectNode', id: args.slug});
           } else {
diff --git a/client/src/pages/portfolio/project.vue b/client/src/pages/portfolio/project.vue
index a14ed984..b701df39 100644
--- a/client/src/pages/portfolio/project.vue
+++ b/client/src/pages/portfolio/project.vue
@@ -13,13 +13,13 @@
           :final="project.final"
           data-cy="project-share-link"
           class="project__share"
-          @click.native="updateProjectShareState(project.id, !project.final)" />
+          @click.native="updateProjectShareState(project.id, !project.final)"/>
 
         <project-actions
           :id="project.id"
           :share-buttons="false"
           class="project__more"
-          v-if="!me.readOnly && !me.selectedClass.readOnly"/>
+          v-if="canEdit"/>
 
       </div>
 
@@ -45,7 +45,7 @@
       <project-entry
         v-bind="entry"
         :key="index"
-        :read-only="me.readOnly || me.selectedClass.readOnly"
+        :read-only="!canEdit"
         v-for="(entry, index) in project.entries"/>
     </div>
   </div>
@@ -109,6 +109,9 @@
       projectEntryCount() {
         return this.project.entries ? this.project.entries.length : 0;
       },
+      canEdit() {
+        return !this.me.readOnly && !this.me.selectedClass.readOnly && this.isOwner;
+      },
     },
 
     apollo: {

From 4ba009fbb634bacb7925dcea08b44bde24034b33 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Sun, 31 Oct 2021 21:46:18 +0100
Subject: [PATCH 12/20] Update frontend test

---
 .../frontend/instruments-page.spec.js         | 83 ++++++++++++++++---
 1 file changed, 72 insertions(+), 11 deletions(-)

diff --git a/client/cypress/integration/frontend/instruments-page.spec.js b/client/cypress/integration/frontend/instruments-page.spec.js
index 66e15e2b..81362bb4 100644
--- a/client/cypress/integration/frontend/instruments-page.spec.js
+++ b/client/cypress/integration/frontend/instruments-page.spec.js
@@ -4,24 +4,85 @@ describe('Instruments Page', () => {
   });
 
   it('opens the instruments page', () => {
+    const analyse = {
+      name: 'Analyse',
+      category: 'LANGUAGE_COMMUNICATION',
+      type: 'analyse',
+    };
+
+    const argumentation = {
+      name: 'Argumentation',
+      category: 'LANGUAGE_COMMUNICATION',
+      type: 'argumentation',
+    };
+
+    const ethik = {
+      name: 'Ethik',
+      category: 'SOCIETY',
+      type: 'ethik',
+    };
+
     cy.mockGraphqlOps({
       operations: {
         MeQuery: {},
         InstrumentsQuery: {
           instruments: [
-            {},
-            {}
-          ]
-        }
-      }
+            {
+              type: analyse,
+              title: 'Instrument: Analyse',
+              slug: 'analyse',
+            },
+            {
+              type: argumentation,
+              title: 'Instrument: Argumentation',
+              slug: 'argumentation',
+            },
+            {
+              type: ethik,
+              title: 'Instrument: Ethik',
+              slug: 'ethik',
+            }
+          ],
+        },
+        InstrumentTypesQuery: {
+          instrumentTypes: [
+            analyse,
+            argumentation,
+            {
+              name: 'Beschreibung',
+              category: 'LANGUAGE_COMMUNICATION',
+              type: 'beschreibung',
+            },
+            ethik,
+            {
+              name: 'Identität und Sozialisation',
+              category: 'SOCIETY',
+              type: 'identitt-und-sozialisation',
+            },
+          ],
+        },
+      },
     });
     cy.visit('instruments/');
 
-    cy.getByDataCy('filter-all-instruments').should('exist');
-    cy.getByDataCy('filter-language-communication').should('exist');
-    cy.getByDataCy('filter-society').should('exist');
-    cy.getByDataCy('filter-interdisciplinary').should('exist');
-    cy.getByDataCy('filter-analysis').should('exist');
-    cy.getByDataCy('filter-ethics').should('exist');
+    cy.getByDataCy('instrument').should('have.length', 3);
+
+    cy.getByDataCy('filter-language-communication').click();
+    cy.getByDataCy('instrument').should('have.length', 2);
+
+    cy.getByDataCy('filter-society').click();
+    cy.getByDataCy('instrument').should('have.length', 1);
+
+    cy.getByDataCy('filter-interdisciplinary').click();
+    cy.getByDataCy('instrument').should('have.length', 0);
+
+    cy.getByDataCy('filter-analyse').click();
+    cy.getByDataCy('instrument').should('have.length', 1);
+
+    cy.getByDataCy('filter-ethik').click();
+    cy.getByDataCy('instrument').should('have.length', 1);
+
+    cy.getByDataCy('filter-all-instruments').click();
+    cy.getByDataCy('instrument').should('have.length', 3);
   });
 });

From 6407664f80831aa5043563c0e50996c6aa3fe708 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Sun, 31 Oct 2021 21:47:02 +0100
Subject: [PATCH 13/20] Update server definitions for instrument types

---
 .../migrations/0011_auto_20211031_1144.py     | 18 ++++++++++++++++++
 server/basicknowledge/models.py               |  9 +++++++--
 server/basicknowledge/queries.py              | 19 ++++++++++---------
 server/schema.graphql                         |  5 +++--
 4 files changed, 38 insertions(+), 13 deletions(-)
 create mode 100644 server/basicknowledge/migrations/0011_auto_20211031_1144.py

diff --git a/server/basicknowledge/migrations/0011_auto_20211031_1144.py b/server/basicknowledge/migrations/0011_auto_20211031_1144.py
new file mode 100644
index 00000000..d187aacb
--- /dev/null
+++ b/server/basicknowledge/migrations/0011_auto_20211031_1144.py
@@ -0,0 +1,18 @@
+# Generated by Django 2.2.24 on 2021-10-31 11:44
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('basicknowledge', '0010_auto_20211030_2004'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='instrumenttype',
+            name='name',
+            field=models.CharField(max_length=255, unique=True),
+        ),
+    ]
diff --git a/server/basicknowledge/models.py b/server/basicknowledge/models.py
index b1d3755f..3c987493 100644
--- a/server/basicknowledge/models.py
+++ b/server/basicknowledge/models.py
@@ -1,4 +1,5 @@
 from django.db import models
+from django.utils.text import slugify
 from wagtail.admin.edit_handlers import FieldPanel, StreamFieldPanel
 from wagtail.core.fields import RichTextField, StreamField
 from wagtail.images.blocks import ImageChooserBlock
@@ -20,14 +21,18 @@ class InstrumentType(models.Model):
         (INTERDISCIPLINARY, 'Überfachliches Instrument'),
     )
 
-    name = models.CharField(max_length=255)
+    name = models.CharField(max_length=255, unique=True)
     category = models.CharField(
         max_length=100,
         choices=CATEGORY_CHOICES
     )
 
+    @property
+    def type(self):
+        return slugify(self.name.lower())
+
     def __str__(self):
-        return self.name
+        return self.type
 
 
 class BasicKnowledge(StrictHierarchyPage):
diff --git a/server/basicknowledge/queries.py b/server/basicknowledge/queries.py
index e1339205..0b27f10b 100644
--- a/server/basicknowledge/queries.py
+++ b/server/basicknowledge/queries.py
@@ -1,7 +1,6 @@
 import graphene
 from graphene import relay
 from graphene_django import DjangoObjectType
-from graphene_django.filter import DjangoFilterConnectionField
 
 from api.utils import get_object
 from notes.models import InstrumentBookmark
@@ -10,17 +9,22 @@ from .models import BasicKnowledge, InstrumentType
 
 
 class InstrumentTypeNode(DjangoObjectType):
+    type = graphene.String(required=True)
+
     class Meta:
         model = InstrumentType
         only_fields = [
-            'name', 'category'
+            'name', 'category', 'type', 'id'
         ]
 
+    @staticmethod
+    def resolve_type(root: InstrumentType, info, **kwargs):
+        return root.type
+
 
 class InstrumentNode(DjangoObjectType):
     bookmarks = graphene.List(InstrumentBookmarkNode)
-    type = graphene.String()
-    category = graphene.String()
+    type = graphene.Field(InstrumentTypeNode)
 
     class Meta:
         model = BasicKnowledge
@@ -32,11 +36,7 @@ class InstrumentNode(DjangoObjectType):
 
     @staticmethod
     def resolve_type(root: BasicKnowledge, info, **kwargs):
-        return root.new_type.name
-
-    @staticmethod
-    def resolve_category(root: BasicKnowledge, info, **kwargs):
-        return root.new_type.category
+        return root.new_type
 
     def resolve_bookmarks(self, info, **kwargs):
         return InstrumentBookmark.objects.filter(
@@ -44,6 +44,7 @@ class InstrumentNode(DjangoObjectType):
             instrument=self
         )
 
+
 class InstrumentQuery(object):
     instrument = graphene.Field(InstrumentNode, slug=graphene.String(), id=graphene.ID())
     instruments = graphene.List(InstrumentNode)
diff --git a/server/schema.graphql b/server/schema.graphql
index 105ff4ce..692ebc21 100644
--- a/server/schema.graphql
+++ b/server/schema.graphql
@@ -606,8 +606,7 @@ type InstrumentNode implements Node {
   contents: GenericStreamFieldType
   id: ID!
   bookmarks: [InstrumentBookmarkNode]
-  type: String
-  category: String
+  type: InstrumentTypeNode
 }
 
 type InstrumentNodeConnection {
@@ -627,8 +626,10 @@ enum InstrumentTypeCategory {
 }
 
 type InstrumentTypeNode {
+  id: ID!
   name: String!
   category: InstrumentTypeCategory!
+  type: String!
 }
 
 scalar JSONString

From 8117a6b4c0123a6b6ded5335a492a248d1a4e6ad Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Sun, 31 Oct 2021 21:48:21 +0100
Subject: [PATCH 14/20] Add code for filtering instruments in frontend

Also add some styling
---
 .../components/instruments/FilterEntry.vue    | 41 +++++++++
 .../components/instruments/FilterGroup.vue    | 34 +++++++-
 .../instruments/InstrumentEntry.vue           | 85 ++++++++++++++++++
 .../instruments/InstrumentFilter.vue          | 87 +++++++++----------
 .../components/profile/InstrumentActivity.vue |  7 +-
 client/src/consts/instrument.consts.js        |  3 +
 .../gql/queries/instrumentTypesQuery.gql      |  1 +
 .../graphql/gql/queries/instrumentsQuery.gql  |  8 +-
 client/src/helpers/instrumentType.js          | 13 +++
 client/src/pages/instrumentOverview.vue       | 12 +--
 client/src/styles/mixins/_typography.scss     |  6 ++
 11 files changed, 236 insertions(+), 61 deletions(-)
 create mode 100644 client/src/components/instruments/FilterEntry.vue
 create mode 100644 client/src/components/instruments/InstrumentEntry.vue
 create mode 100644 client/src/consts/instrument.consts.js
 create mode 100644 client/src/helpers/instrumentType.js

diff --git a/client/src/components/instruments/FilterEntry.vue b/client/src/components/instruments/FilterEntry.vue
new file mode 100644
index 00000000..1b058eaf
--- /dev/null
+++ b/client/src/components/instruments/FilterEntry.vue
@@ -0,0 +1,41 @@
+<template>
+  <a class="filter-entry">
+    <span class="filter-entry__text">{{ text }}</span><chevron-right class="filter-entry__icon" />
+  </a>
+</template>
+
+<script>
+  import ChevronRight from '@/components/icons/ChevronRight';
+  export default {
+    props: {
+      text: {
+        type: String,
+        required: true
+      }
+    },
+
+    components: {
+      ChevronRight
+    }
+  };
+</script>
+
+<style scoped lang="scss">
+  @import '~styles/helpers';
+
+  .filter-entry {
+    display: flex;
+    justify-content: space-between;
+    align-items: center;
+
+    &__text {
+      @include sub-heading;
+      line-height: 1.5;
+    }
+
+    &__icon {
+      width: 10px;
+      height: 10px;
+    }
+  }
+</style>
diff --git a/client/src/components/instruments/FilterGroup.vue b/client/src/components/instruments/FilterGroup.vue
index e9313a58..a4ff330e 100644
--- a/client/src/components/instruments/FilterGroup.vue
+++ b/client/src/components/instruments/FilterGroup.vue
@@ -1,18 +1,38 @@
 <template>
   <div class="filter-group">
-    <a v-bind="$attrs">{{ title }}</a>
+    <filter-entry
+      :text="title"
+      v-bind="$attrs"
+      @click.native="$emit('click')"/>
+    <div class="filter-group__children">
+
+      <filter-entry
+        :key="type.id"
+        :data-cy="`filter-${type.type}`"
+        :text="type.name"
+        v-for="type in types"
+        @click.native="$emit('filter', i=>i.type.type===type.type)" />
+    </div>
   </div>
 </template>
 
 <script>
+  import ChevronRight from '@/components/icons/ChevronRight';
+  import FilterEntry from '@/components/instruments/FilterEntry';
+
   export default {
     props: {
       title: {
         type: String,
-        default: ''
-      }
+        default: '',
+      },
+      types: {
+        type: Array,
+        default: () => [],
+      },
     },
-    inheritAttrs: false
+    components: {FilterEntry, ChevronRight},
+    inheritAttrs: false,
   };
 </script>
 
@@ -21,5 +41,11 @@
 
   .filter-group {
     border-bottom: 1px solid black;
+    display: flex;
+    flex-direction: column;
+
+    &__children {
+      padding-left: $medium-spacing;
+    }
   }
 </style>
diff --git a/client/src/components/instruments/InstrumentEntry.vue b/client/src/components/instruments/InstrumentEntry.vue
new file mode 100644
index 00000000..ea127195
--- /dev/null
+++ b/client/src/components/instruments/InstrumentEntry.vue
@@ -0,0 +1,85 @@
+<template>
+  <div
+    :class="typeClass"
+    class="instrument-entry">
+    <h4 class="instrument-entry__category">{{ categoryName }}</h4>
+    <h3 class="instrument-entry__title">{{ instrument.title }}</h3>
+  </div>
+</template>
+
+<script>
+  import {INTERDISCIPLINARY, LANGUAGE_COMMUNICATION, SOCIETY} from '@/consts/instrument.consts';
+  import instrumentType from '@/helpers/instrumentType';
+
+  export default {
+    props: {
+      instrument: {
+        type: Object,
+        required: true,
+        default: undefined,
+      },
+    },
+
+    computed: {
+      typeClass() {
+        return {
+          'instrument-entry__language-communication': this.instrument.type.category === LANGUAGE_COMMUNICATION,
+          'instrument-entry__society': this.instrument.type.category === SOCIETY,
+          'instrument-entry__interdisciplinary': this.instrument.type.category === INTERDISCIPLINARY,
+        };
+      },
+      categoryName() {
+        return instrumentType(this.instrument);
+      },
+    },
+  };
+</script>
+
+<style scoped lang="scss">
+  @import '~styles/helpers';
+
+  .instrument-entry {
+    padding: $medium-spacing;
+    margin-bottom: $medium-spacing;
+    border-radius: 8px;
+
+    &__title {
+      @include heading-3;
+      margin-bottom: 0;
+    }
+
+    &__category {
+      @include sub-heading;
+      margin-bottom: $small-spacing;
+    }
+
+    $root: &;
+
+    &__language-communication {
+      background-color: $color-accent-2-light;
+
+      #{$root}__category {
+        color: $color-accent-2-dark;
+      }
+    }
+
+    &__society {
+      background-color: $color-accent-1-light;
+
+      #{$root}__category {
+        color: $color-accent-1-dark;
+      }
+
+    }
+
+    &__interdisciplinary {
+      background-color: $color-accent-4-light;
+
+      #{$root}__category {
+        color: $color-accent-4-dark;
+      }
+
+    }
+  }
+
+</style>
diff --git a/client/src/components/instruments/InstrumentFilter.vue b/client/src/components/instruments/InstrumentFilter.vue
index 9e7e356b..514b9c46 100644
--- a/client/src/components/instruments/InstrumentFilter.vue
+++ b/client/src/components/instruments/InstrumentFilter.vue
@@ -2,24 +2,37 @@
   <div class="instrument-filter">
     <filter-group
       title="Alle Instrumente"
-      data-cy="filter-all-instruments"/>
+      data-cy="filter-all-instruments"
+      @click="setFilter(i=>i)"/>
 
     <filter-group
+      :types="languageCommunicationTypes"
       title="Sprache und Kommunikation"
-      data-cy="filter-language-communication"/>
+      data-cy="filter-language-communication"
+      @filter="setFilter($event)"
+      @click="setFilter(i=>i.type.category===LANGUAGE_COMMUNICATION)"
+    />
 
     <filter-group
+      :types="societyTypes"
       title="Gesellschaft"
-      data-cy="filter-society"/>
+      data-cy="filter-society"
+      @filter="setFilter($event)"
+      @click="setFilter(i=>i.type.category===SOCIETY)"/>
 
     <filter-group
+      :types="interdisciplinaryTypes"
       title="Überfachliche Instrumente"
-      data-cy="filter-society"/>
+      data-cy="filter-interdisciplinary"
+      @filter="setFilter($event)"
+      @click="setFilter(i=>i.type.category===INTERDISCIPLINARY)"/>
 
   </div>
 </template>
 
 <script>
+  import {INTERDISCIPLINARY, LANGUAGE_COMMUNICATION, SOCIETY} from '@/consts/instrument.consts';
+
   import Checkbox from '@/components/ui/Checkbox';
   import FilterGroup from '@/components/instruments/FilterGroup';
 
@@ -33,52 +46,36 @@
     },
     data() {
       return {
-        filter: [],
-        types: [
-          {
-            label: 'Sprache und Kommunikation',
-            enabled: true,
-            prop: 'LANGUAGE_COMMUNICATION',
-            cls: 'language',
-          },
-          {
-            label: 'Gesellschaft',
-            enabled: true,
-            prop: 'SOCIETY',
-            cls: 'society',
-          },
-          {
-            label: 'Überfachliches Instrument',
-            enabled: true,
-            prop: 'INTERDISCIPLINARY',
-            cls: 'interdisciplinary',
-          },
-        ],
+        filter: '',
+        LANGUAGE_COMMUNICATION,
+        SOCIETY,
+        INTERDISCIPLINARY,
+        instrumentTypes: [],
       };
     },
 
+    computed: {
+      languageCommunicationTypes() {
+        return this.instrumentTypes.filter(t => t.category === 'LANGUAGE_COMMUNICATION');
+      },
+      societyTypes() {
+        return this.instrumentTypes.filter(t => t.category === 'SOCIETY');
+      },
+      interdisciplinaryTypes() {
+        return this.instrumentTypes.filter(t => t.category === 'INTERDISCIPLINARY');
+      },
+    },
+
+    methods: {
+      setFilter(filter) {
+        this.filter = filter;
+        this.$emit('filter', filter);
+      }
+    },
+
     apollo: {
       instrumentTypes: {
-        query: INSTRUMENT_TYPES_QUERY
-      }
-    },
-
-    methods: {
-      change(enabled, index) {
-        let type = this.types[index];
-        this.types = [
-          ...this.types.slice(0, index),
-          {
-            ...type,
-            enabled,
-          },
-          ...this.types.slice(index + 1),
-        ];
-        this.$emit('filter',
-          this.types
-            .filter(t => t.enabled)
-            .map(t => t.prop),
-        );
+        query: INSTRUMENT_TYPES_QUERY,
       },
     },
   };
diff --git a/client/src/components/profile/InstrumentActivity.vue b/client/src/components/profile/InstrumentActivity.vue
index 2c81fafb..1e2bcef0 100644
--- a/client/src/components/profile/InstrumentActivity.vue
+++ b/client/src/components/profile/InstrumentActivity.vue
@@ -32,6 +32,7 @@
   import ActivityEntry from '@/components/profile/ActivityEntry';
 
   import SCROLL_TO_MUTATION from '@/graphql/gql/local/mutations/scrollTo.gql';
+  import instrumentType from '@/helpers/instrumentType';
 
   export default {
     props: ['instrument', 'filter'],
@@ -52,11 +53,7 @@
         return this.applyFilter('bookmarks') ? this.instrument.bookmarks : [];
       },
       type() {
-        if (this.instrument.type === 'LANGUAGE_COMMUNICATION') {
-          return 'Sprache & Kommunikation';
-        } else {
-          return 'Gesellschaft';
-        }
+        return instrumentType(this.instrument);
       }
     },
     methods: {
diff --git a/client/src/consts/instrument.consts.js b/client/src/consts/instrument.consts.js
new file mode 100644
index 00000000..dfeed83e
--- /dev/null
+++ b/client/src/consts/instrument.consts.js
@@ -0,0 +1,3 @@
+export const LANGUAGE_COMMUNICATION = 'LANGUAGE_COMMUNICATION';
+export const SOCIETY = 'SOCIETY';
+export const INTERDISCIPLINARY = 'INTERDISCIPLINARY';
diff --git a/client/src/graphql/gql/queries/instrumentTypesQuery.gql b/client/src/graphql/gql/queries/instrumentTypesQuery.gql
index 60ea4ad9..78b8b0db 100644
--- a/client/src/graphql/gql/queries/instrumentTypesQuery.gql
+++ b/client/src/graphql/gql/queries/instrumentTypesQuery.gql
@@ -1,6 +1,7 @@
 query InstrumentTypesQuery {
   instrumentTypes {
     name
+    type
     category
   }
 }
diff --git a/client/src/graphql/gql/queries/instrumentsQuery.gql b/client/src/graphql/gql/queries/instrumentsQuery.gql
index bf7c9c49..290846b4 100644
--- a/client/src/graphql/gql/queries/instrumentsQuery.gql
+++ b/client/src/graphql/gql/queries/instrumentsQuery.gql
@@ -4,7 +4,11 @@ query InstrumentsQuery {
     title
     contents
     slug
-    type
-    category
+    type {
+      id
+      type
+      category
+      name
+    }
   }
 }
diff --git a/client/src/helpers/instrumentType.js b/client/src/helpers/instrumentType.js
new file mode 100644
index 00000000..68f2d6d9
--- /dev/null
+++ b/client/src/helpers/instrumentType.js
@@ -0,0 +1,13 @@
+import {LANGUAGE_COMMUNICATION, SOCIETY} from '@/consts/instrument.consts';
+
+const instrumentType = ({type: {category}}) => {
+ if (category === LANGUAGE_COMMUNICATION) {
+   return 'Sprache & Kommunikation';
+ } else if (category === SOCIETY) {
+   return 'Gesellschaft';
+ } else {
+   return 'Überfachliches Instrument';
+ }
+};
+
+export default instrumentType;
diff --git a/client/src/pages/instrumentOverview.vue b/client/src/pages/instrumentOverview.vue
index 228530f3..b92efc2f 100644
--- a/client/src/pages/instrumentOverview.vue
+++ b/client/src/pages/instrumentOverview.vue
@@ -7,10 +7,10 @@
       <router-link
         :to="{name: 'instrument', params: {slug: instrument.slug}}"
         :key="instrument.id"
-        class="instrument-overview__list-item"
+        data-cy="instrument"
         tag="div"
         v-for="instrument in filteredInstruments">
-        {{ instrument.title }}
+        <instrument-entry :instrument="instrument"/>
       </router-link>
     </div>
   </div>
@@ -18,11 +18,13 @@
 
 <script>
   import InstrumentFilter from '@/components/instruments/InstrumentFilter';
+  import InstrumentEntry from '@/components/instruments/InstrumentEntry';
   import INSTRUMENTS_QUERY from '@/graphql/gql/queries/instrumentsQuery.gql';
 
   export default {
     components: {
-      InstrumentFilter
+      InstrumentFilter,
+      InstrumentEntry
     },
 
     apollo: {
@@ -37,13 +39,13 @@
     data() {
       return {
         instruments: [],
-        filter: []
+        filter: i => i
       };
     },
 
     computed: {
       filteredInstruments() {
-        return this.instruments.filter(instrument => this.filter.includes(instrument.type) || !this.filter.length);
+        return this.instruments.filter(i => this.filter(i));
       }
     },
 
diff --git a/client/src/styles/mixins/_typography.scss b/client/src/styles/mixins/_typography.scss
index 82fb3d10..f6d6c687 100644
--- a/client/src/styles/mixins/_typography.scss
+++ b/client/src/styles/mixins/_typography.scss
@@ -28,6 +28,12 @@
   font-size: toRem(18px);
 }
 
+@mixin sub-heading {
+  font-family: $sans-serif-font-family;
+  font-weight: 400;
+  font-size: toRem(16px);
+}
+
 @mixin modal-heading {
   @include heading-2;
   margin-bottom: 0;

From e1a87739df226f0627e08abfdea2e3d9039dcfa6 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Sun, 31 Oct 2021 22:02:30 +0100
Subject: [PATCH 15/20] Add some styling for filter group headers

---
 .../components/instruments/FilterEntry.vue    | 44 ++++++++++++++++---
 .../components/instruments/FilterGroup.vue    |  7 ++-
 .../instruments/InstrumentFilter.vue          | 25 ++---------
 client/src/pages/instrumentOverview.vue       |  3 ++
 4 files changed, 51 insertions(+), 28 deletions(-)

diff --git a/client/src/components/instruments/FilterEntry.vue b/client/src/components/instruments/FilterEntry.vue
index 1b058eaf..285fb13e 100644
--- a/client/src/components/instruments/FilterEntry.vue
+++ b/client/src/components/instruments/FilterEntry.vue
@@ -1,22 +1,41 @@
 <template>
-  <a class="filter-entry">
-    <span class="filter-entry__text">{{ text }}</span><chevron-right class="filter-entry__icon" />
+  <a
+    :class="typeClass"
+    class="filter-entry">
+    <span class="filter-entry__text">{{ text }}</span>
+    <chevron-right class="filter-entry__icon"/>
   </a>
 </template>
 
 <script>
   import ChevronRight from '@/components/icons/ChevronRight';
+  import {INTERDISCIPLINARY, LANGUAGE_COMMUNICATION, SOCIETY} from '@/consts/instrument.consts';
+
   export default {
     props: {
       text: {
         type: String,
-        required: true
-      }
+        required: true,
+      },
+      type: {
+        type: String,
+        default: '',
+      },
     },
 
     components: {
-      ChevronRight
-    }
+      ChevronRight,
+    },
+
+    computed: {
+      typeClass() {
+        return {
+          'filter-entry--language-communication': this.type === LANGUAGE_COMMUNICATION,
+          'filter-entry--society': this.type === SOCIETY,
+          'filter-entry--interdisciplinary': this.type === INTERDISCIPLINARY,
+        };
+      },
+    },
   };
 </script>
 
@@ -31,11 +50,24 @@
     &__text {
       @include sub-heading;
       line-height: 1.5;
+      color: inherit;
     }
 
     &__icon {
       width: 10px;
       height: 10px;
     }
+
+    &--language-communication {
+      color: $color-accent-2-dark;
+    }
+
+    &--society {
+      color: $color-accent-1-dark;
+    }
+
+    &--interdisciplinary {
+      color: $color-accent-4-dark;
+    }
   }
 </style>
diff --git a/client/src/components/instruments/FilterGroup.vue b/client/src/components/instruments/FilterGroup.vue
index a4ff330e..7250b051 100644
--- a/client/src/components/instruments/FilterGroup.vue
+++ b/client/src/components/instruments/FilterGroup.vue
@@ -3,6 +3,7 @@
     <filter-entry
       :text="title"
       v-bind="$attrs"
+      :type="type"
       @click.native="$emit('click')"/>
     <div class="filter-group__children">
 
@@ -30,6 +31,10 @@
         type: Array,
         default: () => [],
       },
+      type: {
+        type: String,
+        default: ''
+      }
     },
     components: {FilterEntry, ChevronRight},
     inheritAttrs: false,
@@ -40,7 +45,7 @@
   @import '~styles/helpers';
 
   .filter-group {
-    border-bottom: 1px solid black;
+    border-bottom: 1px solid $color-silver;
     display: flex;
     flex-direction: column;
 
diff --git a/client/src/components/instruments/InstrumentFilter.vue b/client/src/components/instruments/InstrumentFilter.vue
index 514b9c46..49e346e6 100644
--- a/client/src/components/instruments/InstrumentFilter.vue
+++ b/client/src/components/instruments/InstrumentFilter.vue
@@ -7,14 +7,17 @@
 
     <filter-group
       :types="languageCommunicationTypes"
+      :type="LANGUAGE_COMMUNICATION"
       title="Sprache und Kommunikation"
       data-cy="filter-language-communication"
+      class="instrument-filter__group--language"
       @filter="setFilter($event)"
       @click="setFilter(i=>i.type.category===LANGUAGE_COMMUNICATION)"
     />
 
     <filter-group
       :types="societyTypes"
+      :type="SOCIETY"
       title="Gesellschaft"
       data-cy="filter-society"
       @filter="setFilter($event)"
@@ -22,6 +25,7 @@
 
     <filter-group
       :types="interdisciplinaryTypes"
+      :type="INTERDISCIPLINARY"
       title="Überfachliche Instrumente"
       data-cy="filter-interdisciplinary"
       @filter="setFilter($event)"
@@ -87,26 +91,5 @@
   .instrument-filter {
     display: flex;
     flex-direction: column;
-    //align-content: center;
-
-    &__checkbox {
-      &--language {
-        /deep/ input:checked + .checkbox {
-          background-color: $color-accent-1-dark;
-        }
-      }
-
-      &--society {
-        /deep/ input:checked + .checkbox {
-          background-color: $color-accent-2-dark;
-        }
-      }
-
-      &--interdisciplinary {
-        /deep/ input:checked + .checkbox {
-          background-color: $color-accent-4-dark;
-        }
-      }
-    }
   }
 </style>
diff --git a/client/src/pages/instrumentOverview.vue b/client/src/pages/instrumentOverview.vue
index b92efc2f..cd4928ed 100644
--- a/client/src/pages/instrumentOverview.vue
+++ b/client/src/pages/instrumentOverview.vue
@@ -64,7 +64,9 @@
     display: grid;
     //grid-template-rows: auto auto 1fr;
     grid-template-columns: 300px auto;
+    grid-column-gap: $small-spacing;
     //@include centered(800px);
+    padding: 0 $small-spacing;
 
     &__filter {
 
@@ -76,6 +78,7 @@
       width: 100%;
       display: flex;
       flex-direction: column;
+      justify-self: center;
     }
 
     &__list-item {

From 812021cb54ebbf7acb70c9438d7d4d82696442bb Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Sun, 31 Oct 2021 22:12:57 +0100
Subject: [PATCH 16/20] Fix unit tests

---
 server/books/factories.py | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/server/books/factories.py b/server/books/factories.py
index 2eb8b4c5..4e90311c 100644
--- a/server/books/factories.py
+++ b/server/books/factories.py
@@ -9,10 +9,10 @@ from wagtail.core.models import Page, Site
 from wagtail.core.rich_text import RichText
 
 from assignments.models import Assignment
-from basicknowledge.models import BasicKnowledge
-from books.blocks import BasicKnowledgeBlock, ImageUrlBlock, LinkBlock, AssignmentBlock, VideoBlock
-from books.models import Book, Topic, Module, Chapter, ContentBlock, TextBlock
-from core.factories import BasePageFactory, fake, DummyImageFactory, fake_paragraph, fake_title
+from basicknowledge.models import BasicKnowledge, INTERDISCIPLINARY, InstrumentType, LANGUAGE_COMMUNICATION, SOCIETY
+from books.blocks import AssignmentBlock, BasicKnowledgeBlock, ImageUrlBlock, LinkBlock, VideoBlock
+from books.models import Book, Chapter, ContentBlock, Module, TextBlock, Topic
+from core.factories import BasePageFactory, DummyImageFactory, fake, fake_paragraph, fake_title
 
 
 class BookFactory(BasePageFactory):
@@ -70,9 +70,18 @@ class TextBlockFactory(wagtail_factories.StructBlockFactory):
         model = TextBlock
 
 
+class InstrumentTypeFactory(factory.DjangoModelFactory):
+    class Meta:
+        model = InstrumentType
+
+    category = factory.Iterator([LANGUAGE_COMMUNICATION, SOCIETY, INTERDISCIPLINARY])
+    name = factory.LazyAttribute(lambda x: fake.text(max_nb_chars=20))
+
+
 class InstrumentFactory(BasePageFactory):
     title = factory.LazyAttribute(fake_title)
-    type = factory.Iterator([BasicKnowledge.LANGUAGE_COMMUNICATION, BasicKnowledge.SOCIETY, BasicKnowledge.INTERDISCIPLINARY])
+    old_type = factory.Iterator([LANGUAGE_COMMUNICATION, SOCIETY, INTERDISCIPLINARY])
+    new_type = factory.SubFactory(InstrumentTypeFactory)
 
     class Meta:
         model = BasicKnowledge
@@ -83,7 +92,6 @@ class InstrumentFactory(BasePageFactory):
         return super()._create(model_class, *args, **kwargs)
 
 
-
 class BasicKnowledgeBlockFactory(wagtail_factories.StructBlockFactory):
     description = factory.LazyAttribute(fake_paragraph)
     basic_knowledge = factory.SubFactory(InstrumentFactory)

From 3e8238929989b199d56a28950c731af123f5de1f Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Mon, 1 Nov 2021 11:57:07 +0100
Subject: [PATCH 17/20] Refactor current instrument filter query, add styling
 for active state

---
 .../components/instruments/FilterEntry.vue    | 93 +++++++++++++++++--
 .../components/instruments/FilterGroup.vue    | 57 ++++++++++--
 .../instruments/InstrumentFilter.vue          | 17 ++--
 client/src/graphql/client.js                  |  4 +
 .../src/graphql/gql/local/instrumentFiler.gql |  5 +
 .../local/mutations/setInstrumentFilter.gql   |  3 +
 client/src/graphql/resolvers.js               | 11 ++-
 client/src/graphql/typedefs.js                |  4 +
 client/src/pages/instrumentOverview.vue       | 30 ++++--
 9 files changed, 191 insertions(+), 33 deletions(-)
 create mode 100644 client/src/graphql/gql/local/instrumentFiler.gql
 create mode 100644 client/src/graphql/gql/local/mutations/setInstrumentFilter.gql

diff --git a/client/src/components/instruments/FilterEntry.vue b/client/src/components/instruments/FilterEntry.vue
index 285fb13e..9b6cbc6f 100644
--- a/client/src/components/instruments/FilterEntry.vue
+++ b/client/src/components/instruments/FilterEntry.vue
@@ -3,13 +3,17 @@
     :class="typeClass"
     class="filter-entry">
     <span class="filter-entry__text">{{ text }}</span>
-    <chevron-right class="filter-entry__icon"/>
+    <span class="filter-entry__icon-wrapper">
+      <chevron-right class="filter-entry__icon"/>
+    </span>
+
   </a>
 </template>
 
 <script>
   import ChevronRight from '@/components/icons/ChevronRight';
   import {INTERDISCIPLINARY, LANGUAGE_COMMUNICATION, SOCIETY} from '@/consts/instrument.consts';
+  import INSTRUMENT_FILTER_QUERY from 'gql/local/instrumentFiler.gql';
 
   export default {
     props: {
@@ -21,18 +25,51 @@
         type: String,
         default: '',
       },
+      isCategory: {
+        type: Boolean,
+        default: false,
+      },
+      category: {
+        type: String,
+        default: '',
+      },
     },
 
     components: {
       ChevronRight,
     },
 
+    apollo: {
+      instrumentFilter: {
+        query: INSTRUMENT_FILTER_QUERY
+      }
+    },
+
+    data() {
+      return {
+        instrumentFilter: {
+          currentFilter: '',
+        },
+      };
+    },
+
     computed: {
+      isActive() {
+        console.log(this.instrumentFilter.currentFilter);
+        if (!this.instrumentFilter.currentFilter) {
+          return this.type === '';
+        }
+        const [_, identifier] = this.instrumentFilter.currentFilter.split(':');
+        console.log(identifier, this.type);
+        return this.type === identifier;
+      },
       typeClass() {
         return {
-          'filter-entry--language-communication': this.type === LANGUAGE_COMMUNICATION,
-          'filter-entry--society': this.type === SOCIETY,
-          'filter-entry--interdisciplinary': this.type === INTERDISCIPLINARY,
+          'filter-entry--language-communication': this.category === LANGUAGE_COMMUNICATION,
+          'filter-entry--society': this.category === SOCIETY,
+          'filter-entry--interdisciplinary': this.category === INTERDISCIPLINARY,
+          'filter-entry--active': this.isActive,
+          'filter-entry--category': this.isCategory,
         };
       },
     },
@@ -46,6 +83,7 @@
     display: flex;
     justify-content: space-between;
     align-items: center;
+    cursor: pointer;
 
     &__text {
       @include sub-heading;
@@ -53,21 +91,62 @@
       color: inherit;
     }
 
+    &__icon-wrapper {
+      display: flex;
+      align-items: center;
+      justify-content: center;
+      height: 20px;
+      width: 20px;
+      border-radius: 10px;
+    }
+
     &__icon {
       width: 10px;
       height: 10px;
     }
 
+    $root: &;
+
+    @mixin filter-block($color) {
+      &#{$root}--category {
+        color: $color;
+      }
+
+      &#{$root}--active {
+        #{$root}__icon-wrapper {
+          background-color: $color;
+        }
+      }
+
+      #{$root}__icon {
+        fill: $color;
+      }
+    }
+
     &--language-communication {
-      color: $color-accent-2-dark;
+      @include filter-block($color-accent-2-dark);
     }
 
     &--society {
-      color: $color-accent-1-dark;
+      @include filter-block($color-accent-1-dark);
     }
 
     &--interdisciplinary {
-      color: $color-accent-4-dark;
+      @include filter-block($color-accent-4-dark);
+    }
+
+    &--active {
+      #{$root}__text {
+        font-weight: 600;
+      }
+
+      #{$root}__icon-wrapper {
+        background-color: black;
+      }
+
+      #{$root}__icon {
+        fill: white;
+      }
     }
   }
 </style>
diff --git a/client/src/components/instruments/FilterGroup.vue b/client/src/components/instruments/FilterGroup.vue
index 7250b051..ebd5ab7a 100644
--- a/client/src/components/instruments/FilterGroup.vue
+++ b/client/src/components/instruments/FilterGroup.vue
@@ -3,16 +3,20 @@
     <filter-entry
       :text="title"
       v-bind="$attrs"
-      :type="type"
-      @click.native="$emit('click')"/>
+      :type="category"
+      :category="category"
+      :is-category="true"
+      @click.native="setCategoryFilter(category)"/>
     <div class="filter-group__children">
-
       <filter-entry
         :key="type.id"
         :data-cy="`filter-${type.type}`"
+        :category="type.category"
         :text="type.name"
+        :type="type.type"
         v-for="type in types"
-        @click.native="$emit('filter', i=>i.type.type===type.type)" />
+        @click.native="setFilter(`type:${type.type}`)"
+      />
     </div>
   </div>
 </template>
@@ -21,6 +25,9 @@
   import ChevronRight from '@/components/icons/ChevronRight';
   import FilterEntry from '@/components/instruments/FilterEntry';
 
+  import SET_FILTER_MUTATION from 'gql/local/mutations/setInstrumentFilter.gql';
+  import INSTRUMENT_FILTER_QUERY from 'gql/local/instrumentFiler.gql';
+
   export default {
     props: {
       title: {
@@ -31,13 +38,48 @@
         type: Array,
         default: () => [],
       },
-      type: {
+      category: {
         type: String,
-        default: ''
+        default: '',
+      },
+    },
+    components: {
+      FilterEntry,
+      ChevronRight,
+    },
+
+    apollo: {
+      instrumentFilter: {
+        query: INSTRUMENT_FILTER_QUERY
       }
     },
-    components: {FilterEntry, ChevronRight},
+
+    data() {
+      return {
+        instrumentFilter: {
+          currentFilter: ''
+        }
+      };
+  },
     inheritAttrs: false,
+
+    methods: {
+      setCategoryFilter(category) {
+        if (category) {
+          this.setFilter(`category:${category}`);
+        } else {
+          this.setFilter(``);
+        }
+      },
+      setFilter(filter) {
+        this.$apollo.mutate({
+          mutation: SET_FILTER_MUTATION,
+          variables: {
+            filter
+          }
+        });
+      }
+    },
   };
 </script>
 
@@ -46,6 +88,7 @@
 
   .filter-group {
     border-bottom: 1px solid $color-silver;
+    padding: $medium-spacing 0;
     display: flex;
     flex-direction: column;
 
diff --git a/client/src/components/instruments/InstrumentFilter.vue b/client/src/components/instruments/InstrumentFilter.vue
index 49e346e6..c7381d28 100644
--- a/client/src/components/instruments/InstrumentFilter.vue
+++ b/client/src/components/instruments/InstrumentFilter.vue
@@ -3,33 +3,28 @@
     <filter-group
       title="Alle Instrumente"
       data-cy="filter-all-instruments"
-      @click="setFilter(i=>i)"/>
+    />
 
     <filter-group
       :types="languageCommunicationTypes"
-      :type="LANGUAGE_COMMUNICATION"
+      :category="LANGUAGE_COMMUNICATION"
       title="Sprache und Kommunikation"
       data-cy="filter-language-communication"
       class="instrument-filter__group--language"
-      @filter="setFilter($event)"
-      @click="setFilter(i=>i.type.category===LANGUAGE_COMMUNICATION)"
     />
 
     <filter-group
       :types="societyTypes"
-      :type="SOCIETY"
+      :category="SOCIETY"
       title="Gesellschaft"
       data-cy="filter-society"
-      @filter="setFilter($event)"
-      @click="setFilter(i=>i.type.category===SOCIETY)"/>
+    />
 
     <filter-group
-      :types="interdisciplinaryTypes"
-      :type="INTERDISCIPLINARY"
+      :category="INTERDISCIPLINARY"
       title="Überfachliche Instrumente"
       data-cy="filter-interdisciplinary"
-      @filter="setFilter($event)"
-      @click="setFilter(i=>i.type.category===INTERDISCIPLINARY)"/>
+    />
 
   </div>
 </template>
diff --git a/client/src/graphql/client.js b/client/src/graphql/client.js
index 2bfabfc8..ede1035c 100644
--- a/client/src/graphql/client.js
+++ b/client/src/graphql/client.js
@@ -24,6 +24,10 @@ const writeLocalCache = cache => {
         __typename: 'HelloEmail',
         email: '',
       },
+      instrumentFilter: {
+        __typename: 'InstrumentFilter',
+        currentFilter: 'abc'
+      }
     },
   });
 };
diff --git a/client/src/graphql/gql/local/instrumentFiler.gql b/client/src/graphql/gql/local/instrumentFiler.gql
new file mode 100644
index 00000000..fe00a4be
--- /dev/null
+++ b/client/src/graphql/gql/local/instrumentFiler.gql
@@ -0,0 +1,5 @@
+query InstrumentFilter {
+  instrumentFilter @client {
+    currentFilter
+  }
+}
diff --git a/client/src/graphql/gql/local/mutations/setInstrumentFilter.gql b/client/src/graphql/gql/local/mutations/setInstrumentFilter.gql
new file mode 100644
index 00000000..bfc35931
--- /dev/null
+++ b/client/src/graphql/gql/local/mutations/setInstrumentFilter.gql
@@ -0,0 +1,3 @@
+mutation($filter: String!) {
+  setInstrumentFilter(filter: $filter) @client
+}
diff --git a/client/src/graphql/resolvers.js b/client/src/graphql/resolvers.js
index 2dd4abeb..2d0c2620 100644
--- a/client/src/graphql/resolvers.js
+++ b/client/src/graphql/resolvers.js
@@ -1,6 +1,7 @@
 import SCROLL_POSITION from '@/graphql/gql/local/scrollPosition.gql';
 import HELLO_EMAIL from '@/graphql/gql/local/helloEmail.gql';
 import SIDEBAR from '@/graphql/gql/local/sidebar.gql';
+import INSTRUMENT_FILTER from '@/graphql/gql/local/instrumentFiler.gql';
 
 export const resolvers = {
   Mutation: {
@@ -16,6 +17,12 @@ export const resolvers = {
       cache.writeQuery({query: HELLO_EMAIL, data});
       return data.helloEmail;
     },
+    setInstrumentFilter: (_, {filter}, {cache}) => {
+      const data = cache.readQuery({query: INSTRUMENT_FILTER});
+      data.instrumentFilter.currentFilter = filter;
+      cache.writeQuery({query: INSTRUMENT_FILTER, data});
+      return data.instrumentFilter;
+    },
     toggleSidebar: (_, {sidebar: {profile, navigation}}, {cache}) => {
       const data = cache.readQuery({query: SIDEBAR});
       if (typeof profile !== 'undefined') {
@@ -26,6 +33,6 @@ export const resolvers = {
       }
       cache.writeQuery({query: SIDEBAR, data});
       return data.sidebar;
-    }
-  }
+    },
+  },
 };
diff --git a/client/src/graphql/typedefs.js b/client/src/graphql/typedefs.js
index ecad752c..9528fc5e 100644
--- a/client/src/graphql/typedefs.js
+++ b/client/src/graphql/typedefs.js
@@ -19,6 +19,10 @@ export const typeDefs = gql`
     profile: Boolean
   }
 
+  type InstrumentFilter {
+    currentFilter: String!
+  }
+
   type Mutation {
     scrollTo(scrollTo: String!): ScrollPosition
     helloEmail(email: String!): HelloEmail
diff --git a/client/src/pages/instrumentOverview.vue b/client/src/pages/instrumentOverview.vue
index cd4928ed..a339e23b 100644
--- a/client/src/pages/instrumentOverview.vue
+++ b/client/src/pages/instrumentOverview.vue
@@ -21,10 +21,12 @@
   import InstrumentEntry from '@/components/instruments/InstrumentEntry';
   import INSTRUMENTS_QUERY from '@/graphql/gql/queries/instrumentsQuery.gql';
 
+  import INSTRUMENT_FILTER_QUERY from 'gql/local/instrumentFiler.gql';
+
   export default {
     components: {
       InstrumentFilter,
-      InstrumentEntry
+      InstrumentEntry,
     },
 
     apollo: {
@@ -32,27 +34,43 @@
         query: INSTRUMENTS_QUERY,
         update(data) {
           return this.$getRidOfEdges(data).instruments;
-        }
-      }
+        },
+      },
+      instrumentFilter: {
+        query: INSTRUMENT_FILTER_QUERY,
+        update({instrumentFilter}) {
+          const {currentFilter} = instrumentFilter;
+          if (currentFilter && currentFilter.indexOf(':') > -1) {
+            const [filterType, identifier] = currentFilter.split(':');
+            this.filter = i => i.type[filterType] === identifier;
+          } else {
+            this.filter = i => i; // identity
+          }
+          return instrumentFilter;
+        },
+      },
     },
 
     data() {
       return {
         instruments: [],
-        filter: i => i
+        filter: i => i, // identity
+        instrumentFilter: {
+          currentFilter: '',
+        },
       };
     },
 
     computed: {
       filteredInstruments() {
         return this.instruments.filter(i => this.filter(i));
-      }
+      },
     },
 
     methods: {
       updateFilter(filter) {
         this.filter = filter;
-      }
+      },
     },
   };
 </script>

From 885d9d4f8828fd3725f7009126baebc61e0c4331 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Mon, 1 Nov 2021 11:57:42 +0100
Subject: [PATCH 18/20] Add migration for new instrument type population

---
 .../migrations/0012_auto_20211101_1008.py     | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 server/basicknowledge/migrations/0012_auto_20211101_1008.py

diff --git a/server/basicknowledge/migrations/0012_auto_20211101_1008.py b/server/basicknowledge/migrations/0012_auto_20211101_1008.py
new file mode 100644
index 00000000..929e4e92
--- /dev/null
+++ b/server/basicknowledge/migrations/0012_auto_20211101_1008.py
@@ -0,0 +1,37 @@
+# Generated by Django 2.2.24 on 2021-11-01 10:08
+
+from django.db import migrations
+
+from basicknowledge.models import LANGUAGE_COMMUNICATION, SOCIETY
+from core.logger import get_logger
+
+logger = get_logger(__name__)
+
+
+def create_new_types(apps, schema_editor):
+    InstrumentType = apps.get_model('basicknowledge', 'InstrumentType')
+    language_communication_types = [
+        'Analyse', 'Argumentation', 'Beschreibung', 'Grafiken', 'Interview',
+        'Kommunikation', 'Korrespondenz', 'Orthografie', 'Präsentation',
+        'Struktur', 'Umfrage', 'Zusammenfassung'
+    ]
+    society_types = [
+        'Ethik', 'Identität und Sozialisation', 'Kultur', 'Ökologie',
+        'Politik', 'Recht', 'Technologie', 'Wirtschaft'
+    ]
+
+    for type_name in language_communication_types:
+        obj, created = InstrumentType.objects.get_or_create(name=type_name, category=LANGUAGE_COMMUNICATION)
+
+    for type_name in society_types:
+        obj, created = InstrumentType.objects.get_or_create(name=type_name, category=SOCIETY)
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ('basicknowledge', '0011_auto_20211031_1144'),
+    ]
+
+    operations = [
+        migrations.RunPython(create_new_types, migrations.RunPython.noop)
+    ]

From dc5d9224695b92fef272cf6567bfe23ad99ed0f0 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Mon, 1 Nov 2021 12:05:59 +0100
Subject: [PATCH 19/20] Fix es-lint issue and remove console log

---
 client/src/components/instruments/FilterEntry.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/src/components/instruments/FilterEntry.vue b/client/src/components/instruments/FilterEntry.vue
index 9b6cbc6f..8f0a56e6 100644
--- a/client/src/components/instruments/FilterEntry.vue
+++ b/client/src/components/instruments/FilterEntry.vue
@@ -55,10 +55,10 @@
 
     computed: {
       isActive() {
-        console.log(this.instrumentFilter.currentFilter);
         if (!this.instrumentFilter.currentFilter) {
           return this.type === '';
         }
+        // eslint-disable-next-line
         const [_, identifier] = this.instrumentFilter.currentFilter.split(':');
         console.log(identifier, this.type);
         return this.type === identifier;

From f03beb8b347e7560687d0a0f16b5998c1d022c6e Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Wed, 10 Nov 2021 12:47:52 +0100
Subject: [PATCH 20/20] Return only instrument types with assigned instruments

---
 .../migrations/0012_auto_20211101_1008.py     |  2 +-
 .../migrations/0013_auto_20211110_1140.py     | 19 +++++++++++++
 server/basicknowledge/models.py               |  2 +-
 server/basicknowledge/queries.py              |  2 +-
 server/basicknowledge/tests/__init__.py       |  0
 .../tests/test_instrument_types_query.py      | 27 +++++++++++++++++++
 server/core/tests/base_test.py                |  2 +-
 7 files changed, 50 insertions(+), 4 deletions(-)
 create mode 100644 server/basicknowledge/migrations/0013_auto_20211110_1140.py
 create mode 100644 server/basicknowledge/tests/__init__.py
 create mode 100644 server/basicknowledge/tests/test_instrument_types_query.py

diff --git a/server/basicknowledge/migrations/0012_auto_20211101_1008.py b/server/basicknowledge/migrations/0012_auto_20211101_1008.py
index 929e4e92..89096978 100644
--- a/server/basicknowledge/migrations/0012_auto_20211101_1008.py
+++ b/server/basicknowledge/migrations/0012_auto_20211101_1008.py
@@ -13,7 +13,7 @@ def create_new_types(apps, schema_editor):
     language_communication_types = [
         'Analyse', 'Argumentation', 'Beschreibung', 'Grafiken', 'Interview',
         'Kommunikation', 'Korrespondenz', 'Orthografie', 'Präsentation',
-        'Struktur', 'Umfrage', 'Zusammenfassung'
+        'Struktur', 'Umfrage', 'Zusammenfassung', 'Blog'
     ]
     society_types = [
         'Ethik', 'Identität und Sozialisation', 'Kultur', 'Ökologie',
diff --git a/server/basicknowledge/migrations/0013_auto_20211110_1140.py b/server/basicknowledge/migrations/0013_auto_20211110_1140.py
new file mode 100644
index 00000000..1918a76c
--- /dev/null
+++ b/server/basicknowledge/migrations/0013_auto_20211110_1140.py
@@ -0,0 +1,19 @@
+# Generated by Django 2.2.24 on 2021-11-10 11:40
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('basicknowledge', '0012_auto_20211101_1008'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='basicknowledge',
+            name='new_type',
+            field=models.ForeignKey(null=True, on_delete=django.db.models.deletion.PROTECT, related_name='instruments', to='basicknowledge.InstrumentType'),
+        ),
+    ]
diff --git a/server/basicknowledge/models.py b/server/basicknowledge/models.py
index 3c987493..5b5ae791 100644
--- a/server/basicknowledge/models.py
+++ b/server/basicknowledge/models.py
@@ -53,7 +53,7 @@ class BasicKnowledge(StrictHierarchyPage):
         ('subtitle', SubtitleBlock()),
     ], null=True, blank=True)
 
-    new_type = models.ForeignKey(InstrumentType, null=True, on_delete=models.PROTECT)
+    new_type = models.ForeignKey(InstrumentType, null=True, on_delete=models.PROTECT, related_name='instruments')
 
     old_type = models.CharField(
         max_length=100,
diff --git a/server/basicknowledge/queries.py b/server/basicknowledge/queries.py
index 0b27f10b..8304d3e0 100644
--- a/server/basicknowledge/queries.py
+++ b/server/basicknowledge/queries.py
@@ -64,4 +64,4 @@ class InstrumentQuery(object):
         return BasicKnowledge.objects.all().live()
 
     def resolve_instrument_types(self, info, **kwargs):
-        return InstrumentType.objects.all()
+        return InstrumentType.objects.filter(instruments__isnull=False)
diff --git a/server/basicknowledge/tests/__init__.py b/server/basicknowledge/tests/__init__.py
new file mode 100644
index 00000000..e69de29b
diff --git a/server/basicknowledge/tests/test_instrument_types_query.py b/server/basicknowledge/tests/test_instrument_types_query.py
new file mode 100644
index 00000000..d90b3f4e
--- /dev/null
+++ b/server/basicknowledge/tests/test_instrument_types_query.py
@@ -0,0 +1,27 @@
+from books.factories import InstrumentFactory, InstrumentTypeFactory
+from core.tests.base_test import SkillboxTestCase
+
+INSTRUMENT_TYPES_QUERY = """
+query InstrumentTypesQuery {
+  instrumentTypes {
+    name
+    type
+    category
+  }
+}
+"""
+
+
+class InstrumentTypesQueryTestCase(SkillboxTestCase):
+    def setUp(self) -> None:
+        self.createDefault()
+        self.type = InstrumentTypeFactory(name='Type O Negative')
+        second_type = InstrumentTypeFactory(name='Typecast')
+        InstrumentTypeFactory(name='Guitar')
+        self.instrument = InstrumentFactory(new_type=self.type)
+        InstrumentFactory(new_type=second_type)
+
+    def test_instrument_types_empty_not_returned(self):
+        result = self.get_client().get_result(INSTRUMENT_TYPES_QUERY)
+        self.assertIsNone(result.errors)
+        self.assertEqual(len(result.data['instrumentTypes']), 2)
diff --git a/server/core/tests/base_test.py b/server/core/tests/base_test.py
index 63468630..2532be57 100644
--- a/server/core/tests/base_test.py
+++ b/server/core/tests/base_test.py
@@ -23,7 +23,7 @@ class SkillboxTestCase(TestCase):
 
         self.school_class = SchoolClass.objects.get(name='skillbox')
 
-    def get_client(self, user=None) -> Client:
+    def get_client(self, user=None) -> GQLClient:
         request = RequestFactory().get('/')
         if user is None:
             user = self.teacher