ramon
/
skillbox
1
0
Fork 0
Code Issues 1 Pull Requests 1 Packages Projects 1 Releases 1 Wiki Activity

Refactored from method to computed

This commit is contained in:
Daniel Egger 2018-10-05 14:44:47 +02:00
parent 1d29cc51ec
commit 9efd000aa1
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
client/src/components/ContentBlock.vue
View File

@ -1,7 +1,7 @@
<template> <template>
<div class="content-block__container"> <div class="content-block__container">
<div class="content-block" :class="specialClass"> <div class="content-block" :class="specialClass">
<div v-if="canChangeContentBlock()" class="content-block__actions"> <div v-if="canChangeContentBlock" class="content-block__actions">
<a @click="toggleVisibility()" class="content-block__visibility-button"> <a @click="toggleVisibility()" class="content-block__visibility-button">
<eye-icon class="content-block__action-icon"></eye-icon> <eye-icon class="content-block__action-icon"></eye-icon>
</a> </a>
@ -25,7 +25,7 @@
</div> </div>
<add-content-block-button v-if="canChangeContentBlock()" :after="contentBlock.id"></add-content-block-button> <add-content-block-button v-if="canChangeContentBlock" :after="contentBlock.id"></add-content-block-button>
</div> </div>
@ -69,6 +69,9 @@
computed: { computed: {
specialClass() { specialClass() {
return `content-block--${this.contentBlock.type.toLowerCase()}` return `content-block--${this.contentBlock.type.toLowerCase()}`
},
canChangeContentBlock() {
return this.me.permissions.includes('user.can_edit_modules');
} }
}, },
@ -79,9 +82,6 @@
editContentBlock() { editContentBlock() {
this.$store.dispatch('editContentBlock', this.contentBlock.id); this.$store.dispatch('editContentBlock', this.contentBlock.id);
}, },
canChangeContentBlock() {
return this.me.permissions.includes('user.can_edit_modules');
}
}, },
apollo: { apollo: {

5
server/rooms/mutations.py
View File

@ -15,10 +15,9 @@ class MutateRoom(relay.ClientIDMutation):
@classmethod @classmethod
def mutate_and_get_payload(cls, *args, **kwargs): def mutate_and_get_payload(cls, *args, **kwargs):
# FIXME
room_data = kwargs.get('room') room_data = kwargs.get('room')
user_group = get_object(SchoolClass, room_data.get('user_group').get('id')) school_class = get_object(SchoolClass, room_data.get('school_class').get('id'))
room_data['user_group'] = user_group.id room_data['school_class'] = school_class.id
if room_data.get('id') is not None: if room_data.get('id') is not None:
room = get_object(Room, room_data['id']) room = get_object(Room, room_data['id'])
serializer = RoomSerializer(room, data=room_data) serializer = RoomSerializer(room, data=room_data)