From a3fe315df3ab5b3f9154434d12dd154dd98c55c8 Mon Sep 17 00:00:00 2001 From: Christian Cueni Date: Wed, 10 Nov 2021 10:51:55 +0100 Subject: [PATCH] Refactor mutations --- server/rooms/mutations.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/server/rooms/mutations.py b/server/rooms/mutations.py index 6c4f9d37..fa25f783 100644 --- a/server/rooms/mutations.py +++ b/server/rooms/mutations.py @@ -39,7 +39,7 @@ class AddRoom(MutateRoom): @classmethod def mutate_and_get_payload(cls, root, info, **kwargs): user = info.context.user - if not user.has_perm('users.can_manage_school_class_content'): + if not user.is_teacher(): return cls(room=None, errors=['not allowed']) room_data = kwargs.get('room') @@ -92,9 +92,9 @@ class MutateRoomEntry(relay.ClientIDMutation): room_entry_data['room'] = room.id if room_entry_data.get('id') is not None: - serializer = cls.update_path(info, room_entry_data) + serializer = cls.update_room_entry(info, room_entry_data) else: - serializer = cls.add_path(info, room_entry_data, room) + serializer = cls.add_room_entry(info, room_entry_data, room) if serializer.is_valid(): serializer.save() @@ -104,7 +104,7 @@ class MutateRoomEntry(relay.ClientIDMutation): return cls(room_entry=None, errors=['{}: {}'.format(key, value) for key, value in serializer.errors.items()]) @classmethod - def update_path(cls, info, room_entry_data): + def update_room_entry(cls, info, room_entry_data): instance = get_object(RoomEntry, room_entry_data.get('id')) if not instance.room.school_class.is_user_in_schoolclass(info.context.user): @@ -116,7 +116,7 @@ class MutateRoomEntry(relay.ClientIDMutation): return RoomEntrySerializer(instance, data=room_entry_data, partial=True) @classmethod - def add_path(cls, info, room_entry_data, room): + def add_room_entry(cls, info, room_entry_data, room): if not room or not room.school_class.is_user_in_schoolclass(info.context.user): raise PermissionDenied('You are in the wrong class')