Add feedback to submission view, style view

This commit is contained in:
Christian Cueni 2019-11-13 19:25:24 +01:00
parent f84efc7f1c
commit ad07ada2f2
6 changed files with 53 additions and 20 deletions

View File

@ -1,14 +1,24 @@
<template> <template>
<div class="assignment-with-submissions"> <div class="assignment-with-submissions">
<!--<h1 class="assignment-with-submissions__title">{{assignment.assignment}}</h1>--> <!--<h1 class="assignment-with-submissions__title">{{assignment.assignment}}</h1>-->
<h4 class="assignment-with-submissions__heading">Aufgabe</h4>
<p class="assignment-with-submissions__text">{{assignment.assignment}}</p> <p class="assignment-with-submissions__text">{{assignment.assignment}}</p>
<div>
<a class="button button--primary submissions-page__back" @click="back">Aufgabe im Modul anzeigen</a>
</div>
<div class="assignment-with-submissions__solution" v-if="assignment.solution"> <div class="assignment-with-submissions__solution" v-if="assignment.solution">
<h4 class="assignment-with-submissions__heading">Lösung</h4> <h4 class="assignment-with-submissions__heading">Lösung</h4>
<p class="assignment-with-submissions__solution-text">{{assignment.solution}}</p> <p class="assignment-with-submissions__solution-text">{{assignment.solution}}</p>
</div> </div>
<p v-if="!assignment.submissions.length">Zu diesem Auftrag sind noch keine Ergebnisse vorhanden</p> <p v-if="!assignment.submissions.length">Zu diesem Auftrag sind noch keine Ergebnisse vorhanden</p>
<div class="assignment-with-submissions__submissions submissions">
<div class="submissions__header student-submission-row submission-header">
<p class="submission-header__title">Lernende</p>
<p class="submission-header__title">Ergebnisse</p>
<p class="submission-header__title">Feedback</p>
</div>
<router-link <router-link
:to="submissionLink(submission)" :to="submissionLink(submission)"
v-for="(submission, index) in submissions" v-for="(submission, index) in submissions"
@ -20,6 +30,8 @@
</student-submission> </student-submission>
</router-link> </router-link>
</div> </div>
</div>
</template> </template>
<script> <script>
@ -80,6 +92,7 @@
} }
&__text { &__text {
font-size: toRem(26px);
margin-bottom: 1rem; margin-bottom: 1rem;
} }
@ -95,10 +108,19 @@
&__link { &__link {
display: block; display: block;
&:first-of-type {
border-top: 1px solid $color-silver-dark;
} }
&__submissions {
margin-top: 3rem;
} }
} }
.submission-header {
&__title {
color: $color-silver-dark;
font-family: $sans-serif-font-family;
}
}
</style> </style>

View File

@ -1,5 +1,5 @@
<template> <template>
<div class="student-submission"> <div class="student-submission student-submission-row">
<div class="student-submission__student-name"> <div class="student-submission__student-name">
{{name}} {{name}}
</div> </div>
@ -9,6 +9,9 @@
<student-submission-document :document="submission.document" class="entry-document"></student-submission-document> <student-submission-document :document="submission.document" class="entry-document"></student-submission-document>
</p> </p>
</div> </div>
<div class="student-submission__feedback entry">
<p>{{submission.submissionfeedback.text | trimToLength(50)}}</p>
</div>
</div> </div>
</template> </template>
@ -50,12 +53,6 @@
@import "@/styles/_functions.scss"; @import "@/styles/_functions.scss";
.student-submission { .student-submission {
display: grid;
grid-template-columns: 170px 1fr;
grid-column-gap: 80px;
align-items: center;
border-bottom: 1px solid $color-silver-dark;
padding: 15px 0;
&__student-name { &__student-name {
font-size: toRem(17px); font-size: toRem(17px);

View File

@ -19,6 +19,11 @@ query AssignmentWithSubmissions($id: ID!) {
} }
} }
} }
submissionfeedback {
id
text
final
}
} }
} }
} }

View File

@ -1,9 +1,6 @@
<template> <template>
<div class="submissions-page"> <div class="submissions-page skillbox__content">
<div> <h2 class="submissions-page__heading">Aufgabe</h2>
<a class="button button--primary submissions-page__back" @click="back">Zurück zur Aufgabe</a>
</div>
<assignment-with-submissions v-if="!$apollo.queries.assignment.loading" <assignment-with-submissions v-if="!$apollo.queries.assignment.loading"
:assignment="assignment"></assignment-with-submissions> :assignment="assignment"></assignment-with-submissions>
</div> </div>
@ -61,8 +58,9 @@
grid-row-gap: $large-spacing; grid-row-gap: $large-spacing;
grid-template-rows: auto 1fr; grid-template-rows: auto 1fr;
@include desktop { margin-top: 2rem;
width: 800px;
}
} }
</style> </style>

View File

@ -0,0 +1,10 @@
@import "@/styles/_variables.scss";
.student-submission-row {
display: grid;
grid-template-columns: 170px 1fr 1fr;
grid-column-gap: 80px;
align-items: center;
border-bottom: 1px solid $color-silver-dark;
padding: 15px 0;
}

View File

@ -20,3 +20,4 @@
@import "solutions"; @import "solutions";
@import "password_forms"; @import "password_forms";
@import "public-page"; @import "public-page";
@import "student-submission"