Fix numbering issue on topic navigation

Resolves MS-810 #complete
This commit is contained in:
Ramon Wenger 2023-09-21 12:06:02 +02:00
parent b8df28a993
commit c721dc26aa
2 changed files with 20 additions and 3 deletions

View File

@ -2,7 +2,11 @@
<nav class="topic-navigation"> <nav class="topic-navigation">
<router-link <router-link
:to="{ name: 'topic', params: { topicSlug: topic.slug } }" :to="{ name: 'topic', params: { topicSlug: topic.slug } }"
:class="{ 'topic-navigation__topic--active': topic.active, 'book-subnavigation__item--mobile': mobile }" :class="{
'topic-navigation__topic--active': topic.active,
'book-subnavigation__item--mobile': mobile,
'topic-navigation__topic--no-numbering': !$flavor.showTopicNavigationNumbering,
}"
tag="div" tag="div"
active-class="book-subnavigation__item--active" active-class="book-subnavigation__item--active"
class="topic-navigation__topic book-subnavigation__item" class="topic-navigation__topic book-subnavigation__item"
@ -10,7 +14,6 @@
:key="topic.id" :key="topic.id"
@click="closeSidebar('navigation')" @click="closeSidebar('navigation')"
> >
<span v-if="$flavor.showTopicNavigationNumbering">{{ topic.order }}.</span>
{{ topic.title }} {{ topic.title }}
</router-link> </router-link>
</nav> </nav>
@ -57,9 +60,23 @@ export default {
<style scoped lang="scss"> <style scoped lang="scss">
@import 'styles/helpers'; @import 'styles/helpers';
// css counters: "https://www.freecodecamp.org/news/numbering-with-css-counters/"
.topic-navigation { .topic-navigation {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
counter-reset: css-counter 0;
&__topic {
counter-increment: css-counter 1;
&:before {
content: counter(css-counter) '. ';
}
&--no-numbering:before {
content: '';
}
}
} }
</style> </style>

View File

@ -88,7 +88,7 @@ const moduleLink = computed(() => {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
justify-content: space-between; justify-content: space-between;
align-content: start; align-content: flex-start;
@include desktop { @include desktop {
max-width: $topic-desktop-width; max-width: $topic-desktop-width;
} }