ramon
/
skillbox
1
0
Fork 0
Code Issues 1 Pull Requests 1 Packages Projects 1 Releases 1 Wiki Activity

Fix broken cypress test

This commit is contained in:
Ramon Wenger 2021-07-29 11:41:22 +02:00
parent d4182e7e1a
commit cccaf21c9c
4 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
client/cypress/integration/frontend/read-only/assignment-feedback-read-only.teacher.spec.js
View File

@ -55,7 +55,7 @@ describe('Assignment feedback read-only - Teacher', () => {
// cy.get('@textarea').should('have.attr', 'readonly'); // cy.get('@textarea').should('have.attr', 'readonly');
cy.isSubmissionReadOnly(myText); cy.isSubmissionReadOnly(myText);
cy.canReopen(false); cy.getByDataCy('final-submission-reopen').should('not.exist');
}); });
it('can edit', () => { it('can edit', () => {
cy.mockGraphqlOps({ cy.mockGraphqlOps({
@ -63,6 +63,7 @@ describe('Assignment feedback read-only - Teacher', () => {
}); });
cy.visit('submission/submission-id'); cy.visit('submission/submission-id');
cy.canReopen(false);
cy.getByDataCy('final-submission-reopen').should('exist');
}); });
}); });

4
client/cypress/integration/frontend/read-only/assignment-read-only.student.spec.js
View File

@ -90,7 +90,7 @@ describe('Assignments read-only - Student', () => {
cy.visit('module/module-with-assignment'); cy.visit('module/module-with-assignment');
cy.isSubmissionReadOnly(myText); cy.isSubmissionReadOnly(myText);
cy.canReopen(false); cy.getByDataCy('final-submission-reopen').should('not.exist');
}); });
it('can revoke turn in', () => { it('can revoke turn in', () => {
@ -110,6 +110,6 @@ describe('Assignments read-only - Student', () => {
cy.visit('module/module-with-assignment'); cy.visit('module/module-with-assignment');
cy.getByDataCy('final-submission').should('exist'); cy.getByDataCy('final-submission').should('exist');
cy.canReopen(false); cy.getByDataCy('final-submission-reopen').should('not.exist');
}); });
}); });

5
client/cypress/support/commands.js
View File

@ -146,11 +146,6 @@ Cypress.Commands.add('fakeLogin', () => {
cy.setCookie('loginStatus', 'true'); cy.setCookie('loginStatus', 'true');
}); });
Cypress.Commands.add('canReopen', (exists) => {
let check = exists ? 'exist' : 'not.exist';
cy.getByDataCy('final-submission-reopen').should(check);
});
Cypress.Commands.add('isSubmissionReadOnly', (myText) => { Cypress.Commands.add('isSubmissionReadOnly', (myText) => {
cy.get('.submission-form__textarea--readonly').as('textarea'); cy.get('.submission-form__textarea--readonly').as('textarea');

2
client/cypress/support/index.d.ts vendored
View File

@ -24,8 +24,6 @@ declare namespace Cypress {
fakeLogin(username: string, password: string): void fakeLogin(username: string, password: string): void
canReopen(exists: boolean): void
isSubmissionReadOnly(myText: string): void isSubmissionReadOnly(myText: string): void
openSidebar(): void openSidebar(): void