From d80abf5b094592b6d408dfcecbc10cfcd23ed5a4 Mon Sep 17 00:00:00 2001 From: Christian Cueni Date: Tue, 23 Oct 2018 10:43:32 +0200 Subject: [PATCH] =?UTF-8?q?Prevent=20backend=20from=20changing=20a=20block?= =?UTF-8?q?=E2=80=99s=20type?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- server/books/schema/mutations/contentblock.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/books/schema/mutations/contentblock.py b/server/books/schema/mutations/contentblock.py index 8539d949..f6a335dd 100644 --- a/server/books/schema/mutations/contentblock.py +++ b/server/books/schema/mutations/contentblock.py @@ -29,9 +29,10 @@ class MutateContentBlock(relay.ClientIDMutation): title = content_block_data.get('title', None) contents = content_block_data.get('contents', None) visibility_list = content_block_data.get('visibility', None) - block_type = content_block_data.get('type', ContentBlock.NORMAL) content_block = get_object(ContentBlock, id_param) + + block_type = content_block_data.get('type', content_block.type.upper()) module = content_block.get_parent().get_parent().specific if visibility_list is not None: @@ -47,7 +48,6 @@ class MutateContentBlock(relay.ClientIDMutation): content_block.contents = json.dumps([handle_content_block(c, info.context, module) for c in contents]) content_block.type = set_user_defined_block_type(block_type) - content_block.save() return cls(content_block=content_block)