From dc43b889165ba34cf598731c2785fe7926ebc134 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Thu, 5 Aug 2021 11:41:57 +0200
Subject: [PATCH] Add cypress test for read only portfolio

---
 .../frontend/read-only/portfolio.spec.js      | 44 +++++++++++++++++
 .../frontend/read-only/project.spec.js        | 48 +++++++++++++++++++
 .../integration/frontend/snapshots.spec.js    |  1 -
 client/cypress/support/helpers.js             |  1 +
 .../components/portfolio/ProjectActions.vue   |  4 +-
 .../src/components/portfolio/ProjectEntry.vue | 13 ++---
 .../components/portfolio/ProjectWidget.vue    |  9 ++--
 .../graphql/gql/fragments/projectParts.gql    |  2 +-
 .../src/graphql/gql/queries/projectQuery.gql  |  2 +-
 client/src/pages/portfolio/portfolio.vue      |  6 ++-
 client/src/pages/portfolio/project.vue        | 11 +++--
 server/core/management/commands/dummy_data.py | 16 +++----
 12 files changed, 130 insertions(+), 27 deletions(-)
 create mode 100644 client/cypress/integration/frontend/read-only/portfolio.spec.js
 create mode 100644 client/cypress/integration/frontend/read-only/project.spec.js

diff --git a/client/cypress/integration/frontend/read-only/portfolio.spec.js b/client/cypress/integration/frontend/read-only/portfolio.spec.js
new file mode 100644
index 00000000..8eb73b66
--- /dev/null
+++ b/client/cypress/integration/frontend/read-only/portfolio.spec.js
@@ -0,0 +1,44 @@
+import {getMinimalMe} from '../../../support/helpers';
+
+const getOperations = ({readOnly = false}) => ({
+  MeQuery: getMinimalMe({readOnly}),
+  ProjectsQuery: {
+    projects: {
+      edges: [
+        {
+          node: {
+            id: 'projectId',
+            final: false,
+            student: {
+              id: 'meId',
+            },
+            entriesCount: 3,
+          },
+        },
+      ],
+    },
+  },
+});
+
+describe('Read Only Portfolio', () => {
+  beforeEach(() => {
+    cy.setup();
+  });
+
+  it('Can create and edit project', () => {
+    cy.mockGraphqlOps({operations: getOperations({readOnly: false})});
+
+    cy.visit('/portfolio');
+    cy.getByDataCy('add-project-button').should('exist');
+    cy.getByDataCy('project-widget').should('have.length', 1);
+    cy.getByDataCy('project-widget-actions').should('exist');
+  });
+  it('Can not create and edit project', () => {
+    cy.mockGraphqlOps({operations: getOperations({readOnly: true})});
+
+    cy.visit('/portfolio');
+    cy.getByDataCy('add-project-button').should('not.exist');
+    cy.getByDataCy('project-widget').should('have.length', 1);
+    cy.getByDataCy('project-widget-actions').should('not.exist');
+  });
+});
diff --git a/client/cypress/integration/frontend/read-only/project.spec.js b/client/cypress/integration/frontend/read-only/project.spec.js
new file mode 100644
index 00000000..b27e1d64
--- /dev/null
+++ b/client/cypress/integration/frontend/read-only/project.spec.js
@@ -0,0 +1,48 @@
+import {getMinimalMe} from '../../../support/helpers';
+
+const getOperations = ({readOnly = false}) => ({
+  MeQuery: getMinimalMe({readOnly}),
+  ProjectQuery: {
+    project: {
+      id: 'projectId',
+      final: false,
+      student: {
+        id: 'meId',
+      },
+      entriesCount: 3,
+      entries: {
+        edges: [
+          {
+            node: {},
+          },
+        ],
+      },
+    },
+  },
+});
+
+const testProject = (readOnly, shouldActionsExist) => {
+  cy.mockGraphqlOps({operations: getOperations({readOnly})});
+
+  const exist = shouldActionsExist ? 'exist' : 'not.exist';
+
+  cy.visit('/portfolio/project-name');
+  cy.getByDataCy('project-title').should('exist');
+  cy.getByDataCy('project-entry').should('have.length', 1);
+  cy.getByDataCy('add-project-entry').should(exist);
+  cy.getByDataCy('project-actions').should(exist);
+  cy.getByDataCy('project-entry-more').should(exist);
+};
+
+describe('Read Only Project', () => {
+  beforeEach(() => {
+    cy.setup();
+  });
+
+  it('Can create and edit project entry', () => {
+    testProject(false, true);
+  });
+  it('Can not create and edit project entry', () => {
+    testProject(true, false);
+  });
+});
diff --git a/client/cypress/integration/frontend/snapshots.spec.js b/client/cypress/integration/frontend/snapshots.spec.js
index d820584d..3877580d 100644
--- a/client/cypress/integration/frontend/snapshots.spec.js
+++ b/client/cypress/integration/frontend/snapshots.spec.js
@@ -1,4 +1,3 @@
-import getMe from '../../fixtures/me.minimal';
 import module from '../../fixtures/module.minimal';
 import mocks from '../../fixtures/mocks';
 import {getMinimalMe} from '../../support/helpers';
diff --git a/client/cypress/support/helpers.js b/client/cypress/support/helpers.js
index 27532c28..908b7e77 100644
--- a/client/cypress/support/helpers.js
+++ b/client/cypress/support/helpers.js
@@ -2,6 +2,7 @@
 
 export const getMinimalMe = ({readOnly = false, classReadOnly = false, isTeacher = true}) => ({
   me: {
+    id: 'meId',
     onboardingVisited: true,
     readOnly,
     isTeacher,
diff --git a/client/src/components/portfolio/ProjectActions.vue b/client/src/components/portfolio/ProjectActions.vue
index 601ebefa..ebe17199 100644
--- a/client/src/components/portfolio/ProjectActions.vue
+++ b/client/src/components/portfolio/ProjectActions.vue
@@ -1,5 +1,7 @@
 <template>
-  <div class="project-actions">
+  <div
+    class="project-actions"
+    data-cy="project-actions">
     <a
       class="project-actions__more-link"
       @click="toggleMenu">
diff --git a/client/src/components/portfolio/ProjectEntry.vue b/client/src/components/portfolio/ProjectEntry.vue
index 47e61edc..1dcaff85 100644
--- a/client/src/components/portfolio/ProjectEntry.vue
+++ b/client/src/components/portfolio/ProjectEntry.vue
@@ -1,8 +1,11 @@
 <template>
-  <div class="project-entry">
+  <div
+    class="project-entry"
+    data-cy="project-entry">
     <more-options-widget
       class="project-entry__more"
-      data-cy="project-entry-more">
+      data-cy="project-entry-more"
+      v-if="!readOnly">
       <li class="popover-links__link"><a
         data-cy="edit-project-entry"
         @click="editProjectEntry()">Eintrag bearbeiten</a>
@@ -48,7 +51,7 @@
   import PROJECT_QUERY from '@/graphql/gql/queries/projectQuery.gql';
 
   export default {
-    props: ['activity', 'reflection', 'nextSteps', 'documentUrl', 'created', 'id'],
+    props: ['activity', 'reflection', 'nextSteps', 'documentUrl', 'created', 'id', 'readOnly'],
     components: {
       DocumentBlock,
       MoreOptionsWidget
@@ -87,9 +90,7 @@
 </script>
 
 <style scoped lang="scss">
-  @import "@/styles/_variables.scss";
-  @import "@/styles/_functions.scss";
-  @import "@/styles/_mixins.scss";
+  @import "~styles/helpers";
 
   .project-entry {
     background-color: $color-white;
diff --git a/client/src/components/portfolio/ProjectWidget.vue b/client/src/components/portfolio/ProjectWidget.vue
index b0dbb901..a228ee99 100644
--- a/client/src/components/portfolio/ProjectWidget.vue
+++ b/client/src/components/portfolio/ProjectWidget.vue
@@ -1,6 +1,7 @@
 <template>
   <div
     :class="widgetClass"
+    data-cy="project-widget"
     class="project-widget">
     <router-link
       :to="{name: 'project', params: {slug: slug}}"
@@ -15,11 +16,13 @@
         class="project-widget__owner"/>
     </router-link>
     <widget-footer
+      data-cy="project-widget-footer"
       class="project-widget__footer"
       v-if="isOwner">
       <project-actions
         :id="id"
-        :final="final"/>
+        :final="final"
+        data-cy="project-widget-actions"/>
     </widget-footer>
   </div>
 </template>
@@ -53,9 +56,7 @@
 </script>
 
 <style scoped lang="scss">
-  @import "@/styles/_variables.scss";
-  @import "@/styles/_functions.scss";
-  @import "@/styles/_mixins.scss";
+  @import "~styles/helpers";
 
   .project-widget {
     border-radius: $default-border-radius;
diff --git a/client/src/graphql/gql/fragments/projectParts.gql b/client/src/graphql/gql/fragments/projectParts.gql
index 3e98bef0..d80ccb45 100644
--- a/client/src/graphql/gql/fragments/projectParts.gql
+++ b/client/src/graphql/gql/fragments/projectParts.gql
@@ -9,7 +9,7 @@ fragment ProjectParts on ProjectNode {
   student {
     firstName
     lastName
-    id,
+    id
     avatarUrl
   }
   entriesCount
diff --git a/client/src/graphql/gql/queries/projectQuery.gql b/client/src/graphql/gql/queries/projectQuery.gql
index ddae29a9..12b7777a 100644
--- a/client/src/graphql/gql/queries/projectQuery.gql
+++ b/client/src/graphql/gql/queries/projectQuery.gql
@@ -3,7 +3,7 @@
 query ProjectQuery($id: ID, $slug: String){
   project(slug: $slug, id: $id) {
     ...ProjectParts
-        entries {
+    entries {
       edges {
         node {
           ...ProjectEntryParts
diff --git a/client/src/pages/portfolio/portfolio.vue b/client/src/pages/portfolio/portfolio.vue
index 1356d934..9bbabfdd 100644
--- a/client/src/pages/portfolio/portfolio.vue
+++ b/client/src/pages/portfolio/portfolio.vue
@@ -1,7 +1,9 @@
 <template>
   <div class="portfolio__page">
     <div class="portfolio">
-      <add-project class="portfolio__add-project"/>
+      <add-project
+        class="portfolio__add-project"
+        v-if="!me.readOnly"/>
 
       <project-widget
         v-bind="project"
@@ -56,7 +58,7 @@
 </script>
 
 <style scoped lang="scss">
-  @import "@/styles/_variables.scss";
+  @import "~styles/helpers";
 
   .portfolio {
     display: flex;
diff --git a/client/src/pages/portfolio/project.vue b/client/src/pages/portfolio/project.vue
index aeef749d..8acbfbef 100644
--- a/client/src/pages/portfolio/project.vue
+++ b/client/src/pages/portfolio/project.vue
@@ -3,7 +3,9 @@
     :class="specialContainerClass"
     class="project">
     <div class="project__header">
-      <h1 class="project__title">{{ project.title }}</h1>
+      <h1
+        class="project__title"
+        data-cy="project-title">{{ project.title }}</h1>
       <p class="project__description">
         {{ project.description }}
       </p>
@@ -18,7 +20,9 @@
       </ul>
 
       <div class="project__meta">
-        <project-actions :id="project.id"/>
+        <project-actions
+          :id="project.id"
+          v-if="!me.readOnly"/>
         <owner-widget :owner="project.student"/>
         <entry-count-widget :entry-count="projectEntryCount"/>
       </div>
@@ -29,10 +33,11 @@
         :project="project.id"
         class="project__add-entry"
         data-cy="add-project-entry"
-        v-if="isOwner"/>
+        v-if="isOwner && !me.readOnly"/>
       <project-entry
         v-bind="entry"
         :key="index"
+        :read-only="me.readOnly"
         v-for="(entry, index) in project.entries"/>
     </div>
   </div>
diff --git a/server/core/management/commands/dummy_data.py b/server/core/management/commands/dummy_data.py
index 1898ff21..0e11c4b1 100644
--- a/server/core/management/commands/dummy_data.py
+++ b/server/core/management/commands/dummy_data.py
@@ -48,7 +48,7 @@ class Command(BaseCommand):
 
         Page.objects.get(title='Root').delete()
 
-        u = UserFactory(
+        UserFactory(
             username='test',
             is_staff=True,
             is_superuser=True,
@@ -69,20 +69,20 @@ class Command(BaseCommand):
         for book_idx, book_data in enumerate(data):
             book = BookFactory.create(parent=site.root_page, **self.filter_data(book_data, 'topics'))
 
-            default_topics = [{} for i in range(0, random.randint(5, 8))]
+            default_topics = [{} for _ in range(0, random.randint(5, 8))]
             topics_data = book_data.get('topics', default_topics)
 
             for topic_idx, topic_data in enumerate(topics_data):
                 topic = TopicFactory.create(parent=book, **self.filter_data(topic_data, 'modules'))
 
-                default_modules = [{} for i in range(0, random.randint(3, 6))]
+                default_modules = [{} for _ in range(0, random.randint(3, 6))]
                 modules_data = topic_data.get('modules', default_modules)
 
                 for module_idx, module_data in enumerate(modules_data):
                     module = ModuleFactory.create(parent=topic,
                                                   **self.filter_data(module_data, ['objective_groups', 'chapters']))
 
-                    default_objective_groups = [{} for i in range(0, 2)]
+                    default_objective_groups = [{} for _ in range(0, 2)]
                     objective_group_data = module_data.get('objective_groups', default_objective_groups)
 
                     for objective_group_idx, objective_group_entry in enumerate(objective_group_data):
@@ -91,20 +91,20 @@ class Command(BaseCommand):
                                                                        
                                                                        **factory_params)
 
-                        default_objectives = [{} for i in range(0, 4)]
+                        default_objectives = [{} for _ in range(0, 4)]
                         objectives_data = objective_group_entry.get('objectives', default_objectives)
 
                         for objective_idx, objective_data in enumerate(objectives_data):
-                            objective = ObjectiveFactory.create(group=objective_group, **objective_data)
+                            ObjectiveFactory.create(group=objective_group, **objective_data)
 
-                    default_chapters = [{} for i in range(0, 2)]
+                    default_chapters = [{} for _ in range(0, 2)]
                     chapters_data = module_data.get('chapters', default_chapters)
 
                     for chapter_idx, chapter_data in enumerate(chapters_data):
                         chapter = ChapterFactory.create(parent=module,
                                                         **self.filter_data(chapter_data, 'content_blocks'))
 
-                        default_content_blocks = [{} for i in range(0, 4)]
+                        default_content_blocks = [{} for _ in range(0, 4)]
                         content_blocks_data = chapter_data.get('content_blocks', default_content_blocks)
 
                         for content_block_idx, content_block_data in enumerate(content_blocks_data):