Fix local login

client/cypress/integration/local-login.spec.js

@@ -12,7 +12,7 @@ describe('The Login Page', () => {
     const username = '';
     const password = 'test';
 
-    cy.visit('/');
+    cy.visit('/old-login');
     cy.login(username, password);
     cy.get('[data-cy=email-local-errors]').contains('E-Mail ist ein Pflichtfeld');
   });
@@ -21,7 +21,7 @@ describe('The Login Page', () => {
     const username = 'test';
     const password = '';
 
-    cy.visit('/');
+    cy.visit('/old-login');
     cy.login(username, password);
     cy.get('[data-cy=password-local-errors]').contains('Passwort ist ein Pflichtfeld');
   });
@@ -30,18 +30,9 @@ describe('The Login Page', () => {
     const username = 'test';
     const password = '12345';
 
-    cy.visit('/');
+    cy.visit('/old-login');
     cy.login(username, password);
     cy.get('[data-cy=login-error]').contains('Die E-Mail oder das Passwort ist falsch. Bitte versuchen Sie nochmals.');
   });
 
-  it('redirect after login', () => {
-    const username = 'test';
-    const password = 'test';
-
-    cy.visit('/book/topic/berufliche-grundbildung');
-    cy.login(username, password);
-    cy.get('body').contains('Berufliche Grundbildung');
-  });
-
 })

client/cypress/support/commands.js

@@ -54,7 +54,7 @@ Cypress.Commands.add('apolloLogin', (username, password) => {
 // todo: replace with apollo call
 Cypress.Commands.add("login", (username, password, visitLogin = false) => {
   if (visitLogin) {
-    cy.visit('/login-local');
+    cy.visit('/old-login');
   }
 
   if (username != '') {

client/src/graphql/gql/fragments/userParts.gql

@@ -7,7 +7,7 @@ fragment UserParts on UserNode {
   firstName
   lastName
   avatarUrl
-  licenseExpiryDate
+  expiryDate
   lastModule {
     id
     slug

client/src/graphql/gql/mutations/loginLocal.gql

@@ -1,5 +1,5 @@
-mutation Login($input: LoginInput!) {
+mutation LocalLogin($input: LocalLoginInput!) {
-  login(input: $input) {
+  localLogin(input: $input) {
     success
     message
     errors {

client/src/main.js

@@ -137,7 +137,7 @@ function unauthorizedAccess(to) {
 function redirectUsersWithoutValidLicense(to) {
   return privateApolloClient.query({
     query: ME_QUERY,
-  }).then(({data}) => data.me.licenseExpiryDate == null);
+  }).then(({data}) => data.me.expiryDate == null);
 }
 
 function redirectStudentsWithoutClass() {

client/src/pages/login-local.vue

@@ -71,7 +71,7 @@
 </template>
 
 <script>
-import LOGIN_MUTATION from '@/graphql/gql/mutations/login.gql';
+import LOGIN_LOCAL_MUTATION from '@/graphql/gql/mutations/loginLocal.gql';
 
 export default {
   components: {},
@@ -84,7 +84,7 @@ export default {
         if (result) {
           this.$apollo.mutate({
             client: 'publicClient',
-            mutation: LOGIN_MUTATION,
+            mutation: LOGIN_LOCAL_MUTATION,
             variables: {
               input: {
                 usernameInput: this.email,
@@ -95,16 +95,16 @@ export default {
               store,
               {
                 data: {
-                  login
+                  localLogin
                 }
               }
             ) {
               try {
-                if (login.success) {
+                if (localLogin.success) {
                   const redirectUrl = that.$route.query.redirect ? that.$route.query.redirect : '/'
                   that.$router.push(redirectUrl);
                 } else {
-                  const firstError = login.errors[0];
+                  const firstError = localLogin.errors[0];
                   switch (firstError.field) {
                     case 'invalid_credentials':
                       that.loginError = 'Die E-Mail oder das Passwort ist falsch. Bitte versuchen Sie nochmals.';

client/src/router/index.js

@@ -64,8 +64,8 @@ const routes = [
     }
   },
   {
-    path: '/login-local',
+    path: '/old-login',
-    name: 'loginLocal',
+    name: 'oldLogin',
     component: loginLocal,
     meta: {
       layout: 'public',

server/core/utils.py

@@ -28,6 +28,9 @@ def is_private_api_call_allowed(user, body):
 
     body_unicode = body.decode('utf-8')
 
+    if not user.hep_id:
+        return True
+
     if re.search(r"mutation\s*.*\s*logout\s*{", body_unicode) or re.search(r"query\s*.*\s*me\s*{", body_unicode)\
         or re.search(r"mutation\s*Coupon", body_unicode):
         return True

server/users/schema.py

@@ -1,7 +1,10 @@
+from datetime import datetime
+
 import graphene
 from graphene import relay
 from graphene_django import DjangoObjectType
 from graphene_django.filter import DjangoFilterConnectionField
+from django.utils.dateformat import format
 
 from basicknowledge.models import BasicKnowledge
 from basicknowledge.queries import InstrumentNode
@@ -26,12 +29,13 @@ class UserNode(DjangoObjectType):
     pk = graphene.Int()
     permissions = graphene.List(graphene.String)
     selected_class = graphene.Field(SchoolClassNode)
+    expiry_date = graphene.List(graphene.String)
 
     class Meta:
         model = User
         filter_fields = ['username', 'email']
         only_fields = ['username', 'email', 'first_name', 'last_name', 'school_classes', 'last_module', 'avatar_url',
-                       'selected_class', 'license_expiry_date']
+                       'selected_class', 'expiry_date']
         interfaces = (relay.Node,)
 
     def resolve_pk(self, info, **kwargs):
@@ -43,6 +47,12 @@ class UserNode(DjangoObjectType):
     def resolve_selected_class(self, info):
         return self.selected_class()
 
+    def resolve_expiry_date(self, info):
+        if not self.hep_id: # concerns users that already have an (old) account
+            return format(datetime(2020, 7, 31), 'U')  # just set some expiry date
+        else:
+            return self.license_expiry_date
+
 
 class UsersQuery(object):
     me = graphene.Field(UserNode)