From e6f852fdc44b60710de5210d6b82f17cb60ddaa7 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Tue, 10 Mar 2020 15:35:55 +0100
Subject: [PATCH] Clean up code

---
 client/src/mixins/updateSelectedClass.js | 2 +-
 client/src/pages/myClass.vue             | 7 +++++--
 client/src/pages/oldClasses.vue          | 1 -
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/client/src/mixins/updateSelectedClass.js b/client/src/mixins/updateSelectedClass.js
index 15505fd8..a9f99bee 100644
--- a/client/src/mixins/updateSelectedClass.js
+++ b/client/src/mixins/updateSelectedClass.js
@@ -17,7 +17,7 @@ export default {
           store.writeQuery({query: ME_QUERY, data: meData});
         }
       }).catch((error) => {
-        console.log('fail', error)
+        console.warn('failed to update selected class', error)
       });
     }
   },
diff --git a/client/src/pages/myClass.vue b/client/src/pages/myClass.vue
index 3a9a9d10..fb48d4ff 100644
--- a/client/src/pages/myClass.vue
+++ b/client/src/pages/myClass.vue
@@ -25,7 +25,6 @@
 
     methods: {
       changeMember(member, active) {
-        console.log()
         this.$apollo.mutate({
           mutation: ADD_REMOVE_MEMBER_MUTATION,
           variables: {
@@ -40,7 +39,11 @@
               const query = MY_SCHOOL_CLASS_QUERY;
               const data = store.readQuery({query});
               let memberIndex = data.me.selectedClass.members.findIndex(m => m.id === member.id);
-              data.me.selectedClass.members.splice(memberIndex, 1, {...member, active});
+              data.me.selectedClass.members = [
+                ...data.me.selectedClass.members.slice(0, memberIndex),
+                {...member, active},
+                ...data.me.selectedClass.members.slice(memberIndex),
+              ];
               store.writeQuery({query, data});
             }
           }
diff --git a/client/src/pages/oldClasses.vue b/client/src/pages/oldClasses.vue
index 34753e2f..9235c052 100644
--- a/client/src/pages/oldClasses.vue
+++ b/client/src/pages/oldClasses.vue
@@ -21,7 +21,6 @@
     methods: {
       updateSelectedClassAndGoToClassList(selectedClass) {
         this.updateSelectedClass(selectedClass).then(() => {
-          console.log('roger');
           this.$router.push({name: 'my-class'});
         });
       }