From fcc38047b144865eba70720eab89d882c969b90c Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Wed, 19 Jul 2023 12:09:06 +0200
Subject: [PATCH] Remove explicit support link property

Change support link to dynamic href using base url environment variable

Resolves MS-730 #complete
---
 client/src/components/book-navigation/ContentNavigation.vue | 2 +-
 client/src/helpers/app-flavor.constants.ts                  | 2 --
 client/src/helpers/types.ts                                 | 1 -
 client/src/pages/hello.vue                                  | 2 +-
 4 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/client/src/components/book-navigation/ContentNavigation.vue b/client/src/components/book-navigation/ContentNavigation.vue
index d4461d2d..a098d158 100644
--- a/client/src/components/book-navigation/ContentNavigation.vue
+++ b/client/src/components/book-navigation/ContentNavigation.vue
@@ -83,7 +83,7 @@
         v-if="isSidebar"
       >
         <a
-          :href="$flavor.supportLink"
+          :href="`https://${$flavor.baseUrl}/support`"
           target="_blank"
           class="content-navigation__link content-navigation__link--secondary"
           @click="close"
diff --git a/client/src/helpers/app-flavor.constants.ts b/client/src/helpers/app-flavor.constants.ts
index fea134fb..57bf5d63 100644
--- a/client/src/helpers/app-flavor.constants.ts
+++ b/client/src/helpers/app-flavor.constants.ts
@@ -3,7 +3,6 @@ import type { FlavorValues } from '@/helpers/types';
 export const defaultFlavorValues: FlavorValues = {
   appFlavor: 'skillbox',
   appLogo: '/static/logo.png',
-  supportLink: 'https://myskillbox.ch/support',
   baseUrl: 'myskillbox.ch',
 
   // mySkillbox texts
@@ -28,7 +27,6 @@ export const defaultFlavorValues: FlavorValues = {
 export const myKvValues: FlavorValues = {
   appFlavor: 'my-kv',
   appLogo: 'https://skillbox-my-kv-prod.s3-eu-west-1.amazonaws.com/mykv-logo.png',
-  supportLink: 'https://www.mykv.ch/support',
   baseUrl: 'mykv.ch',
 
   // myKV texts
diff --git a/client/src/helpers/types.ts b/client/src/helpers/types.ts
index c67e1a8e..16e83757 100644
--- a/client/src/helpers/types.ts
+++ b/client/src/helpers/types.ts
@@ -1,7 +1,6 @@
 export interface FlavorValues {
   appFlavor: string;
   appLogo: string;
-  supportLink: string;
   baseUrl: string;
   textAppName: string;
   textTopic: string;
diff --git a/client/src/pages/hello.vue b/client/src/pages/hello.vue
index 6227b5fe..4565dc2b 100644
--- a/client/src/pages/hello.vue
+++ b/client/src/pages/hello.vue
@@ -66,7 +66,7 @@
           <a :href="`https://${$flavor.baseUrl}/angebot`">Lizenz kaufen</a>
         </li>
         <li class="links__list-item">
-          <a :href="$flavor.supportLink">Support</a>
+          <a :href="`https://${$flavor.baseUrl}/support`">Support</a>
         </li>
         <li class="links__list-item">
           <a :href="`https://${$flavor.baseUrl}/datenschutz`">Datenschutz</a>