From e4bb4cc9ee40a244717a6114029be98a80aa2e2d Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Thu, 1 Jul 2021 16:58:56 +0200
Subject: [PATCH 01/11] Add tests for read only assignments

---
 client/cypress/fixtures/mocks.js              | 26 +++++-
 ...ignment-feedback-read-only.teacher.spec.js |  8 ++
 .../assignment-read-only.student.spec.js      | 82 +++++++++++++++++++
 .../assignment/SubmissionForm.vue             |  1 +
 .../src/graphql/gql/fragments/userParts.gql   |  1 +
 server/assignments/tests/test_read_only.py    | 15 ++++
 server/schema.graphql                         |  1 +
 server/users/models.py                        |  5 ++
 server/users/schema.py                        |  3 +-
 9 files changed, 137 insertions(+), 5 deletions(-)
 create mode 100644 client/cypress/integration/frontend/assignment-feedback-read-only.teacher.spec.js
 create mode 100644 client/cypress/integration/frontend/assignment-read-only.student.spec.js
 create mode 100644 server/assignments/tests/test_read_only.py

diff --git a/client/cypress/fixtures/mocks.js b/client/cypress/fixtures/mocks.js
index d54c15ce..bd2e669d 100644
--- a/client/cypress/fixtures/mocks.js
+++ b/client/cypress/fixtures/mocks.js
@@ -1,11 +1,11 @@
 export default {
   UUID: () => '123-456-789',
-  GenericStreamFieldType: () => 'GenericStreamFieldType',
+  GenericStreamFieldType: () => ({type: 'text_block', value: 'Generic Stream Field Type'}),
   DateTime: () => '2021-01-01Z10:01:23',
   SnapshotNode: () => ({
     //   id: ID!
     //   module: ModuleNode!
-      chapters: [],
+    chapters: [],
     //   chapters: [SnapshotChapterNode]
     //   hiddenContentBlocks(offset: Int, before: String, after: String, first: Int, last: Int, slug: String, title: String): ContentBlockNodeConnection!
     //   created: DateTime!
@@ -13,13 +13,31 @@ export default {
     //   shared: Boolean!
     //   objectiveGroups: [SnapshotObjectiveGroupNode]
     //   hiddenObjectives(offset: Int, before: String, after: String, first: Int, last: Int, text: String): ObjectiveNodeConnection!
-      title: 'MockSnapshotTitle',
-      metaTitle: 'MockSnapshotMetaTitle'
+    title: 'MockSnapshotTitle',
+    metaTitle: 'MockSnapshotMetaTitle',
     //   heroImage: String
     //   changes: SnapshotChangesNode
     //   mine: Boolean
   }),
+  ChapterNode: () => ({
+    slug: 'chapter-slug',
+    id: 'chapter-id',
+    title: 'chapter-title',
+    description: 'chapter-description',
+
+  }),
   ContentBlockNode: () => ({
     contents: [],
+    title: 'content-block-title',
+    slug: 'content-block-slug',
+    userCreated: false,
+    type: '',
+    id: 'content-block-id',
+  }),
+  AssignmentNode: () => ({
+    id: 'assignment-id',
+    title: 'Assignment Title',
+    assignment: 'Assignment Text',
+    solution: 'Assignment Solution',
   }),
 };
diff --git a/client/cypress/integration/frontend/assignment-feedback-read-only.teacher.spec.js b/client/cypress/integration/frontend/assignment-feedback-read-only.teacher.spec.js
new file mode 100644
index 00000000..bbfcaf07
--- /dev/null
+++ b/client/cypress/integration/frontend/assignment-feedback-read-only.teacher.spec.js
@@ -0,0 +1,8 @@
+describe('Assignment feedback read-only - Teacher', () => {
+  it('can not edit', () => {
+    cy.get('.not-implemented');
+  });
+  it('can not share', () => {
+    cy.get('.not-implemented');
+  });
+});
diff --git a/client/cypress/integration/frontend/assignment-read-only.student.spec.js b/client/cypress/integration/frontend/assignment-read-only.student.spec.js
new file mode 100644
index 00000000..ec436ecf
--- /dev/null
+++ b/client/cypress/integration/frontend/assignment-read-only.student.spec.js
@@ -0,0 +1,82 @@
+import mocks from '../../fixtures/mocks';
+import minimalModule from '../../fixtures/module.minimal';
+
+const module = {
+  ...minimalModule,
+  chapters: [
+    {
+      contentBlocks: [
+        {
+          type: 'task',
+          contents: [
+            {
+              type: 'text_block',
+              value: {
+                text: 'hallo velo',
+              },
+              id: 'bla-123',
+            },
+
+            {
+              type: 'assignment',
+              value: {
+                title: 'assignment-title',
+                assignment: 'assignment-assignment',
+                id: 'some-assignment',
+              },
+              id: '123-456',
+            },
+          ],
+        },
+      ],
+    },
+  ],
+};
+
+const myText = 'submission text';
+
+const operations = {
+  MeQuery: {
+    me: {
+      onboardingVisited: true,
+    },
+  },
+  ModuleDetailsQuery: {
+    module,
+  },
+  AssignmentQuery: {
+    assignment: {
+      submission: {
+        text: myText,
+        final: false,
+        document: '',
+        submissionFeedback: null
+      },
+    },
+  },
+};
+
+describe('Assignments read-only - Student', () => {
+  beforeEach(() => {
+    cy.fakeLogin('rahel.cueni', 'test');
+    cy.server();
+    cy.task('getSchema').then(schema => {
+      cy.mockGraphql({
+        schema,
+        mocks,
+        operations,
+      });
+    });
+  });
+
+  it('can not edit', () => {
+    cy.visit('module/module-with-assignment');
+
+    cy.get('.submission-form__textarea').invoke('val').should('contain', myText);
+    cy.getByDataCy('submission-form-submit').should('not.exist');
+  });
+
+  it('can not turn in', () => {
+    cy.get('.not-implemented');
+  });
+});
diff --git a/client/src/components/content-blocks/assignment/SubmissionForm.vue b/client/src/components/content-blocks/assignment/SubmissionForm.vue
index 46afbfac..cb94c2eb 100644
--- a/client/src/components/content-blocks/assignment/SubmissionForm.vue
+++ b/client/src/components/content-blocks/assignment/SubmissionForm.vue
@@ -16,6 +16,7 @@
       v-if="!final">
       <button
         class="submission-form-container__submit button button--primary button--white-bg"
+        data-cy="submission-form-submit"
         @click="$emit('turnIn')"
       >{{ action }}
       </button>
diff --git a/client/src/graphql/gql/fragments/userParts.gql b/client/src/graphql/gql/fragments/userParts.gql
index 6d6b949e..ef1f47e5 100644
--- a/client/src/graphql/gql/fragments/userParts.gql
+++ b/client/src/graphql/gql/fragments/userParts.gql
@@ -9,6 +9,7 @@ fragment UserParts on PrivateUserNode {
   lastName
   avatarUrl
   expiryDate
+  readOnly
   lastModule {
     id
     slug
diff --git a/server/assignments/tests/test_read_only.py b/server/assignments/tests/test_read_only.py
new file mode 100644
index 00000000..09f1bfc0
--- /dev/null
+++ b/server/assignments/tests/test_read_only.py
@@ -0,0 +1,15 @@
+from core.tests.base_test import SkillboxTestCase
+
+
+class AssignmentReadOnlyTestCase(SkillboxTestCase):
+    def test_edit_assignment_fails(self):
+        raise NotImplementedError()
+
+    def test_share_assignment_fails(self):
+        raise NotImplementedError()
+
+    def test_edit_feedback_fails(self):
+        raise NotImplementedError()
+
+    def test_share_feedback_fails(self):
+        raise NotImplementedError()
diff --git a/server/schema.graphql b/server/schema.graphql
index 07ddbaaf..266904a2 100644
--- a/server/schema.graphql
+++ b/server/schema.graphql
@@ -788,6 +788,7 @@ type PrivateUserNode implements Node {
   isTeacher: Boolean
   oldClasses(offset: Int, before: String, after: String, first: Int, last: Int, name: String): SchoolClassNodeConnection
   recentModules(offset: Int, before: String, after: String, first: Int, last: Int, recentModules: [ID], orderBy: String): ModuleNodeConnection
+  readOnly: Boolean
 }
 
 type PrivateUserNodeConnection {
diff --git a/server/users/models.py b/server/users/models.py
index 63f90291..67cf299c 100644
--- a/server/users/models.py
+++ b/server/users/models.py
@@ -7,6 +7,7 @@ from django.contrib.auth import get_user_model
 from django.contrib.auth.models import AbstractUser, Permission
 from django.core.exceptions import ObjectDoesNotExist
 from django.db import models
+from django.utils.functional import cached_property
 from django.utils.translation import ugettext_lazy as _
 
 from core.hep_client import HepClient, MYSKILLBOX_LICENSES
@@ -114,6 +115,10 @@ class User(AbstractUser):
     def full_name(self):
         return self.get_full_name()
 
+    @cached_property
+    def read_only(self):
+        return True
+
     class Meta:
         ordering = ['pk', ]
 
diff --git a/server/users/schema.py b/server/users/schema.py
index 1857efcb..328fda70 100644
--- a/server/users/schema.py
+++ b/server/users/schema.py
@@ -88,7 +88,7 @@ class PrivateUserNode(DjangoObjectType):
         filter_fields = ['username', 'email']
         only_fields = ['username', 'email', 'first_name', 'last_name', 'school_classes', 'last_module',
                        'last_topic', 'avatar_url',
-                       'selected_class', 'expiry_date', 'onboarding_visited', 'team']
+                       'selected_class', 'expiry_date', 'onboarding_visited', 'team', 'read_only']
         interfaces = (relay.Node,)
 
     pk = graphene.Int()
@@ -99,6 +99,7 @@ class PrivateUserNode(DjangoObjectType):
     old_classes = DjangoFilterConnectionField(SchoolClassNode)
     recent_modules = DjangoFilterConnectionField(ModuleNode, filterset_class=RecentModuleFilter)
     team = graphene.Field(TeamNode)
+    read_only = graphene.Boolean()
 
     def resolve_pk(self, info, **kwargs):
         return self.id

From 949f65607938a0d3baaedaa9d4263e6b9eb9d939 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Mon, 5 Jul 2021 13:14:03 +0200
Subject: [PATCH 02/11] Make assignments read only in client

---
 .../assignment-read-only.student.spec.js      | 64 +++++++++++++++----
 .../content-blocks/assignment/Assignment.vue  |  1 +
 .../assignment/FinalSubmission.vue            | 28 ++++++--
 .../assignment/SubmissionForm.vue             | 17 +++--
 .../assignment/SubmissionInput.vue            |  5 +-
 5 files changed, 92 insertions(+), 23 deletions(-)

diff --git a/client/cypress/integration/frontend/assignment-read-only.student.spec.js b/client/cypress/integration/frontend/assignment-read-only.student.spec.js
index ec436ecf..35bb2f79 100644
--- a/client/cypress/integration/frontend/assignment-read-only.student.spec.js
+++ b/client/cypress/integration/frontend/assignment-read-only.student.spec.js
@@ -16,7 +16,6 @@ const module = {
               },
               id: 'bla-123',
             },
-
             {
               type: 'assignment',
               value: {
@@ -35,10 +34,11 @@ const module = {
 
 const myText = 'submission text';
 
-const operations = {
+const getOperations = ({final, readOnly}) => ({
   MeQuery: {
     me: {
       onboardingVisited: true,
+      readOnly
     },
   },
   ModuleDetailsQuery: {
@@ -48,13 +48,17 @@ const operations = {
     assignment: {
       submission: {
         text: myText,
-        final: false,
+        final,
         document: '',
         submissionFeedback: null
       },
     },
   },
-};
+});
+
+Cypress.Commands.add('canNotReopen', () => {
+  cy.getByDataCy('final-submission-reopen').should('not.exist');
+});
 
 describe('Assignments read-only - Student', () => {
   beforeEach(() => {
@@ -63,20 +67,58 @@ describe('Assignments read-only - Student', () => {
     cy.task('getSchema').then(schema => {
       cy.mockGraphql({
         schema,
-        mocks,
-        operations,
+        mocks
       });
     });
   });
 
-  it('can not edit', () => {
+  it('can edit and turn in', () => {
+    cy.mockGraphqlOps({
+      operations: getOperations({final: false, readOnly: false})
+    });
     cy.visit('module/module-with-assignment');
 
-    cy.get('.submission-form__textarea').invoke('val').should('contain', myText);
-    cy.getByDataCy('submission-form-submit').should('not.exist');
+    cy.get('.submission-form__textarea').as('textarea');
+
+    cy.get('@textarea').invoke('val').should('contain', myText);
+    cy.get('@textarea').clear().type('Hello');
+    cy.get('@textarea').should('not.have.attr', 'readonly');
+
+    cy.getByDataCy('submission-form-submit').should('exist');
   });
 
-  it('can not turn in', () => {
-    cy.get('.not-implemented');
+  it('can not edit or turn in', () => {
+    cy.mockGraphqlOps({
+      operations: getOperations({final: false, readOnly: true})
+    });
+    cy.visit('module/module-with-assignment');
+
+    cy.get('.submission-form__textarea--readonly').as('textarea');
+
+    cy.get('@textarea').invoke('val').should('contain', myText);
+    cy.get('@textarea').should('have.attr', 'readonly');
+
+    cy.getByDataCy('submission-form-submit').should('not.exist');
+    cy.canNotReopen();
+  });
+
+  it('can revoke turn in', () => {
+    cy.mockGraphqlOps({
+      operations: getOperations({final: true, readOnly: false})
+    });
+
+    cy.visit('module/module-with-assignment');
+    cy.getByDataCy('final-submission').should('exist');
+    cy.getByDataCy('final-submission-reopen').should('exist');
+  });
+
+  it('can not revoke turn in', () => {
+    cy.mockGraphqlOps({
+      operations: getOperations({final: true, readOnly: true})
+    });
+
+    cy.visit('module/module-with-assignment');
+    cy.getByDataCy('final-submission').should('exist');
+    cy.canNotReopen();
   });
 });
diff --git a/client/src/components/content-blocks/assignment/Assignment.vue b/client/src/components/content-blocks/assignment/Assignment.vue
index 87772616..7607b32d 100644
--- a/client/src/components/content-blocks/assignment/Assignment.vue
+++ b/client/src/components/content-blocks/assignment/Assignment.vue
@@ -16,6 +16,7 @@
         :spellcheck-loading="spellcheckLoading"
         :saved="!unsaved"
         :spellcheck="true"
+        :read-only="me.readOnly"
         placeholder="Ergebnis erfassen"
         action="Ergebnis mit Lehrperson teilen"
         shared-msg="Das Ergebnis wurde mit der Lehrperson geteilt."
diff --git a/client/src/components/content-blocks/assignment/FinalSubmission.vue b/client/src/components/content-blocks/assignment/FinalSubmission.vue
index d2d8d55e..107a25a7 100644
--- a/client/src/components/content-blocks/assignment/FinalSubmission.vue
+++ b/client/src/components/content-blocks/assignment/FinalSubmission.vue
@@ -1,5 +1,7 @@
 <template>
-  <div class="final-submission">
+  <div
+    class="final-submission"
+    data-cy="final-submission">
     <document-block
       :value="{url: userInput.document}"
       class="final-submission__document"
@@ -10,6 +12,8 @@
       <span class="final-submission__explanation-text">{{ sharedMsg }}</span>
       <a
         class="final-submission__reopen"
+        data-cy="final-submission-reopen"
+        v-if="showReopen"
         @click="$emit('reopen')">Bearbeiten</a>
     </div>
   </div>
@@ -21,7 +25,20 @@
   import {newLineToParagraph} from '@/helpers/text';
 
   export default {
-    props: ['userInput', 'sharedMsg'],
+    props: {
+      userInput: {
+        type: Object,
+        default: () => ({})
+      },
+      showReopen: {
+        type: Boolean,
+        default: true
+      },
+      sharedMsg: {
+        type: String,
+        default: ''
+      }
+    },
 
     components: {
       InfoIcon,
@@ -37,9 +54,7 @@
 </script>
 
 <style scoped lang="scss">
-  @import "@/styles/_variables.scss";
-  @import "@/styles/_mixins.scss";
-  @import "@/styles/_functions.scss";
+  @import "~styles/helpers";
 
   .final-submission {
     &__text {
@@ -66,18 +81,21 @@
       display: flex;
       align-items: center;
     }
+
     &__explanation-icon {
       width: 40px;
       height: 40px;
       fill: $color-brand;
       margin-right: 8px;
     }
+
     &__explanation-text {
       color: $color-brand;
       font-family: $sans-serif-font-family;
       font-weight: $font-weight-regular;
       margin-right: $medium-spacing;
     }
+
     &__reopen {
       @include small-text;
       cursor: pointer;
diff --git a/client/src/components/content-blocks/assignment/SubmissionForm.vue b/client/src/components/content-blocks/assignment/SubmissionForm.vue
index cb94c2eb..c20dd205 100644
--- a/client/src/components/content-blocks/assignment/SubmissionForm.vue
+++ b/client/src/components/content-blocks/assignment/SubmissionForm.vue
@@ -4,16 +4,15 @@
       <submission-input
         :input-text="userInput.text"
         :saved="saved"
-        :final="final"
+        :readonly="isReadOnly"
         :placeholder="placeholder"
-        :reopen="reopenSubmission"
         @input="saveInput"
       />
     </div>
 
     <div
       class="submission-form-container__actions"
-      v-if="!final">
+      v-if="!isReadOnly">
       <button
         class="submission-form-container__submit button button--primary button--white-bg"
         data-cy="submission-form-submit"
@@ -46,7 +45,8 @@
     <final-submission
       :user-input="userInput"
       :shared-msg="sharedMsg"
-      v-if="final"
+      :show-reopen="!readOnly"
+      v-if="isReadOnly"
       @reopen="$emit('reopen')"/>
   </div>
 </template>
@@ -65,6 +65,10 @@
       action: String,
       reopen: Function,
       document: String,
+      readOnly: {
+        type: Boolean,
+        default: false
+      },
       spellcheck: {
         type: Boolean,
         default: false
@@ -87,6 +91,9 @@
       final() {
         return !!this.userInput && this.userInput.final;
       },
+      isReadOnly() {
+        return this.final || this.readOnly;
+      },
       allowsDocuments() {
         return 'document' in this.userInput;
       },
@@ -118,7 +125,7 @@
 </script>
 
 <style scoped lang="scss">
-  @import '@/styles/_mixins.scss';
+  @import '~styles/helpers';
 
   .submission-form-container {
 
diff --git a/client/src/components/content-blocks/assignment/SubmissionInput.vue b/client/src/components/content-blocks/assignment/SubmissionInput.vue
index b6c3dde4..76e27eb2 100644
--- a/client/src/components/content-blocks/assignment/SubmissionInput.vue
+++ b/client/src/components/content-blocks/assignment/SubmissionInput.vue
@@ -3,8 +3,9 @@
     <textarea
       v-auto-grow
       :placeholder="placeholder"
-      :readonly="final"
+      :readonly="readonly"
       :value="inputText"
+      :class="{'submission-form__textarea--readonly': readonly}"
       rows="1"
       class="submission-form__textarea"
       @input="$emit('input', $event.target.value)"
@@ -30,7 +31,7 @@
     props: {
       inputText: String,
       saved: Boolean,
-      final: Boolean,
+      readonly: Boolean,
       placeholder: {
         type: String,
         default: 'Ergebnis erfassen'

From dc1cb86bb8883c1b54459aed5a1caa438f0606af Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Mon, 5 Jul 2021 18:06:10 +0200
Subject: [PATCH 03/11] Add unit tests

---
 server/assignments/schema/mutations.py        | 13 +++-
 server/assignments/tests/queries/mutations.py | 30 ++++++++
 .../tests/test_assignment_permissions.py      | 20 +-----
 .../test_duplicate_student_submissions.py     | 16 +----
 server/assignments/tests/test_feedback.py     | 22 ++----
 server/assignments/tests/test_read_only.py    | 68 +++++++++++++++++--
 server/core/tests/base_test.py                |  4 ++
 server/users/models.py                        |  1 +
 8 files changed, 117 insertions(+), 57 deletions(-)
 create mode 100644 server/assignments/tests/queries/mutations.py

diff --git a/server/assignments/schema/mutations.py b/server/assignments/schema/mutations.py
index 7bb4c23d..320b6ea8 100644
--- a/server/assignments/schema/mutations.py
+++ b/server/assignments/schema/mutations.py
@@ -23,13 +23,17 @@ class UpdateAssignment(relay.ClientIDMutation):
     def mutate_and_get_payload(cls, root, info, **kwargs):
         assignment_data = kwargs.get('assignment')
         assignment = get_object(Assignment, assignment_data.get('id'))
+        student = info.context.user
+
+        if student.read_only:
+            raise NotImplementedError()
 
         try:
-            (submission, _created) = assignment.submissions.get_or_create(student=info.context.user)
+            (submission, _created) = assignment.submissions.get_or_create(student=student)
         except MultipleObjectsReturned:
-            for submission in assignment.submissions.filter(student=info.context.user):
+            for submission in assignment.submissions.filter(student=student):
                 submission.delete()
-            submission = assignment.submissions.create(student=info.context.user)
+            submission = assignment.submissions.create(student=student)
         submission.text = assignment_data.get('answer', '')
         submission.document = assignment_data.get('document', '')
         final = assignment_data.get('final')
@@ -56,6 +60,9 @@ class UpdateSubmissionFeedback(relay.ClientIDMutation):
         if not user.has_perm('users.can_manage_school_class_content'):
             raise PermissionDenied('Missing permissions')
 
+        if user.read_only:
+            raise NotImplementedError()
+
         (submission_feedback, created) = SubmissionFeedback.objects.get_or_create(teacher=user,
                                                                                   student_submission_id=student_submission_id)
 
diff --git a/server/assignments/tests/queries/mutations.py b/server/assignments/tests/queries/mutations.py
new file mode 100644
index 00000000..2fde0563
--- /dev/null
+++ b/server/assignments/tests/queries/mutations.py
@@ -0,0 +1,30 @@
+UPDATE_ASSIGNMENT_MUTATION = '''
+        mutation UpdateAssignment($input: UpdateAssignmentInput!) {
+          updateAssignment(input: $input){
+            updatedAssignment {
+              id
+              title
+              assignment
+              submission {
+                id
+                text
+                final
+                document
+              }
+            }
+          }
+        }
+
+        '''
+
+UPDATE_SUBMISSION_FEEDBACK_MUTATION = '''
+            mutation UpdateSubmissionFeedback($input: UpdateSubmissionFeedbackInput!) {
+              updateSubmissionFeedback(input: $input){
+                    updatedSubmissionFeedback {
+                        id
+                        text
+                        final
+                    }
+                }
+            }
+        '''
diff --git a/server/assignments/tests/test_assignment_permissions.py b/server/assignments/tests/test_assignment_permissions.py
index 6980c5b0..e2d44214 100644
--- a/server/assignments/tests/test_assignment_permissions.py
+++ b/server/assignments/tests/test_assignment_permissions.py
@@ -2,6 +2,7 @@ from graphql_relay import to_global_id
 
 from api.test_utils import create_client, DefaultUserTestCase
 from assignments.models import Assignment, StudentSubmission
+from .queries.mutations import UPDATE_ASSIGNMENT_MUTATION
 from ..factories import AssignmentFactory
 
 
@@ -16,31 +17,14 @@ class AssignmentPermissionsTestCase(DefaultUserTestCase):
         self.module_id = to_global_id('ModuleNode', self.assignment.module.pk)
 
     def _submit_submission(self, user=None):
-        mutation = '''
-        mutation UpdateAssignment($input: UpdateAssignmentInput!) {
-          updateAssignment(input: $input){
-            updatedAssignment {
-              id
-              title
-              assignment
-              submission {
-                id
-                text
-                final
-                document
-              }
-            }
-          }
-        }
 
-        '''
 
         if user is None:
             client = create_client(self.student1)
         else:
             client = create_client(user)
 
-        return client.execute(mutation, variables={
+        return client.execute(UPDATE_ASSIGNMENT_MUTATION, variables={
             'input': {
                 "assignment": {
                     "id": self.assignment_id,
diff --git a/server/assignments/tests/test_duplicate_student_submissions.py b/server/assignments/tests/test_duplicate_student_submissions.py
index 6c8d8667..09c425dc 100644
--- a/server/assignments/tests/test_duplicate_student_submissions.py
+++ b/server/assignments/tests/test_duplicate_student_submissions.py
@@ -5,24 +5,10 @@ from graphql_relay import to_global_id
 from api.schema import schema
 from assignments.factories import AssignmentFactory
 from assignments.models import StudentSubmission
+from assignments.tests.queries.mutations import UPDATE_ASSIGNMENT_MUTATION
 from users.models import User
 from users.services import create_users
 
-UPDATE_ASSIGNMENT_MUTATION = """
-mutation UpdateAssignment($input: UpdateAssignmentInput!) {
-  updateAssignment(input: $input) {
-    updatedAssignment {      
-      id
-      submission {
-        id
-        text
-        final
-      }
-    }
-  }
-}
-"""
-
 
 class DuplicateStudentSubmissionsTestCase(TestCase):
     def setUp(self):
diff --git a/server/assignments/tests/test_feedback.py b/server/assignments/tests/test_feedback.py
index ff5fd3ac..228c057f 100644
--- a/server/assignments/tests/test_feedback.py
+++ b/server/assignments/tests/test_feedback.py
@@ -12,14 +12,16 @@ from graphql_relay import to_global_id
 
 from api.test_utils import create_client, DefaultUserTestCase
 from assignments.models import Assignment, StudentSubmission
+from core.tests.base_test import SkillboxTestCase
 from users.factories import SchoolClassFactory
 from users.models import SchoolClassMember
+from .queries.mutations import UPDATE_SUBMISSION_FEEDBACK_MUTATION
 from ..factories import AssignmentFactory, StudentSubmissionFactory, SubmissionFeedbackFactory
 
 
-class SubmissionFeedbackTestCase(DefaultUserTestCase):
+class SubmissionFeedbackTestCase(SkillboxTestCase):
     def setUp(self):
-        super(SubmissionFeedbackTestCase, self).setUp()
+        self.createDefault()
 
         self.assignment = AssignmentFactory(
             owner=self.teacher
@@ -38,21 +40,7 @@ class SubmissionFeedbackTestCase(DefaultUserTestCase):
             )
 
     def _create_submission_feedback(self, user, final, text, student_submission_id):
-        mutation = '''
-            mutation UpdateSubmissionFeedback($input: UpdateSubmissionFeedbackInput!) {
-              updateSubmissionFeedback(input: $input){
-                    updatedSubmissionFeedback {
-                        id
-                        text
-                        final
-                    }
-                }
-            }
-        '''
-
-        client = create_client(user)
-
-        return client.execute(mutation, variables={
+        return self.get_client(user).execute(UPDATE_SUBMISSION_FEEDBACK_MUTATION, variables={
             'input': {
                 "submissionFeedback": {
                     "studentSubmission": student_submission_id,
diff --git a/server/assignments/tests/test_read_only.py b/server/assignments/tests/test_read_only.py
index 09f1bfc0..b83685e1 100644
--- a/server/assignments/tests/test_read_only.py
+++ b/server/assignments/tests/test_read_only.py
@@ -1,15 +1,75 @@
+from graphql_relay import to_global_id
+
+from assignments.factories import AssignmentFactory, StudentSubmissionFactory
+from assignments.tests.queries.mutations import UPDATE_ASSIGNMENT_MUTATION, UPDATE_SUBMISSION_FEEDBACK_MUTATION
 from core.tests.base_test import SkillboxTestCase
+from users.models import User
 
 
 class AssignmentReadOnlyTestCase(SkillboxTestCase):
+    def setUp(self) -> None:
+        self.createDefault()
+        self.student = User.objects.get(username='student1')
+        self.assignment = AssignmentFactory()
+        self.assignment_id = to_global_id('AssignmentNode', self.assignment.id)
+
     def test_edit_assignment_fails(self):
-        raise NotImplementedError()
+        variables = {
+            "input": {
+                "assignment": {
+                    "answer": "bla",
+                    "document": "",
+                    "final": False,
+                    "id": self.assignment_id
+                }
+            }
+        }
+        result = self.get_client(self.student).execute(UPDATE_ASSIGNMENT_MUTATION, variables=variables)
+        self.assertIsNotNone(result.get('errors'))
 
     def test_share_assignment_fails(self):
-        raise NotImplementedError()
+        variables = {
+            "input": {
+                "assignment": {
+                    "answer": "bla",
+                    "document": "",
+                    "final": True,
+                    "id": self.assignment_id
+                }
+            }
+        }
+        result = self.get_client(self.student).execute(UPDATE_ASSIGNMENT_MUTATION, variables=variables)
+        self.assertIsNotNone(result.get('errors'))
 
     def test_edit_feedback_fails(self):
-        raise NotImplementedError()
+        student_submission = StudentSubmissionFactory(assignment=self.assignment, student=self.student1,
+                                                           final=True)
+        student_submission_id = to_global_id('StudentSubmissionNode', student_submission.id)
+        result = self.get_client(self.teacher).execute(UPDATE_SUBMISSION_FEEDBACK_MUTATION, variables={
+            'input': {
+                "submissionFeedback": {
+                    "studentSubmission": student_submission_id,
+                    "text": "Feedback",
+                    "final": False
+                }
+            }
+        })
+
+        self.assertIsNotNone(result.get('errors'))
+
 
     def test_share_feedback_fails(self):
-        raise NotImplementedError()
+        student_submission = StudentSubmissionFactory(assignment=self.assignment, student=self.student1,
+                                                           final=True)
+        student_submission_id = to_global_id('StudentSubmissionNode', student_submission.id)
+        result = self.get_client(self.teacher).execute(UPDATE_SUBMISSION_FEEDBACK_MUTATION, variables={
+            'input': {
+                "submissionFeedback": {
+                    "studentSubmission": student_submission_id,
+                    "text": "Feedback",
+                    "final": True
+                }
+            }
+        })
+
+        self.assertIsNotNone(result.get('errors'))
diff --git a/server/core/tests/base_test.py b/server/core/tests/base_test.py
index 5e3d1662..f8300723 100644
--- a/server/core/tests/base_test.py
+++ b/server/core/tests/base_test.py
@@ -10,6 +10,10 @@ class SkillboxTestCase(TestCase):
     def createDefault(self) -> None:
         create_users()
         self.teacher = User.objects.get(username='teacher')
+        self.teacher2 = User.objects.get(username='teacher2')
+        self.student1 = User.objects.get(username='student1')
+        self.student2 = User.objects.get(username='student2')
+        self.student_second_class = User.objects.get(username='student_second_class')
 
     def get_client(self, user=None) -> Client:
         request = RequestFactory().get('/')
diff --git a/server/users/models.py b/server/users/models.py
index 67cf299c..27226e30 100644
--- a/server/users/models.py
+++ b/server/users/models.py
@@ -117,6 +117,7 @@ class User(AbstractUser):
 
     @cached_property
     def read_only(self):
+        # todo: just mocked for now, link to license before release
         return True
 
     class Meta:

From 249abff36b0ce0476d3cdaea7fd8a43ba64292c2 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Tue, 6 Jul 2021 15:09:51 +0200
Subject: [PATCH 04/11] Add license check to user model

---
 server/users/models.py                     | 12 ++++++++++
 server/users/tests/test_license_expired.py | 26 ++++++++++++++++++++++
 2 files changed, 38 insertions(+)
 create mode 100644 server/users/tests/test_license_expired.py

diff --git a/server/users/models.py b/server/users/models.py
index 27226e30..310887e9 100644
--- a/server/users/models.py
+++ b/server/users/models.py
@@ -17,6 +17,10 @@ DEFAULT_SCHOOL_ID = 1
 
 
 class User(AbstractUser):
+    LICENSE_NONE = 'no-license'
+    LICENSE_VALID = 'valid-license'
+    LICENSE_EXPIRED = 'expired-license'
+
     last_module = models.ForeignKey('books.Module', related_name='+', on_delete=models.SET_NULL, null=True)
     recent_modules = models.ManyToManyField('books.Module', related_name='+', through='books.RecentModule')
     last_topic = models.ForeignKey('books.Topic', related_name='+', on_delete=models.SET_NULL, null=True)
@@ -120,6 +124,14 @@ class User(AbstractUser):
         # todo: just mocked for now, link to license before release
         return True
 
+    def get_license_status(self):
+        if not self.license_expiry_date:
+            return User.LICENSE_NONE
+        now = datetime.now()
+        if self.license_expiry_date >= now:
+            return User.LICENSE_VALID
+        return User.LICENSE_NONE
+
     class Meta:
         ordering = ['pk', ]
 
diff --git a/server/users/tests/test_license_expired.py b/server/users/tests/test_license_expired.py
new file mode 100644
index 00000000..82222ddf
--- /dev/null
+++ b/server/users/tests/test_license_expired.py
@@ -0,0 +1,26 @@
+from datetime import timedelta, datetime
+
+from core.factories import UserFactory
+from core.tests.base_test import SkillboxTestCase
+from users.models import User
+
+
+class LicenseExpiredTestCase(SkillboxTestCase):
+    def setUp(self) -> None:
+        self.user = UserFactory(username='some_user')
+
+    def test_license_expired(self):
+
+        now = datetime.now()
+        self.user.license_expiry_date = now - timedelta(days=1)
+        self.user.save()
+        self.assertTrue(self.user.get_license_status(), User.LICENSE_EXPIRED)
+
+    def test_license_valid(self):
+        now = datetime.now()
+        self.user.license_expiry_date = now + timedelta(days=1)
+        self.user.save()
+        self.assertTrue(self.user.get_license_status(), User.LICENSE_VALID)
+
+    def test_license_none(self):
+        self.assertTrue(self.user.get_license_status(), User.LICENSE_NONE)

From 71bd9f6d14a10aaed681eddd62b1735b4bbe2d6c Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Tue, 6 Jul 2021 15:41:02 +0200
Subject: [PATCH 05/11] Update readonly property on user

---
 .../src/components/content-forms/AssignmentForm.vue |  2 +-
 server/assignments/tests/test_read_only.py          | 13 ++++++++++---
 server/users/models.py                              | 12 +++++-------
 3 files changed, 16 insertions(+), 11 deletions(-)

diff --git a/client/src/components/content-forms/AssignmentForm.vue b/client/src/components/content-forms/AssignmentForm.vue
index 13020768..6a13e5df 100644
--- a/client/src/components/content-forms/AssignmentForm.vue
+++ b/client/src/components/content-forms/AssignmentForm.vue
@@ -31,7 +31,7 @@
   };
 </script>
 <style scoped lang="scss">
-  @import "@/styles/_variables.scss";
+  @import "~styles/helpers";
 
   .assignment-form {
     display: grid;
diff --git a/server/assignments/tests/test_read_only.py b/server/assignments/tests/test_read_only.py
index b83685e1..5a2f087e 100644
--- a/server/assignments/tests/test_read_only.py
+++ b/server/assignments/tests/test_read_only.py
@@ -1,3 +1,5 @@
+from datetime import timedelta, datetime
+
 from graphql_relay import to_global_id
 
 from assignments.factories import AssignmentFactory, StudentSubmissionFactory
@@ -9,7 +11,12 @@ from users.models import User
 class AssignmentReadOnlyTestCase(SkillboxTestCase):
     def setUp(self) -> None:
         self.createDefault()
-        self.student = User.objects.get(username='student1')
+        yesterday = datetime.now() - timedelta(days=1)
+
+        self.student1.license_expiry_date = yesterday
+        self.student1.save()
+        self.teacher.license_expiry_date = yesterday
+        self.teacher.save()
         self.assignment = AssignmentFactory()
         self.assignment_id = to_global_id('AssignmentNode', self.assignment.id)
 
@@ -24,7 +31,7 @@ class AssignmentReadOnlyTestCase(SkillboxTestCase):
                 }
             }
         }
-        result = self.get_client(self.student).execute(UPDATE_ASSIGNMENT_MUTATION, variables=variables)
+        result = self.get_client(self.student1).execute(UPDATE_ASSIGNMENT_MUTATION, variables=variables)
         self.assertIsNotNone(result.get('errors'))
 
     def test_share_assignment_fails(self):
@@ -38,7 +45,7 @@ class AssignmentReadOnlyTestCase(SkillboxTestCase):
                 }
             }
         }
-        result = self.get_client(self.student).execute(UPDATE_ASSIGNMENT_MUTATION, variables=variables)
+        result = self.get_client(self.student1).execute(UPDATE_ASSIGNMENT_MUTATION, variables=variables)
         self.assertIsNotNone(result.get('errors'))
 
     def test_edit_feedback_fails(self):
diff --git a/server/users/models.py b/server/users/models.py
index 310887e9..b4b70f65 100644
--- a/server/users/models.py
+++ b/server/users/models.py
@@ -119,18 +119,16 @@ class User(AbstractUser):
     def full_name(self):
         return self.get_full_name()
 
-    @cached_property
+    @property
     def read_only(self):
-        # todo: just mocked for now, link to license before release
-        return True
+        return self.get_license_status() == User.LICENSE_EXPIRED
 
     def get_license_status(self):
-        if not self.license_expiry_date:
+        if self.license_expiry_date is None:
             return User.LICENSE_NONE
-        now = datetime.now()
-        if self.license_expiry_date >= now:
+        if self.license_expiry_date >= datetime.now():
             return User.LICENSE_VALID
-        return User.LICENSE_NONE
+        return User.LICENSE_EXPIRED
 
     class Meta:
         ordering = ['pk', ]

From bd15c9710d1f27ccb8fc4fe914c1d13717021420 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Tue, 6 Jul 2021 16:41:38 +0200
Subject: [PATCH 06/11] Allow users with expired license to access the private
 API

---
 server/assignments/tests/test_read_only.py |  4 ++--
 server/core/tests/test_middleware.py       | 10 +++++++++-
 server/core/utils.py                       |  2 +-
 server/users/models.py                     |  4 ++--
 server/users/tests/test_license_expired.py |  9 +++------
 5 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/server/assignments/tests/test_read_only.py b/server/assignments/tests/test_read_only.py
index 5a2f087e..b85051fe 100644
--- a/server/assignments/tests/test_read_only.py
+++ b/server/assignments/tests/test_read_only.py
@@ -1,4 +1,4 @@
-from datetime import timedelta, datetime
+from datetime import timedelta, date
 
 from graphql_relay import to_global_id
 
@@ -11,7 +11,7 @@ from users.models import User
 class AssignmentReadOnlyTestCase(SkillboxTestCase):
     def setUp(self) -> None:
         self.createDefault()
-        yesterday = datetime.now() - timedelta(days=1)
+        yesterday = date.today() - timedelta(days=1)
 
         self.student1.license_expiry_date = yesterday
         self.student1.save()
diff --git a/server/core/tests/test_middleware.py b/server/core/tests/test_middleware.py
index c8126045..095b0f5a 100644
--- a/server/core/tests/test_middleware.py
+++ b/server/core/tests/test_middleware.py
@@ -18,7 +18,7 @@ class MiddlewareTestCase(TestCase):
 
         self.assertTrue(is_private_api_call_allowed(user, body))
 
-    def test_user_without_valid_license_cannot_see_private_api(self):
+    def test_user_with_expired_license_can_see_private_api(self):
 
         yesterday = timezone.now() - timedelta(1)
         user = UserFactory(username='aschiman@ch.ch', hep_id=23)
@@ -26,6 +26,14 @@ class MiddlewareTestCase(TestCase):
 
         body = b'"{mutation {\\n addRoom}"'
 
+        self.assertTrue(is_private_api_call_allowed(user, body))
+
+    def test_user_without_valid_license_cannot_see_private_api(self):
+        user = UserFactory(username='aschiman@ch.ch', hep_id=23)
+        user.license_expiry_date = None
+
+        body = b'"{mutation {\\n addRoom}"'
+
         self.assertFalse(is_private_api_call_allowed(user, body))
 
     def test_logout_is_allowed_without_valid_license(self):
diff --git a/server/core/utils.py b/server/core/utils.py
index 5cfb4abd..1d4b7405 100644
--- a/server/core/utils.py
+++ b/server/core/utils.py
@@ -44,7 +44,7 @@ def is_private_api_call_allowed(user, body):
     license_expiry = user.license_expiry_date
 
     # all other resources are denied if the license is not valid
-    if license_expiry is None or license_expiry < timezone.now().date():
+    if license_expiry is None:
         return False
 
     return True
diff --git a/server/users/models.py b/server/users/models.py
index b4b70f65..c54c6a2a 100644
--- a/server/users/models.py
+++ b/server/users/models.py
@@ -1,7 +1,7 @@
 import random
 import re
 import string
-from datetime import datetime
+from datetime import date
 
 from django.contrib.auth import get_user_model
 from django.contrib.auth.models import AbstractUser, Permission
@@ -126,7 +126,7 @@ class User(AbstractUser):
     def get_license_status(self):
         if self.license_expiry_date is None:
             return User.LICENSE_NONE
-        if self.license_expiry_date >= datetime.now():
+        if self.license_expiry_date >= date.today():
             return User.LICENSE_VALID
         return User.LICENSE_EXPIRED
 
diff --git a/server/users/tests/test_license_expired.py b/server/users/tests/test_license_expired.py
index 82222ddf..88461431 100644
--- a/server/users/tests/test_license_expired.py
+++ b/server/users/tests/test_license_expired.py
@@ -1,4 +1,4 @@
-from datetime import timedelta, datetime
+from datetime import timedelta, date
 
 from core.factories import UserFactory
 from core.tests.base_test import SkillboxTestCase
@@ -10,15 +10,12 @@ class LicenseExpiredTestCase(SkillboxTestCase):
         self.user = UserFactory(username='some_user')
 
     def test_license_expired(self):
-
-        now = datetime.now()
-        self.user.license_expiry_date = now - timedelta(days=1)
+        self.user.license_expiry_date = date.today() - timedelta(days=1)
         self.user.save()
         self.assertTrue(self.user.get_license_status(), User.LICENSE_EXPIRED)
 
     def test_license_valid(self):
-        now = datetime.now()
-        self.user.license_expiry_date = now + timedelta(days=1)
+        self.user.license_expiry_date = date.today() + timedelta(days=1)
         self.user.save()
         self.assertTrue(self.user.get_license_status(), User.LICENSE_VALID)
 

From b369f665c38b5bc92fe7f92e3edf4d1e9d0513d7 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Tue, 6 Jul 2021 17:29:39 +0200
Subject: [PATCH 07/11] Implement frontend tests for assignment read only mode

---
 ...ignment-feedback-read-only.teacher.spec.js | 68 +++++++++++++++++--
 .../assignment-read-only.student.spec.js      | 15 +---
 client/cypress/support/commands.js            | 30 ++++++--
 client/cypress/support/index.d.ts             |  4 ++
 client/src/pages/studentSubmission.vue        |  5 ++
 5 files changed, 100 insertions(+), 22 deletions(-)

diff --git a/client/cypress/integration/frontend/assignment-feedback-read-only.teacher.spec.js b/client/cypress/integration/frontend/assignment-feedback-read-only.teacher.spec.js
index bbfcaf07..2a799e78 100644
--- a/client/cypress/integration/frontend/assignment-feedback-read-only.teacher.spec.js
+++ b/client/cypress/integration/frontend/assignment-feedback-read-only.teacher.spec.js
@@ -1,8 +1,68 @@
+import mocks from '../../fixtures/mocks';
+
+const myText = 'Mein Feedback';
+
+const getOperations = ({readOnly}) => ({
+  MeQuery: {
+    me: {
+      onboardingVisited: true,
+      readOnly,
+    },
+  },
+  StudentSubmissions: {
+    studentSubmission: {
+      id: 'id',
+      text: 'Submission Text',
+      document: '',
+      student: {
+        firstName: 'Peter',
+        lastName: 'Student',
+      },
+      assignment: {
+        title: 'Assignment Title',
+        assignment: 'Assignment Text',
+      },
+      submissionFeedback: {
+        id: 'feedback-id',
+        text: myText,
+        final: true,
+      },
+    },
+  },
+});
+
 describe('Assignment feedback read-only - Teacher', () => {
-  it('can not edit', () => {
-    cy.get('.not-implemented');
+  beforeEach(() => {
+    cy.fakeLogin('nico.teacher', 'test');
+    cy.server();
+    cy.task('getSchema').then(schema => {
+      cy.mockGraphql({
+        schema,
+        mocks,
+      });
+    });
   });
-  it('can not share', () => {
-    cy.get('.not-implemented');
+
+  it('can not edit', () => {
+    cy.mockGraphqlOps({
+      operations: getOperations({readOnly: true}),
+    });
+
+    cy.visit('submission/submission-id');
+    // cy.get('.submission-form__textarea--readonly').as('textarea');
+    //
+    // cy.get('@textarea').invoke('val').should('contain', myText);
+    // cy.get('@textarea').should('have.attr', 'readonly');
+
+    cy.isSubmissionReadOnly(myText);
+    cy.canReopen(false);
+  });
+  it('can edit', () => {
+    cy.mockGraphqlOps({
+      operations: getOperations({readOnly: false}),
+    });
+
+    cy.visit('submission/submission-id');
+    cy.canReopen(false);
   });
 });
diff --git a/client/cypress/integration/frontend/assignment-read-only.student.spec.js b/client/cypress/integration/frontend/assignment-read-only.student.spec.js
index 35bb2f79..49b7b4e7 100644
--- a/client/cypress/integration/frontend/assignment-read-only.student.spec.js
+++ b/client/cypress/integration/frontend/assignment-read-only.student.spec.js
@@ -56,10 +56,6 @@ const getOperations = ({final, readOnly}) => ({
   },
 });
 
-Cypress.Commands.add('canNotReopen', () => {
-  cy.getByDataCy('final-submission-reopen').should('not.exist');
-});
-
 describe('Assignments read-only - Student', () => {
   beforeEach(() => {
     cy.fakeLogin('rahel.cueni', 'test');
@@ -93,13 +89,8 @@ describe('Assignments read-only - Student', () => {
     });
     cy.visit('module/module-with-assignment');
 
-    cy.get('.submission-form__textarea--readonly').as('textarea');
-
-    cy.get('@textarea').invoke('val').should('contain', myText);
-    cy.get('@textarea').should('have.attr', 'readonly');
-
-    cy.getByDataCy('submission-form-submit').should('not.exist');
-    cy.canNotReopen();
+    cy.isSubmissionReadOnly(myText);
+    cy.canReopen(false);
   });
 
   it('can revoke turn in', () => {
@@ -119,6 +110,6 @@ describe('Assignments read-only - Student', () => {
 
     cy.visit('module/module-with-assignment');
     cy.getByDataCy('final-submission').should('exist');
-    cy.canNotReopen();
+    cy.canReopen(false);
   });
 });
diff --git a/client/cypress/support/commands.js b/client/cypress/support/commands.js
index 4c44718d..fff6bf2e 100644
--- a/client/cypress/support/commands.js
+++ b/client/cypress/support/commands.js
@@ -35,16 +35,16 @@ Cypress.Commands.add('apolloLogin', (username, password) => {
     'variables': {
       'input': {
         'usernameInput': username,
-        'passwordInput': password
-      }
+        'passwordInput': password,
+      },
     },
-    'query': 'mutation BetaLogin($input: BetaLoginInput!) {\n  betaLogin(input: $input) {\n    success\n    __typename\n  }\n}\n'
+    'query': 'mutation BetaLogin($input: BetaLoginInput!) {\n  betaLogin(input: $input) {\n    success\n    __typename\n  }\n}\n',
   };
 
   cy.request({
     method: 'POST',
     url: '/api/graphql-public/',
-    body: payload
+    body: payload,
   });
 });
 
@@ -78,8 +78,8 @@ Cypress.Commands.add('loginByCsrf', (username, password, csrftoken) => {
     body: {
       username: username,
       password: password,
-      csrfmiddlewaretoken: csrftoken
-    }
+      csrfmiddlewaretoken: csrftoken,
+    },
   });
 });
 
@@ -189,3 +189,21 @@ Cypress.Commands.add('fakeLogin', () => {
   cy.log('Logging in (fake)');
   cy.setCookie('loginStatus', 'true');
 });
+
+Cypress.Commands.add('canReopen', (exists) => {
+  let check;
+  if (exists) {
+    check = 'exist';
+  } else {
+    check = 'not.exist';
+  }
+  cy.getByDataCy('final-submission-reopen').should(check);
+});
+
+Cypress.Commands.add('isSubmissionReadOnly', (myText) => {
+  cy.get('.submission-form__textarea--readonly').as('textarea');
+
+  cy.get('@textarea').invoke('val').should('contain', myText);
+  cy.get('@textarea').should('have.attr', 'readonly');
+  cy.getByDataCy('submission-form-submit').should('not.exist');
+});
diff --git a/client/cypress/support/index.d.ts b/client/cypress/support/index.d.ts
index 3dd7fd92..502c8c82 100644
--- a/client/cypress/support/index.d.ts
+++ b/client/cypress/support/index.d.ts
@@ -23,5 +23,9 @@ declare namespace Cypress {
     login(username: string, password: string, visitLogin?: boolean): void
 
     fakeLogin(username: string, password: string): void
+
+    canReopen(exists: boolean): void
+
+    isSubmissionReadOnly(myText: string): void
   }
 }
diff --git a/client/src/pages/studentSubmission.vue b/client/src/pages/studentSubmission.vue
index f14b8d76..1276ea7a 100644
--- a/client/src/pages/studentSubmission.vue
+++ b/client/src/pages/studentSubmission.vue
@@ -22,6 +22,7 @@
       <submission-form
         :user-input="feedback"
         :saved="!unsaved"
+        :read-only="me.readOnly"
         placeholder="Feedback erfassen"
         action="Feedback teilen"
         shared-msg="Dieses Feedback wurde geteilt."
@@ -55,7 +56,11 @@
   import UPDATE_FEEDBACK_WITH_TEXT_MUTATION from '@/graphql/gql/mutations/updateFeedbackWithText.gql';
   import SubmissionForm from '@/components/content-blocks/assignment/SubmissionForm';
 
+  import me from '@/mixins/me';
+
   export default {
+
+    mixins: [me],
     components: {
       StudentSubmissionDocument,
       SubmissionForm

From cfaa5c9a4f7cfa5fa3a774ff7fb488b43d52c282 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Tue, 6 Jul 2021 17:49:03 +0200
Subject: [PATCH 08/11] Re-add missing import

---
 server/users/models.py           |  2 +-
 server/users/tests/test_login.py | 11 -----------
 2 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/server/users/models.py b/server/users/models.py
index c54c6a2a..4caef06c 100644
--- a/server/users/models.py
+++ b/server/users/models.py
@@ -1,7 +1,7 @@
 import random
 import re
 import string
-from datetime import date
+from datetime import date, datetime
 
 from django.contrib.auth import get_user_model
 from django.contrib.auth.models import AbstractUser, Permission
diff --git a/server/users/tests/test_login.py b/server/users/tests/test_login.py
index d62ecac4..07ec11a5 100644
--- a/server/users/tests/test_login.py
+++ b/server/users/tests/test_login.py
@@ -1,14 +1,3 @@
-# -*- coding: utf-8 -*-
-#
-# ITerativ GmbH
-# http://www.iterativ.ch/
-#
-# Copyright (c) 2019 ITerativ GmbH. All rights reserved.
-#
-# Created on 2019-10-02
-# @author: chrigu <christian.cueni@iterativ.ch>
-import json
-import os
 from datetime import timedelta
 from unittest.mock import patch
 

From 0ae9ccaa68026b743f5443b35475a83eec5b85cb Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Tue, 6 Jul 2021 20:37:52 +0200
Subject: [PATCH 09/11] Update exception

---
 client/src/pages/studentSubmission.vue | 103 +++++++++++++------------
 server/assignments/schema/mutations.py |   4 +-
 server/users/models.py                 |   1 -
 3 files changed, 54 insertions(+), 54 deletions(-)

diff --git a/client/src/pages/studentSubmission.vue b/client/src/pages/studentSubmission.vue
index 1276ea7a..fe1f2aa3 100644
--- a/client/src/pages/studentSubmission.vue
+++ b/client/src/pages/studentSubmission.vue
@@ -22,7 +22,7 @@
       <submission-form
         :user-input="feedback"
         :saved="!unsaved"
-        :read-only="me.readOnly"
+        :read-only="readOnly"
         placeholder="Feedback erfassen"
         action="Feedback teilen"
         shared-msg="Dieses Feedback wurde geteilt."
@@ -63,29 +63,29 @@
     mixins: [me],
     components: {
       StudentSubmissionDocument,
-      SubmissionForm
+      SubmissionForm,
     },
 
     data() {
       return {
         studentSubmission: {
           assignment: {
-            title: ''
+            title: '',
           },
           student: {
             firstName: '',
-            lastName: ''
+            lastName: '',
           },
           text: '',
           document: '',
           submissionFeedback: {
             text: '',
-            final: false
-          }
+            final: false,
+          },
         },
         unsaved: false,
         saving: 0,
-        emojis: ['👍', '👎', '🙂', '😐', '😕', '🙁', '😮', '😉', '🙄', '❕', '❔', '🧐', '🤩', '🤗', '🤬', '🤢']
+        emojis: ['👍', '👎', '🙂', '😐', '😕', '🙁', '😮', '😉', '🙄', '❕', '❔', '🧐', '🤩', '🤗', '🤬', '🤢'],
       };
     },
 
@@ -102,8 +102,11 @@
       feedback() {
         return this.studentSubmission.submissionFeedback ? this.studentSubmission.submissionFeedback : {
           text: '',
-          final: false
+          final: false,
         };
+      },
+      readOnly() {
+        return this.me.readOnly;
       }
     },
 
@@ -113,7 +116,7 @@
           query: STUDENT_SUBMISSIONS_QUERY,
           variables() {
             return {
-              id: this.$route.params.id
+              id: this.$route.params.id,
             };
           },
           result({data: {studentSubmission}}) {
@@ -121,7 +124,7 @@
               this.create();
             }
             this.studentSubmission = cloneDeep(studentSubmission); // we don't want to update the value when the server updates
-          }
+          },
         };
       },
     },
@@ -140,10 +143,10 @@
               submissionFeedback: {
                 studentSubmission: this.studentSubmission.id,
                 text: this.studentSubmission.submissionFeedback.text,
-              }
-            }
+              },
+            },
           },
-          update: this.updateCache
+          update: this.updateCache,
         }).then(() => {
           this.saving--;
           if (this.saving === 0) {
@@ -160,53 +163,52 @@
         this.updateFeedbackText(feedbackText);
         this._save();
       },
-      create() {
+      update({withText, text, final}) {
+        if (this.readOnly) {
+          this.$log.debug('read-only');
+          return;
+        }
+        let mutation = withText ? UPDATE_FEEDBACK_WITH_TEXT_MUTATION : UPDATE_FEEDBACK_MUTATION;
         this.$apollo.mutate({
-          mutation: UPDATE_FEEDBACK_WITH_TEXT_MUTATION,
+          mutation,
           variables: {
             input: {
               submissionFeedback: {
                 studentSubmission: this.studentSubmission.id,
-                text: '',
-                final: false
-              }
-            }
+                text: text,
+                final: final,
+              },
+            },
           },
-          update: this.updateCache
+          update: this.updateCache,
+        });
+      },
+      create() {
+        this.$log.debug('create');
+        this.update({
+          withText: true,
+          text: '',
+          final: false,
         });
       },
       turnIn() {
-        this.$apollo.mutate({
-          mutation: UPDATE_FEEDBACK_WITH_TEXT_MUTATION,
-          variables: {
-            input: {
-              submissionFeedback: {
-                studentSubmission: this.studentSubmission.id,
-                text: this.studentSubmission.submissionFeedback.text,
-                final: true
-              }
-            }
-          },
-          update: this.updateCache
+        this.$log.debug('turnIn');
+        this.update({
+          withText: true,
+          text: this.studentSubmission.submissionFeedback.text,
+          final: true,
         });
       },
       reopen() {
+        this.$log.debug('reopen');
         if (!this.studentSubmission.id) {
           return;
         }
 
-        this.$apollo.mutate({
-          mutation: UPDATE_FEEDBACK_MUTATION,
-          variables: {
-            input: {
-              submissionFeedback: {
-                studentSubmission: this.studentSubmission.id,
-                text: this.studentSubmission.submissionFeedback.text,
-                final: false
-              }
-            }
-          },
-          update: this.updateCache
+        this.update({
+          withText: false,
+          text: this.studentSubmission.submissionFeedback.text,
+          final: false,
         });
       },
       updateCache(store, {data: {updateSubmissionFeedback: {successful, updatedSubmissionFeedback}}}) {
@@ -214,20 +216,20 @@
           if (successful) {
             const query = STUDENT_SUBMISSIONS_QUERY;
             const variables = {
-              id: this.studentSubmission.id
+              id: this.studentSubmission.id,
             };
             const data = store.readQuery({query, variables});
 
             if (data) {
               if (!data.studentSubmission.submissionFeedback) {
                 data.studentSubmission.submissionFeedback = {
-                  '__typename': 'SubmissionFeedbackNode'
+                  '__typename': 'SubmissionFeedbackNode',
                 };
               }
 
               data.studentSubmission.submissionFeedback = Object.assign({}, data.studentSubmission.submissionFeedback, {
                 id: updatedSubmissionFeedback.id,
-                final: updatedSubmissionFeedback.final
+                final: updatedSubmissionFeedback.final,
               });
 
               if (updatedSubmissionFeedback.text !== undefined) {
@@ -247,16 +249,15 @@
       },
       updateFeedbackText(text) {
         this.studentSubmission = Object.assign({}, this.studentSubmission, {
-          submissionFeedback: Object.assign({}, this.studentSubmission.submissionFeedback, {text: text})
+          submissionFeedback: Object.assign({}, this.studentSubmission.submissionFeedback, {text: text}),
         });
-      }
+      },
     },
   };
 </script>
 
 <style scoped lang="scss">
-  @import "@/styles/_variables.scss";
-  @import "@/styles/_functions.scss";
+  @import "~styles/helpers";
 
   .submission-page {
     &__content {
diff --git a/server/assignments/schema/mutations.py b/server/assignments/schema/mutations.py
index 320b6ea8..9794f4f9 100644
--- a/server/assignments/schema/mutations.py
+++ b/server/assignments/schema/mutations.py
@@ -26,7 +26,7 @@ class UpdateAssignment(relay.ClientIDMutation):
         student = info.context.user
 
         if student.read_only:
-            raise NotImplementedError()
+            raise PermissionError('No valid license')
 
         try:
             (submission, _created) = assignment.submissions.get_or_create(student=student)
@@ -61,7 +61,7 @@ class UpdateSubmissionFeedback(relay.ClientIDMutation):
             raise PermissionDenied('Missing permissions')
 
         if user.read_only:
-            raise NotImplementedError()
+            raise PermissionError('No valid license')
 
         (submission_feedback, created) = SubmissionFeedback.objects.get_or_create(teacher=user,
                                                                                   student_submission_id=student_submission_id)
diff --git a/server/users/models.py b/server/users/models.py
index 4caef06c..5b9a5db7 100644
--- a/server/users/models.py
+++ b/server/users/models.py
@@ -7,7 +7,6 @@ from django.contrib.auth import get_user_model
 from django.contrib.auth.models import AbstractUser, Permission
 from django.core.exceptions import ObjectDoesNotExist
 from django.db import models
-from django.utils.functional import cached_property
 from django.utils.translation import ugettext_lazy as _
 
 from core.hep_client import HepClient, MYSKILLBOX_LICENSES

From 7d5fd5cff6b0c73480381979ecf224b03bfd23e4 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Wed, 7 Jul 2021 11:41:34 +0200
Subject: [PATCH 10/11] Prettify code

---
 client/cypress/support/commands.js | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/client/cypress/support/commands.js b/client/cypress/support/commands.js
index fff6bf2e..e2cb5bd8 100644
--- a/client/cypress/support/commands.js
+++ b/client/cypress/support/commands.js
@@ -191,12 +191,7 @@ Cypress.Commands.add('fakeLogin', () => {
 });
 
 Cypress.Commands.add('canReopen', (exists) => {
-  let check;
-  if (exists) {
-    check = 'exist';
-  } else {
-    check = 'not.exist';
-  }
+  let check = exists ? 'exist' : 'not.exist';
   cy.getByDataCy('final-submission-reopen').should(check);
 });
 

From 1d66cc86beff83dacaa2490264379585973c9c42 Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Wed, 7 Jul 2021 16:02:12 +0200
Subject: [PATCH 11/11] Fix naming

---
 .../components/content-blocks/assignment/SubmissionForm.vue   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/client/src/components/content-blocks/assignment/SubmissionForm.vue b/client/src/components/content-blocks/assignment/SubmissionForm.vue
index c20dd205..008a49f9 100644
--- a/client/src/components/content-blocks/assignment/SubmissionForm.vue
+++ b/client/src/components/content-blocks/assignment/SubmissionForm.vue
@@ -46,7 +46,7 @@
       :user-input="userInput"
       :shared-msg="sharedMsg"
       :show-reopen="!readOnly"
-      v-if="isReadOnly"
+      v-if="isFinalOrReadOnly"
       @reopen="$emit('reopen')"/>
   </div>
 </template>
@@ -91,7 +91,7 @@
       final() {
         return !!this.userInput && this.userInput.final;
       },
-      isReadOnly() {
+      isFinalOrReadOnly() {
         return this.final || this.readOnly;
       },
       allowsDocuments() {