Commit Graph

3623 Commits

Author SHA1 Message Date
Ramon Wenger 2d46eedac1 Update client code to reflect highlight change
Add first highlight code to the instrument page
2024-02-28 11:14:45 +01:00
Ramon Wenger b329427df8 Refactor highlight model to use a generic page instead of a content
block
2024-02-28 11:14:45 +01:00
Ramon Wenger 238be6cf4f Add a unit test file for highlight mutations
Contains a first test for creation
2024-02-28 11:14:45 +01:00
Ramon Wenger 7cf192f132 Refactor schema definitions to use less direct imports
This prevents some circular import issues
2024-02-28 11:14:45 +01:00
Ramon Wenger afc415dc8a Add test for instrument highlights 2024-02-28 11:14:45 +01:00
Ramon Wenger 69987e369c Migrate instrument page to use setup syntax and new graphql style 2024-02-28 11:14:45 +01:00
Ramon Wenger 376f2c5f82 Add URL parsing to the HighlightSidebar component
Resolves MS-881 #Complete
2024-02-28 11:14:45 +01:00
Ramon Wenger f0018e2e56 Make note read-only after saving
Resolves MS-880 #Complete
2024-02-28 11:14:45 +01:00
Ramon Wenger 4c42a152fb Switch Popover after Highlight is created
Fixes MS-878 #Complete
2024-02-28 11:14:45 +01:00
Ramon Wenger 9905d32b7b Prevent nested ContentBlocks to also open a HighlightPopover
Also add a Testcase for them

Relates to MS-879
2024-02-28 11:14:45 +01:00
Ramon Wenger 5789e9cc6f Refactor some test code and fix small errors 2024-02-28 11:14:45 +01:00
Ramon Wenger 8afe36e8ea Add cypress test for highlights 2024-02-28 11:14:45 +01:00
Ramon Wenger 91dcf3cb20 Refactor confirm modals 2024-02-28 11:14:45 +01:00
Ramon Wenger c32864203e Fix type issue 2024-02-28 11:14:45 +01:00
Ramon Wenger c9746769ab Add an initial implementation of a confirm modal for deleting highlights
Relates to MS-871
2024-02-28 11:14:45 +01:00
Ramon Wenger ef3d8ac2e7 Fix some linting issues 2024-02-28 11:14:45 +01:00
Ramon Wenger 837fcc81be Handle choosing a color and clicking on the note icon differently
Resolves MS-869 and MS870 #Complete
2024-02-28 11:14:45 +01:00
Ramon Wenger f69af1e4cf Refactor directive to be more specific 2024-02-28 11:14:45 +01:00
Ramon Wenger 9b813f113b Refactor some mutations 2024-02-28 11:14:45 +01:00
Ramon Wenger 8506392c3f Handle highlight sidebar and popover as one unit for closing them when
clicking elsewhere

Resolves MS-867 and MS-868 #Complete
2024-02-28 11:14:45 +01:00
Ramon Wenger 2f6589680e Update the color in the sidebar when changing it in the popover
Resolves MS-866 #Complete
2024-02-28 11:14:45 +01:00
Ramon Wenger 2121f01a9c Make the highlight selection and the marking more robust
Also cover the case when there are paragraphs and unordered lists in the
same ContentComponent
2024-02-28 11:14:45 +01:00
Ramon Wenger 8ef3f23edc Complete highlights for list items 2024-02-28 11:14:45 +01:00
Ramon Wenger 4464b56cbb Start work to also enable highlighting for list items 2024-02-28 11:14:45 +01:00
Ramon Wenger 56b973f02e Add highlights to nested content content-blocks
Also refactor the ContentListBlock component
2024-02-28 11:14:45 +01:00
Ramon Wenger 6a70d3ca9e Fix linting issue 2024-02-28 11:14:45 +01:00
Ramon Wenger 8b22146c63 Update highlight fragment 2024-02-28 11:14:45 +01:00
Ramon Wenger f2c9ec04b8 Add delete mutation, flesh out update mutation for highlights 2024-02-28 11:14:45 +01:00
Ramon Wenger f7d083e66a Refactor graphql config 2024-02-28 11:14:45 +01:00
Ramon Wenger 97dd9ef600 Make highlight sidebar a singleton 2024-02-28 11:14:45 +01:00
Ramon Wenger bf71faae3f Add Update Highlight mutation stub 2024-02-28 11:14:45 +01:00
Ramon Wenger 5ae1296949 Remove highlight directive 2024-02-28 11:14:45 +01:00
Ramon Wenger 57cac25c6f Add highlight content to sidebar 2024-02-28 11:14:45 +01:00
Ramon Wenger f905d6bbc0 Remove debugging info, clean up UI in HighlightSidebar 2024-02-28 11:14:45 +01:00
Ramon Wenger 33801ff8a6 Update caniuse database 2024-02-28 11:14:45 +01:00
Ramon Wenger 2ffbd62e4f Fix wrong import syntax for mark.js 2024-02-28 11:14:45 +01:00
Ramon Wenger c180aa94f5 Show sidebar only after clicking some highlighted text 2024-02-28 11:14:45 +01:00
Ramon Wenger e2f283ba71 Add new postcss mixin 2024-02-28 11:14:45 +01:00
Ramon Wenger 7374e42b07 Update package-lock.json 2024-02-28 11:14:45 +01:00
Ramon Wenger f2a9c9cdd9 Fix linting issues 2024-02-28 11:14:45 +01:00
Ramon Wenger eaca8f32e4 Experiment with overflowing text and ellipses 2024-02-28 11:14:45 +01:00
Ramon Wenger ebbbca72c4 Refactor some styles 2024-02-28 11:14:45 +01:00
Ramon Wenger d6860154f7 Add initial component for highlight sidebar, with styling but without logic 2024-02-28 11:14:45 +01:00
Ramon Wenger 776838fb10 Add missing fragment file 2024-02-28 11:14:45 +01:00
Ramon Wenger 2e61cfbed6 Add styling for different highlight colors
Also refactor the naming of the colors
2024-02-28 11:14:45 +01:00
Ramon Wenger 4f72c9564d Update highlights on cache change 2024-02-28 11:14:45 +01:00
Ramon Wenger 7932b65895 Add highlight fragment to legacy content block query 2024-02-28 11:14:45 +01:00
Ramon Wenger f41b43aa70 Add mutation for adding highlights to client also 2024-02-28 11:14:45 +01:00
Ramon Wenger cba5705aee Add mutation for creating highlights to the server 2024-02-28 11:14:45 +01:00
Ramon Wenger 61d23945f7 Make dynamic components inside ContentComponent not load asynchronously
So they load right with the ContentComponent, otherwise we get
"stuttering", and the contents are not ready to be highlighted without a
timeout
2024-02-28 11:14:45 +01:00