From 1483ec8be0f3a71dd3b3af64b6e0d6c23aba106b Mon Sep 17 00:00:00 2001
From: Daniel Egger <daniel.egger@gmail.com>
Date: Mon, 20 Jun 2022 16:26:44 +0200
Subject: [PATCH] Refactor to pinia store

---
 .../components/circle/LearningSequence.vue    | 19 +++---
 client/src/services/__tests__/circle.spec.ts  |  4 +-
 client/src/services/circle.ts                 | 63 +-----------------
 client/src/stores/circle.ts                   | 59 +++++++++++++++++
 client/src/types.ts                           | 63 ++++++++++++++++++
 client/src/views/CircleView.vue               | 64 +++++--------------
 6 files changed, 149 insertions(+), 123 deletions(-)
 create mode 100644 client/src/stores/circle.ts
 create mode 100644 client/src/types.ts

diff --git a/client/src/components/circle/LearningSequence.vue b/client/src/components/circle/LearningSequence.vue
index 04c243a9..915af655 100644
--- a/client/src/components/circle/LearningSequence.vue
+++ b/client/src/components/circle/LearningSequence.vue
@@ -1,22 +1,19 @@
 <script setup lang="ts">
 import ItCheckbox from '@/components/ui/ItCheckbox.vue';
-import type {LearningContent, LearningSequence} from '@/services/circle';
+import type {LearningContent, LearningSequence} from '@/types';
+import {useCircleStore} from '@/stores/circle';
 
 const props = defineProps<{
   learningSequence: LearningSequence
-  completionData: any
 }>()
 
-const contentCompleted = (learningContent: LearningContent) => {
-  if (props.completionData?.completed_learning_contents) {
-    return props.completionData.completed_learning_contents.findIndex((e) => {
-      return e.learning_content_key === learningContent.translation_key && e.completed;
-    }) >= 0;
-  }
+const circleStore = useCircleStore();
 
-  return false;
+function toggleCompleted(learningContent: LearningContent) {
+  circleStore.toggleCompleted(learningContent, !learningContent.completed);
 }
 
+
 </script>
 
 <template>
@@ -44,8 +41,8 @@ const contentCompleted = (learningContent: LearningContent) => {
           class="flex items-center gap-4 pb-3"
         >
           <ItCheckbox
-            :modelValue="contentCompleted(learningContent)"
-            @click="$emit('toggleLearningContentCheckbox', learningContent, !contentCompleted(learningContent))"
+            :modelValue="learningContent.completed"
+            @click="toggleCompleted(learningContent)"
           >
             {{ learningContent.contents[0].type }}: {{ learningContent.title }}
           </ItCheckbox>
diff --git a/client/src/services/__tests__/circle.spec.ts b/client/src/services/__tests__/circle.spec.ts
index adca77ec..105f891b 100644
--- a/client/src/services/__tests__/circle.spec.ts
+++ b/client/src/services/__tests__/circle.spec.ts
@@ -1,6 +1,6 @@
 import {describe, it} from 'vitest'
-import type {Circle} from '../circle';
 import {parseLearningSequences} from '../circle';
+import type {WagtailCircle} from '@/types';
 
 describe('circleService.parseLearningSequences', () => {
   it('can parse learning sequences from api response', () => {
@@ -117,7 +117,7 @@ describe('circleService.parseLearningSequences', () => {
       "job_situations": [],
       "goals": [],
       "experts": []
-    } as Circle;
+    } as WagtailCircle;
 
     const learningSequences = parseLearningSequences(input.children);
 
diff --git a/client/src/services/circle.ts b/client/src/services/circle.ts
index 9ef19e63..e2427408 100644
--- a/client/src/services/circle.ts
+++ b/client/src/services/circle.ts
@@ -1,66 +1,6 @@
-export interface LearningContentBlock {
-  type: 'video' | 'web-based-training' | 'podcast' | 'competence' | 'exercise' | 'document' | 'knowledge';
-  value: {
-    description: string;
-    url?: string;
-  },
-  id: string;
-}
+import type {CircleChild, LearningSequence, LearningUnit} from '@/types';
 
 
-export interface CircleGoal {
-  type: 'goal';
-  value: string;
-  id: string;
-}
-
-
-export interface CircleJobSituation {
-  type: 'job_situation';
-  value: string;
-  id: string;
-}
-
-
-export interface LearningWagtailPage {
-  id: number;
-  title: string;
-  slug: string;
-  translation_key: string;
-}
-
-
-export interface LearningContent extends  LearningWagtailPage {
-  type: 'learnpath.LearningContent';
-  minutes: number;
-  contents: LearningContentBlock[];
-}
-
-
-export interface LearningUnit extends LearningWagtailPage {
-  type: 'learnpath.LearningUnit';
-  questions: [];
-  learningContents: LearningContent[];
-  minutes: number;
-}
-
-
-export interface LearningSequence extends LearningWagtailPage {
-  type: 'learnpath.LearningSequence';
-  icon: string;
-  learningUnits: LearningUnit[];
-  minutes: number;
-}
-
-
-type CircleChild = LearningContent | LearningUnit | LearningSequence;
-
-export interface Circle extends LearningWagtailPage {
-  type: 'learnpath.Circle';
-  children: CircleChild[];
-  description: string;
-}
-
 function createEmptyLearningUnit(): LearningUnit {
   return {
     id: -1,
@@ -132,3 +72,4 @@ export function parseLearningSequences (children: CircleChild[]): LearningSequen
 
   return result;
 }
+
diff --git a/client/src/stores/circle.ts b/client/src/stores/circle.ts
new file mode 100644
index 00000000..0d1edb23
--- /dev/null
+++ b/client/src/stores/circle.ts
@@ -0,0 +1,59 @@
+import {defineStore} from 'pinia'
+
+import type {Circle, LearningContent} from '@/types'
+import {itGet, itPost} from '@/fetchHelpers';
+import {parseLearningSequences} from '@/services/circle';
+
+export type CircleStoreState = {
+  circleData: Circle;
+  completionData: any;
+}
+
+export const useCircleStore = defineStore({
+  id: 'circle',
+  state: () => {
+    return {
+      circleData: {},
+      completionData: {},
+    } as CircleStoreState;
+  },
+  getters: {},
+  actions: {
+    async loadCircle(slug: string) {
+      try {
+        this.circleData = await itGet(`/learnpath/api/circle/${slug}/`);
+        console.log(this.circleData);
+        this.circleData.learningSequences = parseLearningSequences(this.circleData.children);
+        this.completionData = await itGet(`/api/completion/circle/${this.circleData.translation_key}/`);
+        this.parseCompletionData();
+      } catch (error) {
+        console.warn(error);
+        return error
+      }
+    },
+    async toggleCompleted(learningContent: LearningContent, flag = true) {
+      try {
+        learningContent.completed = flag;
+        this.completionData = await itPost('/api/completion/complete_learning_content/', {
+          learning_content_key: learningContent.translation_key,
+          completed: learningContent.completed,
+        });
+        this.parseCompletionData();
+      } catch (error) {
+        console.warn(error);
+        return error
+      }
+    },
+    parseCompletionData() {
+      this.circleData.learningSequences.forEach((learningSequence) => {
+        learningSequence.learningUnits.forEach((learningUnit) => {
+          learningUnit.learningContents.forEach((learningContent) => {
+            learningContent.completed = this.completionData.completed_learning_contents.findIndex((e) => {
+              return e.learning_content_key === learningContent.translation_key && e.completed;
+            }) >= 0;
+          });
+        });
+      });
+    }
+  }
+})
diff --git a/client/src/types.ts b/client/src/types.ts
new file mode 100644
index 00000000..3cd7b039
--- /dev/null
+++ b/client/src/types.ts
@@ -0,0 +1,63 @@
+export interface LearningContentBlock {
+  type: 'video' | 'web-based-training' | 'podcast' | 'competence' | 'exercise' | 'document' | 'knowledge';
+  value: {
+    description: string;
+    url?: string;
+  },
+  id: string;
+}
+
+export interface CircleGoal {
+  type: 'goal';
+  value: string;
+  id: string;
+}
+
+export interface CircleJobSituation {
+  type: 'job_situation';
+  value: string;
+  id: string;
+}
+
+export interface LearningWagtailPage {
+  id: number;
+  title: string;
+  slug: string;
+  translation_key: string;
+}
+
+export interface LearningContent extends LearningWagtailPage {
+  type: 'learnpath.LearningContent';
+  minutes: number;
+  contents: LearningContentBlock[];
+  completed?: boolean;
+}
+
+export interface LearningUnit extends LearningWagtailPage {
+  type: 'learnpath.LearningUnit';
+  questions: [];
+  learningContents: LearningContent[];
+  minutes: number;
+}
+
+export interface LearningSequence extends LearningWagtailPage {
+  type: 'learnpath.LearningSequence';
+  icon: string;
+  learningUnits: LearningUnit[];
+  minutes: number;
+}
+
+export type CircleChild = LearningContent | LearningUnit | LearningSequence;
+
+export interface WagtailCircle extends LearningWagtailPage {
+  type: 'learnpath.Circle';
+  children: CircleChild[];
+  description: string;
+}
+
+export interface Circle extends LearningWagtailPage {
+  type: 'learnpath.Circle';
+  children: CircleChild[];
+  description: string;
+  learningSequences: LearningSequence[];
+}
diff --git a/client/src/views/CircleView.vue b/client/src/views/CircleView.vue
index ac169625..0ee704df 100644
--- a/client/src/views/CircleView.vue
+++ b/client/src/views/CircleView.vue
@@ -1,57 +1,23 @@
-<script lang="ts">
+<script setup lang="ts">
 import * as log from 'loglevel';
 
 import MainNavigationBar from '../components/MainNavigationBar.vue';
 import LearningSequence from '../components/circle/LearningSequence.vue';
-import type {Circle, LearningContent} from '../services/circle';
-import {parseLearningSequences} from '../services/circle';
 
-import {defineComponent} from 'vue'
-import {itGet, itPost} from '@/fetchHelpers';
+import {onMounted} from 'vue'
+import {useCircleStore} from '@/stores/circle';
 
-export default defineComponent({
-  components: { LearningSequence, MainNavigationBar },
-  props: {
-    circleSlug: {
-      type: String,
-      required: true,
-    },
-  },
-  data() {
-    return {
-      count: 0,
-      circleData: {} as Circle,
-      learningSequences: [] as LearningSequence[],
-      completionData: {},
-    }
-  },
-  methods: {
-    toggleLearningContentCheckbox(learningContent: LearningContent, completed=true) {
-      log.debug('toggleLearningContentCheckbox', learningContent, completed);
-      console.log(learningContent);
+const props = defineProps<{
+  circleSlug: string
+}>()
 
-      itPost('/api/completion/complete_learning_content/', {
-        learning_content_key: learningContent.translation_key,
-        completed: completed,
-      }).then((data) => {
-        log.warn(data);
-        this.completionData = data;
-      });
-    },
-  },
-  mounted() {
-    log.debug('CircleView mounted', this.circleSlug);
-    itGet(`/learnpath/api/circle/${this.circleSlug}/`).then((data) => {
-      this.circleData = data;
-      this.learningSequences = parseLearningSequences(this.circleData.children);
-      log.debug(this.learningSequences);
+const circleStore = useCircleStore();
 
-      itGet(`/api/completion/circle/${this.circleData.translation_key}/`).then((completionData) => {
-        this.completionData = completionData;
-      });
-    });
-  }
+onMounted(() => {
+  log.info('CircleView.vue mounted');
+  circleStore.loadCircle(props.circleSlug);
 });
+
 </script>
 
 <template>
@@ -61,7 +27,7 @@ export default defineComponent({
     <div class="flex flex-col lg:flex-row">
       <div class="flex-initial lg:w-128 px-4 py-8 lg:px-8">
         <h1 class="text-blue-dark text-7xl">
-          {{ circleData.title }}
+          {{ circleStore.circleData.title }}
         </h1>
 
         <div class="mt-8">
@@ -71,7 +37,7 @@ export default defineComponent({
         <div class="outcome border border-gray-500 mt-8 p-6">
           <h3 class="text-blue-dark">Das lernst du in diesem Circle.</h3>
           <div class="prose mt-4">
-            {{ circleData.description }}
+            {{ circleStore.circleData.description }}
           </div>
 
           <button class="btn-primary mt-4">Erfahre mehr dazu</button>
@@ -88,12 +54,12 @@ export default defineComponent({
 
       <div class="flex-auto bg-gray-100 px-4 py-8 lg:px-24">
         <div
-          v-for="learningSequence in learningSequences"
+          v-for="learningSequence in circleStore.circleData.learningSequences"
           :key="learningSequence.translation_key"
         >
           <LearningSequence
             :learning-sequence="learningSequence" @toggleLearningContentCheckbox="toggleLearningContentCheckbox"
-            :completion-data="completionData"
+            :completion-data="circleStore.completionData"
           ></LearningSequence>
         </div>