From 4b2fa46eee67477599dfaab7c22442c09b3743fb Mon Sep 17 00:00:00 2001 From: Livio Bieri Date: Mon, 30 Oct 2023 13:23:33 +0100 Subject: [PATCH 1/2] chore: todo for important but missing test --- .../vbv_lernwelt/dashboard/tests/graphql/test_competence.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/server/vbv_lernwelt/dashboard/tests/graphql/test_competence.py b/server/vbv_lernwelt/dashboard/tests/graphql/test_competence.py index bdcc6f66..8bf37cb3 100644 --- a/server/vbv_lernwelt/dashboard/tests/graphql/test_competence.py +++ b/server/vbv_lernwelt/dashboard/tests/graphql/test_competence.py @@ -18,6 +18,10 @@ class DashboardCompetenceTestCase(GraphQLTestCase): GRAPHQL_URL = "/server/graphql/" def test_competence(self): + # TODO: Livioso 30.10.2023 + # A test that checks the competence records + # would make sense -> missing (circle, learning unit) nesting! + # GIVEN course, course_page = create_course("Test Course") course_session = create_course_session(course=course, title="Test Bern 2022 a") From cb5f9fedc48ccfa547655ab1d9d73654d049f39a Mon Sep 17 00:00:00 2001 From: Livio Bieri Date: Mon, 30 Oct 2023 14:12:02 +0100 Subject: [PATCH 2/2] fix: corrects total_responses for feedback count --- server/vbv_lernwelt/dashboard/graphql/types/feedback.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/server/vbv_lernwelt/dashboard/graphql/types/feedback.py b/server/vbv_lernwelt/dashboard/graphql/types/feedback.py index 458d27c0..34ce9ecc 100644 --- a/server/vbv_lernwelt/dashboard/graphql/types/feedback.py +++ b/server/vbv_lernwelt/dashboard/graphql/types/feedback.py @@ -43,6 +43,7 @@ def feedback_responses( ) circle_feedbacks = [] + total_responses = 0 for course_session in course_sessions: fbs = FeedbackResponse.objects.filter( @@ -51,6 +52,8 @@ def feedback_responses( feedback_user__in=feedback_users(course_session.id), ) + total_responses += len(fbs) + circle_feedbacks.extend( circle_feedback_average( feedbacks=fbs, @@ -74,7 +77,7 @@ def feedback_responses( _id=course_id, # noqa satisfaction_average=avg, # noqa satisfaction_max=4, # noqa - total_responses=len(circle_feedbacks), # noqa + total_responses=total_responses, # noqa ), )