From 4f58415ff5237ba7a5363a57e37b96415cefc84c Mon Sep 17 00:00:00 2001 From: Daniel Egger Date: Tue, 2 Jul 2024 11:05:30 +0200 Subject: [PATCH] Refactor VV_PRODUCT_NUMBER as const --- server/vbv_lernwelt/shop/const.py | 3 +++ server/vbv_lernwelt/shop/invoice/abacus.py | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/server/vbv_lernwelt/shop/const.py b/server/vbv_lernwelt/shop/const.py index 01eb648b..283fbee3 100644 --- a/server/vbv_lernwelt/shop/const.py +++ b/server/vbv_lernwelt/shop/const.py @@ -2,3 +2,6 @@ VV_DE_PRODUCT_SKU = "vv-de" VV_FR_PRODUCT_SKU = "vv-fr" VV_IT_PRODUCT_SKU = "vv-it" + +# VBV Abacus VV product number +VV_PRODUCT_NUMBER = "30202" diff --git a/server/vbv_lernwelt/shop/invoice/abacus.py b/server/vbv_lernwelt/shop/invoice/abacus.py index 201345d3..50b103f3 100644 --- a/server/vbv_lernwelt/shop/invoice/abacus.py +++ b/server/vbv_lernwelt/shop/invoice/abacus.py @@ -5,6 +5,7 @@ from xml.etree.ElementTree import Element, SubElement, tostring import structlog +from vbv_lernwelt.shop.const import VV_PRODUCT_NUMBER from vbv_lernwelt.shop.invoice.abacus_sftp_client import AbacusSftpClient from vbv_lernwelt.shop.models import CheckoutInformation, CheckoutState @@ -165,7 +166,7 @@ def render_invoice_xml( item_fields = SubElement(item_element, "ItemFields", mode="SAVE") SubElement(item_fields, "DeliveryDate").text = order_date.isoformat() SubElement(item_fields, "ItemNumber").text = "1" - SubElement(item_fields, "ProductNumber").text = "30202" + SubElement(item_fields, "ProductNumber").text = VV_PRODUCT_NUMBER SubElement(item_fields, "QuantityOrdered").text = "1" item_text = SubElement(item_element, "ItemText", mode="SAVE")