From 8d4021a957cc25085cd42cc7c2a57abd8cae6664 Mon Sep 17 00:00:00 2001 From: Daniel Egger Date: Thu, 2 May 2024 10:53:41 +0200 Subject: [PATCH] Bugfix: filter out SelfEvaluationFeedback which is not part of course --- server/vbv_lernwelt/dashboard/views.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/server/vbv_lernwelt/dashboard/views.py b/server/vbv_lernwelt/dashboard/views.py index bb05a202..2e1eb012 100644 --- a/server/vbv_lernwelt/dashboard/views.py +++ b/server/vbv_lernwelt/dashboard/views.py @@ -511,10 +511,18 @@ def _get_mentor_open_tasks_count(course_id: str, mentor: User) -> int: assignment_user__coursesessionuser__participants__mentor=mentor, ).count() - open_feedback_count = SelfEvaluationFeedback.objects.filter( + open_feedback_qs = SelfEvaluationFeedback.objects.filter( feedback_provider_user=mentor, # noqa feedback_requester_user__coursesessionuser__participants__mentor=mentor, feedback_submitted=False, - ).count() + ) + # filter open feedbacks for course_id (-> not possible with queryset) + open_feedback_count = len( + [ + feedback_entry + for feedback_entry in open_feedback_qs + if str(feedback_entry.learning_unit.get_course().id) == course_id + ] + ) return open_assigment_count + open_feedback_count