From 55b016b86a3b2846fe42e7223ce151ad9d78c6e0 Mon Sep 17 00:00:00 2001 From: Livio Bieri Date: Tue, 30 Jan 2024 11:34:02 +0100 Subject: [PATCH] feat: expose title of learning unit for mentor eval --- .../learning_mentor/content/self_evaluation_feedback.py | 1 + server/vbv_lernwelt/self_evaluation_feedback/serializers.py | 4 +++- .../vbv_lernwelt/self_evaluation_feedback/tests/test_api.py | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/server/vbv_lernwelt/learning_mentor/content/self_evaluation_feedback.py b/server/vbv_lernwelt/learning_mentor/content/self_evaluation_feedback.py index f434485a..c8e138f7 100644 --- a/server/vbv_lernwelt/learning_mentor/content/self_evaluation_feedback.py +++ b/server/vbv_lernwelt/learning_mentor/content/self_evaluation_feedback.py @@ -91,6 +91,7 @@ def get_self_feedback_evaluation( else MentorCompletionStatus.SUBMITTED, user_id=f.feedback_requester_user.id, last_name=f.feedback_requester_user.last_name, + url=f"/course/{course.slug}/cockpit/mentor/self-evaluation-feedback/{f.learning_unit.id}", ) for f in feedbacks ] diff --git a/server/vbv_lernwelt/self_evaluation_feedback/serializers.py b/server/vbv_lernwelt/self_evaluation_feedback/serializers.py index 8fdf4f49..d2cb9a44 100644 --- a/server/vbv_lernwelt/self_evaluation_feedback/serializers.py +++ b/server/vbv_lernwelt/self_evaluation_feedback/serializers.py @@ -22,13 +22,15 @@ class SelfEvaluationFeedbackSerializer(serializers.ModelSerializer): read_only=True, source="course_completion_feedback" ) circle_name = serializers.SerializerMethodField() + title = serializers.CharField(source="learning_unit.title") class Meta: model = SelfEvaluationFeedback fields = [ "feedback_id", - "learning_unit_id", + "title", "circle_name", + "learning_unit_id", "feedback_submitted", "feedback_requester_user", "feedback_provider_user", diff --git a/server/vbv_lernwelt/self_evaluation_feedback/tests/test_api.py b/server/vbv_lernwelt/self_evaluation_feedback/tests/test_api.py index 08dea1da..550f3a28 100644 --- a/server/vbv_lernwelt/self_evaluation_feedback/tests/test_api.py +++ b/server/vbv_lernwelt/self_evaluation_feedback/tests/test_api.py @@ -279,6 +279,7 @@ class SelfEvaluationFeedbackAPI(APITestCase): feedback = response.data self.assertEqual(feedback["learning_unit_id"], learning_unit.id) + self.assertEqual(feedback["title"], learning_unit.title) self.assertEqual(feedback["feedback_submitted"], False) self.assertEqual(feedback["circle_name"], self.circle.title)