From 587f354e52a48a6c7cf3bd77f72c1d345d0ce3b4 Mon Sep 17 00:00:00 2001 From: Christian Cueni Date: Mon, 22 Jan 2024 15:38:37 +0100 Subject: [PATCH] Handle invalid recipient email addresses --- server/vbv_lernwelt/notify/services.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/server/vbv_lernwelt/notify/services.py b/server/vbv_lernwelt/notify/services.py index bf792511..84102609 100644 --- a/server/vbv_lernwelt/notify/services.py +++ b/server/vbv_lernwelt/notify/services.py @@ -3,6 +3,8 @@ from __future__ import annotations from typing import TYPE_CHECKING import structlog +from django.core.exceptions import ValidationError +from django.core.validators import validate_email from django.db.models import Model from notifications.signals import notify @@ -281,6 +283,13 @@ class NotificationService: template_data=template_data, ) emailed = False + + try: + validate_email(recipient.email) + except ValidationError: + log.info("Recipient email is invalid") + return f"{notification_identifier}_invalid_email" + try: notification = NotificationService._find_duplicate_notification( recipient=recipient,