From 6b0cf9effd2b581fc34ee26db10691cc54f7b8df Mon Sep 17 00:00:00 2001
From: Daniel Egger <daniel.egger@gmail.com>
Date: Fri, 9 Sep 2022 17:36:43 +0200
Subject: [PATCH] Refactor LearningContent routing

---
 .../src/components/circle/LearningContent.vue | 15 ++--
 .../src/components/circle/SelfEvaluation.vue  | 72 +++++++------------
 client/src/stores/circle.ts                   | 51 +++++--------
 client/src/views/LearningContentView.vue      | 41 ++++++++---
 .../views/LearningUnitSelfEvaluationView.vue  | 15 ++--
 5 files changed, 97 insertions(+), 97 deletions(-)

diff --git a/client/src/components/circle/LearningContent.vue b/client/src/components/circle/LearningContent.vue
index fd5b3403..bbc0515a 100644
--- a/client/src/components/circle/LearningContent.vue
+++ b/client/src/components/circle/LearningContent.vue
@@ -1,23 +1,28 @@
 <script setup lang="ts">
 import * as log from 'loglevel'
 import { computed } from 'vue'
+import type { LearningContent } from '@/types'
 import { useCircleStore } from '@/stores/circle'
 
 log.debug('LearningContent.vue setup')
 
 const circleStore = useCircleStore()
 
-const learningContent = computed(() => circleStore.currentLearningContent)
+const props = defineProps<{
+  learningContent: LearningContent
+}>()
 
 const block = computed(() => {
-  if (learningContent.value) {
-    return learningContent.value.contents[0]
+  if (props.learningContent?.contents?.length) {
+    return props.learningContent.contents[0]
   }
+
+  return undefined
 })
 </script>
 
 <template>
-  <div>
+  <div v-if="block">
     <nav class="px-4 lg:px-8 py-4 flex justify-between items-center border-b border-gray-500">
       <button
         type="button"
@@ -35,7 +40,7 @@ const block = computed(() => {
         type="button"
         class="btn-blue"
         data-cy="complete-and-continue"
-        @click="circleStore.continueFromLearningContent()"
+        @click="circleStore.continueFromLearningContent(this.learningContent)"
       >
         Abschliessen und weiter
       </button>
diff --git a/client/src/components/circle/SelfEvaluation.vue b/client/src/components/circle/SelfEvaluation.vue
index ceeece63..dcb04db0 100644
--- a/client/src/components/circle/SelfEvaluation.vue
+++ b/client/src/components/circle/SelfEvaluation.vue
@@ -1,42 +1,39 @@
 <script setup lang="ts">
-import * as log from 'loglevel';
-import {computed, reactive} from 'vue';
-import {useCircleStore} from '@/stores/circle';
+import * as log from 'loglevel'
+import { computed, reactive } from 'vue'
+import { useCircleStore } from '@/stores/circle'
+import { LearningUnit } from '@/types'
 
-log.debug('LearningContent.vue setup');
+log.debug('LearningContent.vue setup')
 
-const circleStore = useCircleStore();
+const circleStore = useCircleStore()
 
 const state = reactive({
   questionIndex: 0,
-});
+})
 
-const questions = computed(() => circleStore.currentSelfEvaluation!.children);
-const currentQuestion = computed(() => questions.value[state.questionIndex]);
+const props = defineProps<{
+  learningUnit: LearningUnit
+}>()
+
+const questions = computed(() => props.learningUnit?.children)
+const currentQuestion = computed(() => questions.value[state.questionIndex])
 
 function handleContinue() {
-  log.debug('handleContinue');
+  log.debug('handleContinue')
   if (state.questionIndex + 1 < questions.value.length) {
-    log.debug('increment questionIndex', state.questionIndex);
-    state.questionIndex += 1;
+    log.debug('increment questionIndex', state.questionIndex)
+    state.questionIndex += 1
   } else {
-    log.debug('continue to next learning content');
-    circleStore.continueFromSelfEvaluation();
+    log.debug('continue to next learning content')
+    circleStore.continueFromSelfEvaluation()
   }
 }
-
 </script>
 
 <template>
-  <div>
-    <nav
-      class="
-        px-4 lg:px-8
-        py-4
-        flex justify-between items-center
-        border-b border-gray-500
-      "
-    >
+  <div v-if="learningUnit">
+    <nav class="px-4 lg:px-8 py-4 flex justify-between items-center border-b border-gray-500">
       <button
         type="button"
         class="btn-text inline-flex items-center px-3 py-2 font-normal"
@@ -46,24 +43,17 @@ function handleContinue() {
         <span class="hidden lg:inline">zurück zum Circle</span>
       </button>
 
-      <h1 class="text-xl hidden lg:block">{{ circleStore.currentSelfEvaluation.title }}</h1>
+      <h1 class="text-xl hidden lg:block">{{ learningUnit.title }}</h1>
 
-      <button
-        type="button"
-        class="btn-blue"
-        @click="handleContinue()"
-      >
-        Weiter
-      </button>
+      <button type="button" class="btn-blue" @click="handleContinue()">Weiter</button>
     </nav>
 
-
     <div class="mx-auto max-w-6xl px-4 lg:px-8 py-4">
-
       <div class="mt-2 lg:mt-8 text-gray-700">Schritt {{ state.questionIndex + 1 }} von {{ questions.length }}</div>
 
       <p class="text-xl mt-4">
-        Überprüfe, ob du in der Lernheinheit <span class="font-bold">"{{ circleStore.currentSelfEvaluation.title }}"</span> alles verstanden hast.<br>
+        Überprüfe, ob du in der Lernheinheit
+        <span class="font-bold">"{{ learningUnit.title }}"</span> alles verstanden hast.<br />
         Lies die folgende Aussage und bewerte sie:
       </p>
 
@@ -81,9 +71,7 @@ function handleContinue() {
             }"
           >
             <it-icon-smiley-happy class="w-16 h-16 mr-4"></it-icon-smiley-happy>
-            <span class="font-bold text-xl">
-            Ja, ich kann das.
-            </span>
+            <span class="font-bold text-xl"> Ja, ich kann das. </span>
           </button>
           <button
             @click="circleStore.markCompletion(currentQuestion, false)"
@@ -95,20 +83,14 @@ function handleContinue() {
             }"
           >
             <it-icon-smiley-thinking class="w-16 h-16 mr-4"></it-icon-smiley-thinking>
-            <span class="font-bold text-xl">
-              Das muss ich nochmals anschauen.
-            </span>
+            <span class="font-bold text-xl"> Das muss ich nochmals anschauen. </span>
           </button>
         </div>
 
         <div class="mt-6 lg:mt-12">Schau dein Fortschritt in deinem Kompetenzprofil: Kompetenzprofil öffnen</div>
       </div>
-
     </div>
-
   </div>
-
 </template>
 
-<style scoped>
-</style>
+<style scoped></style>
diff --git a/client/src/stores/circle.ts b/client/src/stores/circle.ts
index 5f2bdfe2..9fff1755 100644
--- a/client/src/stores/circle.ts
+++ b/client/src/stores/circle.ts
@@ -9,9 +9,6 @@ import { useLearningPathStore } from '@/stores/learningPath'
 
 export type CircleStoreState = {
   circle: Circle | undefined
-  currentLearningContent: LearningContent | undefined
-  currentSelfEvaluation: LearningUnit | undefined
-  page: 'INDEX' | 'OVERVIEW' | 'LEARNING_CONTENT' | 'SELF_EVALUATION'
 }
 
 export const useCircleStore = defineStore({
@@ -19,9 +16,6 @@ export const useCircleStore = defineStore({
   state: () => {
     return {
       circle: undefined,
-      currentLearningContent: undefined,
-      currentSelfEvaluation: undefined,
-      page: 'INDEX',
     } as CircleStoreState;
   },
   getters: {
@@ -45,32 +39,27 @@ export const useCircleStore = defineStore({
     },
     async loadLearningContent(learningPathSlug: string, circleSlug: string, learningContentSlug: string) {
       const circle = await this.loadCircle(learningPathSlug, circleSlug);
-      if (circle) {
-        this.currentLearningContent = circle.flatLearningContents.find((learningContent) => {
-          return learningContent.slug.endsWith(learningContentSlug);
-        });
-      }
+      const result = circle.flatLearningContents.find((learningContent) => {
+        return learningContent.slug.endsWith(learningContentSlug);
+      });
 
-      if (!this.currentLearningContent) {
+      if (!result) {
         throw `No learning content found with slug: ${learningContentSlug}`;
       }
 
-      return this.currentLearningContent;
+      return result
     },
     async loadSelfEvaluation(learningPathSlug: string, circleSlug: string, learningUnitSlug: string) {
       const circle = await this.loadCircle(learningPathSlug, circleSlug);
-      if (circle) {
-        this.currentSelfEvaluation = circle.flatLearningUnits.find((child) => {
-          return child.slug.endsWith(learningUnitSlug)
-        });
-      }
+      const learningUnit = circle.flatLearningUnits.find((child) => {
+        return child.slug.endsWith(learningUnitSlug)
+      });
 
-      if (!this.currentSelfEvaluation) {
+      if (!learningUnit) {
         throw `No self evaluation found with slug: ${learningUnitSlug}`;
       }
 
-      return this.currentLearningContent;
-
+      return learningUnit
     },
     async markCompletion(page: LearningContent | LearningUnitQuestion, flag = true) {
       try {
@@ -88,7 +77,6 @@ export const useCircleStore = defineStore({
       }
     },
     openLearningContent(learningContent: LearningContent) {
-      this.currentLearningContent = learningContent;
       const shortSlug = learningContent.slug.replace(`${this.circle?.slug}-lc-`, '');
       this.router.push({
         path: `${this.circle?.getUrl()}/${shortSlug}`,
@@ -100,7 +88,6 @@ export const useCircleStore = defineStore({
       });
     },
     openSelfEvaluation(learningUnit: LearningUnit) {
-      this.currentSelfEvaluation = learningUnit;
       const shortSlug = learningUnit.slug.replace(`${this.circle?.slug}-lu-`, '');
       this.router.push({
         path: `${this.circle?.getUrl()}/evaluate/${shortSlug}`,
@@ -122,12 +109,12 @@ export const useCircleStore = defineStore({
       }
       return undefined;
     },
-    continueFromLearningContent() {
-      if (this.currentLearningContent) {
-        this.markCompletion(this.currentLearningContent, true);
+    continueFromLearningContent(currentLearningContent: LearningContent) {
+      if (currentLearningContent) {
+        this.markCompletion(currentLearningContent, true);
 
-        const nextLearningContent = this.currentLearningContent.nextLearningContent;
-        const currentParent = this.currentLearningContent.parentLearningUnit;
+        const nextLearningContent = currentLearningContent.nextLearningContent;
+        const currentParent = currentLearningContent.parentLearningUnit;
         const nextParent = nextLearningContent?.parentLearningUnit;
 
         if (
@@ -138,12 +125,12 @@ export const useCircleStore = defineStore({
           // go to self evaluation
           // this.openSelfEvaluation(currentParent);
           this.closeLearningContent();
-        } else if (this.currentLearningContent.nextLearningContent) {
+        } else if (currentLearningContent.nextLearningContent) {
           if (
-            this.currentLearningContent.parentLearningSequence &&
-            this.currentLearningContent.parentLearningSequence.id === nextLearningContent?.parentLearningSequence?.id
+            currentLearningContent.parentLearningSequence &&
+            currentLearningContent.parentLearningSequence.id === nextLearningContent?.parentLearningSequence?.id
           ) {
-            this.openLearningContent(this.currentLearningContent.nextLearningContent);
+            this.openLearningContent(currentLearningContent.nextLearningContent);
           } else {
             this.closeLearningContent();
           }
diff --git a/client/src/views/LearningContentView.vue b/client/src/views/LearningContentView.vue
index df25a693..17af144b 100644
--- a/client/src/views/LearningContentView.vue
+++ b/client/src/views/LearningContentView.vue
@@ -1,10 +1,10 @@
 <script setup lang="ts">
 import * as log from 'loglevel'
-import LearningContent from '@/components/circle/LearningContent.vue'
-
-import { onMounted } from 'vue'
+import { onMounted, reactive, watch } from 'vue'
 import { useCircleStore } from '@/stores/circle'
 import { useAppStore } from '@/stores/app'
+import LearningContent from '@/components/circle/LearningContent.vue'
+import { LearningContent as LearningContentType } from '@/types'
 
 log.debug('LearningContentView created')
 
@@ -14,27 +14,46 @@ const props = defineProps<{
   contentSlug: string
 }>()
 
+const state: { learningContent?: LearningContentType } = reactive({})
+
 const appStore = useAppStore()
 appStore.showMainNavigationBar = false
 
 const circleStore = useCircleStore()
 
-onMounted(async () => {
-  log.debug('LearningContentView mounted', props.learningPathSlug, props.circleSlug, props.contentSlug)
-
+const loadLearningContent = async () => {
   try {
-    await circleStore.loadLearningContent(props.learningPathSlug, props.circleSlug, props.contentSlug)
+    state.learningContent = await circleStore.loadLearningContent(
+      props.learningPathSlug,
+      props.circleSlug,
+      props.contentSlug
+    )
   } catch (error) {
     log.error(error)
   }
+}
+
+watch(
+  () => props.contentSlug,
+  async () => {
+    log.debug(
+      'LearningContentView props.contentSlug changed',
+      props.learningPathSlug,
+      props.circleSlug,
+      props.contentSlug
+    )
+    await loadLearningContent()
+  }
+)
+
+onMounted(async () => {
+  log.debug('LearningContentView mounted', props.learningPathSlug, props.circleSlug, props.contentSlug)
+  await loadLearningContent()
 })
 </script>
 
 <template>
-  <LearningContent
-    v-if="circleStore.currentLearningContent"
-    :key="circleStore.currentLearningContent.translation_key"
-  />
+  <LearningContent v-if="state.learningContent" :learning-content="state.learningContent" />
 </template>
 
 <style lang="postcss" scoped></style>
diff --git a/client/src/views/LearningUnitSelfEvaluationView.vue b/client/src/views/LearningUnitSelfEvaluationView.vue
index f7c084c5..dfcc08f6 100644
--- a/client/src/views/LearningUnitSelfEvaluationView.vue
+++ b/client/src/views/LearningUnitSelfEvaluationView.vue
@@ -3,9 +3,10 @@ import * as log from 'loglevel'
 
 import SelfEvaluation from '@/components/circle/SelfEvaluation.vue'
 
-import { onMounted } from 'vue'
-import { useCircleStore } from '@/stores/circle'
+import { onMounted, reactive } from 'vue'
 import { useAppStore } from '@/stores/app'
+import { useCircleStore } from '@/stores/circle'
+import type { LearningUnit } from '@/types'
 
 log.debug('LearningUnitSelfEvaluationView created')
 
@@ -20,11 +21,17 @@ appStore.showMainNavigationBar = false
 
 const circleStore = useCircleStore()
 
+const state: { learningUnit?: LearningUnit } = reactive({})
+
 onMounted(async () => {
   log.debug('LearningUnitSelfEvaluationView mounted', props.learningPathSlug, props.circleSlug, props.learningUnitSlug)
 
   try {
-    await circleStore.loadSelfEvaluation(props.learningPathSlug, props.circleSlug, props.learningUnitSlug)
+    state.learningUnit = await circleStore.loadSelfEvaluation(
+      props.learningPathSlug,
+      props.circleSlug,
+      props.learningUnitSlug
+    )
   } catch (error) {
     log.error(error)
   }
@@ -32,7 +39,7 @@ onMounted(async () => {
 </script>
 
 <template>
-  <SelfEvaluation v-if="circleStore.currentSelfEvaluation" :key="circleStore.currentSelfEvaluation.translation_key" />
+  <SelfEvaluation v-if="state.learningUnit" :learning-unit="state.learningUnit" />
 </template>
 
 <style lang="postcss" scoped></style>