From 7bddd43b65d7b7fa3bc32dd20a9f1021b6edb3a6 Mon Sep 17 00:00:00 2001
From: Daniel Egger <daniel.egger@gmail.com>
Date: Fri, 2 Dec 2022 15:46:07 +0100
Subject: [PATCH] Refactor competenceStore to handle multiple users

---
 .../pages/competence/CompetenceIndexPage.vue  |   7 +-
 .../pages/competence/CompetenceListPage.vue   |   2 +-
 .../competence/PerformanceCriteriaPage.vue    |   2 +-
 client/src/stores/competence.ts               | 152 ++++++++++--------
 client/src/stores/completion.ts               |  32 ++--
 5 files changed, 109 insertions(+), 86 deletions(-)

diff --git a/client/src/pages/competence/CompetenceIndexPage.vue b/client/src/pages/competence/CompetenceIndexPage.vue
index 07b31df8..50a56ad1 100644
--- a/client/src/pages/competence/CompetenceIndexPage.vue
+++ b/client/src/pages/competence/CompetenceIndexPage.vue
@@ -12,7 +12,8 @@ log.debug("CompetenceIndexPage created");
 const competenceStore = useCompetenceStore();
 
 const failedCriteria = computed(() => {
-  return competenceStore.flatPerformanceCriteria
+  return competenceStore
+    .flatPerformanceCriteria()
     .filter((criteria) => {
       return criteria.completion_status === "fail";
     })
@@ -21,7 +22,7 @@ const failedCriteria = computed(() => {
 
 const lastUpdatedCompetences = computed(() => {
   return _.orderBy(
-    competenceStore.competences,
+    competenceStore.competences(),
     [
       (competence) => {
         let criteria = competence.children;
@@ -43,7 +44,7 @@ const lastUpdatedCompetences = computed(() => {
 });
 
 const countStatus = computed(() => {
-  return competenceStore.calcStatusCount(competenceStore.flatPerformanceCriteria);
+  return competenceStore.calcStatusCount(competenceStore.flatPerformanceCriteria());
 });
 </script>
 
diff --git a/client/src/pages/competence/CompetenceListPage.vue b/client/src/pages/competence/CompetenceListPage.vue
index c57369c0..e0cbd607 100644
--- a/client/src/pages/competence/CompetenceListPage.vue
+++ b/client/src/pages/competence/CompetenceListPage.vue
@@ -31,7 +31,7 @@ const competenceStore = useCompetenceStore();
     </div>
     <ul v-if="competenceStore.competenceProfilePage">
       <li
-        v-for="competence in competenceStore.competences"
+        v-for="competence in competenceStore.competences()"
         :key="competence.id"
         class="bg-white p-8 mb-8"
       >
diff --git a/client/src/pages/competence/PerformanceCriteriaPage.vue b/client/src/pages/competence/PerformanceCriteriaPage.vue
index ad0eab64..cbce6c60 100644
--- a/client/src/pages/competence/PerformanceCriteriaPage.vue
+++ b/client/src/pages/competence/PerformanceCriteriaPage.vue
@@ -19,7 +19,7 @@ interface MenuItem {
 const competenceStore = useCompetenceStore();
 
 const shownCriteria = computed(() => {
-  return competenceStore.flatPerformanceCriteria.filter((criteria) => {
+  return competenceStore.flatPerformanceCriteria().filter((criteria) => {
     return criteria.completion_status === activeMenuItem.value.id;
   });
 });
diff --git a/client/src/stores/competence.ts b/client/src/stores/competence.ts
index f0e87bb3..9f17eabc 100644
--- a/client/src/stores/competence.ts
+++ b/client/src/stores/competence.ts
@@ -11,7 +11,8 @@ import _ from "lodash";
 import { defineStore } from "pinia";
 
 export type CompetenceStoreState = {
-  competenceProfilePage: CompetenceProfilePage | undefined;
+  competenceProfilePages: Map<number, CompetenceProfilePage>;
+
   selectedCircle: { id: string; name: string };
   availableCircles: { id: string; name: string }[];
 };
@@ -20,60 +21,12 @@ export const useCompetenceStore = defineStore({
   id: "competence",
   state: () => {
     return {
-      competenceProfilePage: undefined,
+      competenceProfilePages: new Map<number, CompetenceProfilePage>(),
       selectedCircle: { id: "all", name: "Circle: Alle" },
       availableCircles: [],
     } as CompetenceStoreState;
   },
-  getters: {
-    flatPerformanceCriteria: (state) => {
-      if (!state.competenceProfilePage) {
-        return [];
-      }
-
-      let criteria = _.orderBy(
-        state.competenceProfilePage.children.flatMap((competence) => {
-          return competence.children;
-        }),
-        ["competence_id"],
-        ["asc"]
-      );
-
-      if (state.selectedCircle.id !== "all") {
-        criteria = criteria.filter(
-          (c) => c.circle.translation_key === state.selectedCircle.id
-        );
-      }
-
-      return criteria;
-    },
-    competences: (state) => {
-      if (state.competenceProfilePage?.children.length) {
-        return state.competenceProfilePage.children.filter((competence) => {
-          let criteria = competence.children;
-          if (state.selectedCircle.id != "all") {
-            criteria = criteria.filter((criteria) => {
-              return criteria.circle.translation_key === state.selectedCircle.id;
-            });
-          }
-          return criteria.length > 0;
-        });
-      }
-
-      return [];
-    },
-    criteriaByCompetence: (state) => {
-      return (competence: CompetencePage) => {
-        return competence.children.filter((criteria) => {
-          if (state.selectedCircle.id != "all") {
-            return criteria.circle.translation_key === state.selectedCircle.id;
-          }
-
-          return competence.children;
-        });
-      };
-    },
-  },
+  getters: {},
   actions: {
     calcStatusCount(criteria: PerformanceCriteria[]) {
       if (criteria) {
@@ -91,36 +44,107 @@ export const useCompetenceStore = defineStore({
         unknown: 0,
       };
     },
-    async loadCompetenceProfilePage(slug: string, reload = false) {
-      this.competenceProfilePage = await itGetCached(`/api/course/page/${slug}/`, {
+    criteriaByCompetence(competence: CompetencePage) {
+      return competence.children.filter((criteria) => {
+        if (this.selectedCircle.id != "all") {
+          return criteria.circle.translation_key === this.selectedCircle.id;
+        }
+
+        return competence.children;
+      });
+    },
+    flatPerformanceCriteria(userId: number | undefined = undefined) {
+      if (!userId) {
+        const userStore = useUserStore();
+        userId = userStore.id;
+      }
+
+      if (this.competenceProfilePages.get(userId)) {
+        const competenceProfilePage = this.competenceProfilePages.get(userId);
+        if (competenceProfilePage) {
+          let criteria = _.orderBy(
+            competenceProfilePage.children.flatMap((competence) => {
+              return competence.children;
+            }),
+            ["competence_id"],
+            ["asc"]
+          );
+
+          if (this.selectedCircle.id !== "all") {
+            criteria = criteria.filter(
+              (c) => c.circle.translation_key === this.selectedCircle.id
+            );
+          }
+
+          return criteria;
+        }
+      }
+
+      return [];
+    },
+    competences(userId: number | undefined = undefined) {
+      if (!userId) {
+        const userStore = useUserStore();
+        userId = userStore.id;
+      }
+
+      if (this.competenceProfilePages.get(userId)) {
+        const competenceProfilePage = this.competenceProfilePages.get(userId);
+
+        if (competenceProfilePage?.children.length) {
+          return competenceProfilePage.children.filter((competence) => {
+            let criteria = competence.children;
+            if (this.selectedCircle.id != "all") {
+              criteria = criteria.filter((criteria) => {
+                return criteria.circle.translation_key === this.selectedCircle.id;
+              });
+            }
+            return criteria.length > 0;
+          });
+        }
+      }
+
+      return [];
+    },
+    async loadCompetenceProfilePage(
+      slug: string,
+      userId: number | undefined = undefined,
+      reload = false
+    ) {
+      if (!userId) {
+        const userStore = useUserStore();
+        userId = userStore.id;
+      }
+      const competenceProfilePage = await itGetCached(`/api/course/page/${slug}/`, {
         reload: reload,
       });
 
-      if (!this.competenceProfilePage) {
+      if (!competenceProfilePage) {
         throw `No competenceProfilePageData found with: ${slug}`;
       }
 
-      const circles = this.competenceProfilePage.circles.map((c: CircleLight) => {
+      this.competenceProfilePages.set(userId, competenceProfilePage);
+
+      const circles = competenceProfilePage.circles.map((c: CircleLight) => {
         return { id: c.translation_key, name: `Circle: ${c.title}` };
       });
       this.availableCircles = [{ id: "all", name: "Circle: Alle" }, ...circles];
 
-      await this.parseCompletionData();
+      await this.parseCompletionData(userId);
 
-      return this.competenceProfilePage;
+      return this.competenceProfilePages.get(userId);
     },
-    async parseCompletionData() {
-      const userStore = useUserStore();
-
-      if (this.competenceProfilePage && userStore.loggedIn) {
+    async parseCompletionData(userId: number) {
+      const competenceProfilePage = this.competenceProfilePages.get(userId);
+      if (competenceProfilePage) {
         const completionStore = useCompletionStore();
         const completionData = await completionStore.loadCompletionData(
-          this.competenceProfilePage.course.id,
-          userStore.id
+          competenceProfilePage.course.id,
+          userId
         );
 
         if (completionData) {
-          this.competenceProfilePage.children.forEach((competence) => {
+          competenceProfilePage.children.forEach((competence) => {
             competence.children.forEach((performanceCriteria) => {
               const completion = completionData.find(
                 (c) => c.page_key === performanceCriteria.translation_key
diff --git a/client/src/stores/completion.ts b/client/src/stores/completion.ts
index ae4d1ded..5bd9ec64 100644
--- a/client/src/stores/completion.ts
+++ b/client/src/stores/completion.ts
@@ -1,48 +1,46 @@
 import { bustItGetCache, itGetCached, itPost } from "@/fetchHelpers";
+import { useUserStore } from "@/stores/user";
 import type { BaseCourseWagtailPage, CourseCompletion } from "@/types";
 import { defineStore } from "pinia";
 
-export type CompletionStoreState = {
-  completionStore: Map<number, CourseCompletion[]>;
-};
-
 export const useCompletionStore = defineStore({
   id: "completion",
   state: () => {
-    return {
-      completionStore: new Map(),
-    } as CompletionStoreState;
+    return {};
   },
   getters: {},
   actions: {
     async loadCompletionData(courseId: number, userId: number, reload = false) {
-      const userCompletionData = await itGetCached(
+      const userCompletionData = (await itGetCached(
         `/api/course/completion/${courseId}/${userId}/`,
         {
           reload: reload,
         }
-      );
+      )) as CourseCompletion[];
 
       if (userCompletionData === undefined) {
         throw `No completionData found with: ${courseId}, ${userId}`;
       }
-
-      this.completionStore.set(userId, userCompletionData);
-
-      return this.completionStore.get(userId) || [];
+      return userCompletionData || [];
     },
-    async markPage(page: BaseCourseWagtailPage, userId: number) {
+    async markPage(
+      page: BaseCourseWagtailPage,
+      userId: number | undefined = undefined
+    ) {
       const completionData = await itPost("/api/course/completion/mark/", {
         page_key: page.translation_key,
         completion_status: page.completion_status,
       });
 
       if (completionData && completionData.length > 0) {
-        this.completionStore.set(userId, completionData);
-        bustItGetCache(`/api/course/completion/${completionData[0].course}/`);
+        if (!userId) {
+          const userStore = useUserStore();
+          userId = userStore.id;
+        }
+        bustItGetCache(`/api/course/completion/${completionData[0].course}/${userId}/`);
       }
 
-      return this.completionStore.get(userId) || [];
+      return completionData as CourseCompletion[];
     },
   },
 });