From a921d5f5486ede01e7c3ba579684c0d80659df20 Mon Sep 17 00:00:00 2001 From: Livio Bieri Date: Fri, 2 Feb 2024 18:52:06 +0100 Subject: [PATCH] fix: make test more robust ;) --- .../self_evaluation_feedback/tests/test_api.py | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/server/vbv_lernwelt/self_evaluation_feedback/tests/test_api.py b/server/vbv_lernwelt/self_evaluation_feedback/tests/test_api.py index b8dca557..98291bbc 100644 --- a/server/vbv_lernwelt/self_evaluation_feedback/tests/test_api.py +++ b/server/vbv_lernwelt/self_evaluation_feedback/tests/test_api.py @@ -433,10 +433,11 @@ class SelfEvaluationFeedbackAPI(APITestCase): def test_get_self_evaluation_feedback_frontend_urls(self): """Makes sure that the frontend urls are correct (used in notifications)""" - # GIVEN + learning_unit = create_learning_unit(course=self.course, circle=self.circle) + cut = create_self_evaluation_feedback( - learning_unit=create_learning_unit(course=self.course, circle=self.circle), + learning_unit=learning_unit, feedback_requester_user=self.member, feedback_provider_user=self.mentor, ) @@ -446,13 +447,17 @@ class SelfEvaluationFeedbackAPI(APITestCase): provider_url = cut.feedback_provider_evaluation_url # THEN + _course, _circle, _learning_unit = learning_unit.get_frontend_url_parts() + + # 0 -> no completions so step=0 is correct + _step = len(learning_unit.performancecriteria_set.all()) + self.assertEqual( requester_url, - # 0 -> no completions so step=0 is correct - "/course/test-lehrgang/learn/test-circle/evaluate/course-category?step=0", + f"/course/{_course}/learn/{_circle}/evaluate/{_learning_unit}?step={_step}", ) self.assertEqual( provider_url, - "/course/test-lehrgang/cockpit/mentor/self-evaluation-feedback/34", + f"/course/{_course}/cockpit/mentor/self-evaluation-feedback/{learning_unit.id}", )