From aa67c2c8b72d99f402c4d1548dfb933d2bcca9d9 Mon Sep 17 00:00:00 2001
From: Daniel Egger <daniel.egger@gmail.com>
Date: Sat, 14 Oct 2023 01:42:24 +0200
Subject: [PATCH] Remove unneeded feedbackSummary

---
 .../components/feedback/feedbackSummary.vue   | 101 ------------------
 .../feedback/FeedbackBlock.vue                |   8 +-
 2 files changed, 3 insertions(+), 106 deletions(-)
 delete mode 100644 client/src/components/feedback/feedbackSummary.vue

diff --git a/client/src/components/feedback/feedbackSummary.vue b/client/src/components/feedback/feedbackSummary.vue
deleted file mode 100644
index d623b769..00000000
--- a/client/src/components/feedback/feedbackSummary.vue
+++ /dev/null
@@ -1,101 +0,0 @@
-<template>
-  <div class="mb-4 bg-white px-6 py-5">
-    <h3 class="heading-3 mb-4 flex items-center gap-2">
-      <it-icon-feedback-large class="h-16 w-16"></it-icon-feedback-large>
-      <div>{{ $t("general.feedback_other") }}</div>
-    </h3>
-    <ol v-if="feedbackSummary.length > 0">
-      <ItRow v-for="feedbacks in feedbackSummary" :key="feedbacks.circle_id">
-        <template #firstRow>
-          <span class="text-bold">{{ $t("feedback.circleFeedback") }}</span>
-        </template>
-        <template #center>
-          <div class="flex w-full justify-between">
-            <div>{{ $t("a.Circle") }}: {{ feedbacks.circle.title }}</div>
-            <div>{{ $t("feedback.sentByUsers", { count: feedbacks.count }) }}</div>
-          </div>
-        </template>
-        <template #link>
-          <router-link
-            :to="`${url}/cockpit/feedback/${feedbacks.circle_id}`"
-            class="w-full text-right underline"
-          >
-            {{ $t("feedback.showDetails") }}
-          </router-link>
-        </template>
-      </ItRow>
-    </ol>
-    <p v-else>{{ $t("feedback.noFeedbacks") }}</p>
-  </div>
-</template>
-
-<script setup lang="ts">
-import ItRow from "@/components/ui/ItRow.vue";
-import { itGet } from "@/fetchHelpers";
-import { onMounted, ref, watch } from "vue";
-
-import type { OldCircle } from "@/services/oldCircle";
-
-interface FeedbackSummary {
-  circle_id: string;
-  count: number;
-}
-
-interface FeedbackDisplaySummary extends FeedbackSummary {
-  circle: OldCircle;
-}
-
-function makeSummary(
-  feedbackData: FeedbackSummary[],
-  circles: OldCircle[],
-  selectedCircles: string[]
-) {
-  const summary: FeedbackDisplaySummary[] = circles
-    .filter((circle) => selectedCircles.includes(circle.translation_key))
-    .reduce((acc: FeedbackDisplaySummary[], circle) => {
-      const circleFeedbacks = feedbackData
-        .filter((data) => data.circle_id === circle.id)
-        .map((data) => Object.assign({}, data, { circle }));
-
-      return acc.concat(circleFeedbacks);
-    }, []);
-  return summary;
-}
-
-const props = defineProps<{
-  selctedCircles: string[];
-  circles: OldCircle[];
-  courseSessionId: string;
-  url: string;
-}>();
-
-const feedbackSummary = ref<FeedbackDisplaySummary[]>([]);
-let feedbackData: FeedbackSummary[] = [];
-
-onMounted(async () => {
-  feedbackData = await itGet(`/api/core/feedback/${props.courseSessionId}/summary`);
-  feedbackSummary.value = makeSummary(
-    feedbackData,
-    props.circles,
-    props.selctedCircles
-  );
-});
-
-watch(
-  () => props,
-  () => {
-    if (
-      feedbackData.length > 0 &&
-      props.circles.length > 0 &&
-      props.selctedCircles.length > 0
-    ) {
-      feedbackSummary.value = makeSummary(
-        feedbackData,
-        props.circles,
-        props.selctedCircles
-      );
-    }
-  },
-  { deep: true }
-);
-</script>
diff --git a/client/src/pages/learningPath/learningContentPage/feedback/FeedbackBlock.vue b/client/src/pages/learningPath/learningContentPage/feedback/FeedbackBlock.vue
index b8f599f2..c36838f9 100644
--- a/client/src/pages/learningPath/learningContentPage/feedback/FeedbackBlock.vue
+++ b/client/src/pages/learningPath/learningContentPage/feedback/FeedbackBlock.vue
@@ -9,7 +9,6 @@ import {
   YES_NO,
 } from "@/pages/learningPath/learningContentPage/feedback/feedback.constants";
 import LearningContentMultiLayout from "@/pages/learningPath/learningContentPage/layouts/LearningContentMultiLayout.vue";
-import { useCircleStore } from "@/stores/circle";
 import type { LearningContentFeedback } from "@/types";
 import { useMutation } from "@urql/vue";
 import { useRouteQuery } from "@vueuse/router";
@@ -22,7 +21,6 @@ const props = defineProps<{
   content: LearningContentFeedback;
 }>();
 const courseSession = useCurrentCourseSession();
-const circleStore = useCircleStore();
 const courseSessionDetailResult = useCourseSessionDetailQuery();
 
 const { t } = useTranslation();
@@ -30,12 +28,12 @@ const { t } = useTranslation();
 const stepNo = useRouteQuery("step", "0", { transform: Number, mode: "push" });
 
 const title = computed(
-  () => `«${circleStore.circle?.title}»: ${t("feedback.areYouSatisfied")}`
+  () => `«${props.content.circle?.title}»: ${t("feedback.areYouSatisfied")}`
 );
 
 const circleExperts = computed(() => {
-  if (circleStore.circle) {
-    return courseSessionDetailResult.filterCircleExperts(circleStore.circle.slug);
+  if (props.content?.circle?.slug) {
+    return courseSessionDetailResult.filterCircleExperts(props.content.circle.slug);
   }
   return [];
 });