From bf5482e39c1434ca1047bff285899b90c4ac869a Mon Sep 17 00:00:00 2001
From: Ramon Wenger <ramon.wenger@iterativ.ch>
Date: Wed, 31 Jul 2024 15:20:07 +0200
Subject: [PATCH] Replace the course profile filter pills with a dropdown

---
 client/src/components/ui/ItDropdownSelect.vue |  7 +--
 .../LearningPathProfileFilter.vue             | 47 +++++++++++--------
 server/vbv_lernwelt/course/graphql/types.py   |  4 +-
 3 files changed, 31 insertions(+), 27 deletions(-)

diff --git a/client/src/components/ui/ItDropdownSelect.vue b/client/src/components/ui/ItDropdownSelect.vue
index 8a9c3139..b1cb47df 100644
--- a/client/src/components/ui/ItDropdownSelect.vue
+++ b/client/src/components/ui/ItDropdownSelect.vue
@@ -5,17 +5,14 @@ import { computed } from "vue"; // https://stackoverflow.com/questions/64775876/
 
 // https://stackoverflow.com/questions/64775876/vue-3-pass-reactive-object-to-component-with-two-way-binding
 interface Props {
-  modelValue?: {
-    id: string | number;
-    name: string;
-  };
+  modelValue?: DropdownSelectable;
   items?: DropdownSelectable[];
   borderless?: boolean;
   placeholderText?: string | null;
 }
 
 const emit = defineEmits<{
-  (e: "update:modelValue", data: object): void;
+  (e: "update:modelValue", data: DropdownSelectable): void;
 }>();
 
 const props = withDefaults(defineProps<Props>(), {
diff --git a/client/src/pages/learningPath/learningPathPage/LearningPathProfileFilter.vue b/client/src/pages/learningPath/learningPathPage/LearningPathProfileFilter.vue
index cad73d41..4dce5785 100644
--- a/client/src/pages/learningPath/learningPathPage/LearningPathProfileFilter.vue
+++ b/client/src/pages/learningPath/learningPathPage/LearningPathProfileFilter.vue
@@ -1,35 +1,44 @@
 <script lang="ts" setup>
-import { COURSE_PROFILE_ALL_FILTER } from "@/constants";
+import ItDropdownSelect from "@/components/ui/ItDropdownSelect.vue";
+import type { DropdownSelectable } from "@/types";
+import { useTranslation } from "i18next-vue";
+import { computed } from "vue";
 
 interface Props {
   profiles?: string[];
   selected?: string;
 }
-const allProfile = COURSE_PROFILE_ALL_FILTER;
 
-defineProps<Props>();
-defineEmits(["select"]);
+const props = defineProps<Props>();
+const emit = defineEmits(["select"]);
+
+const { t } = useTranslation();
+const items = computed(() => {
+  return props.profiles?.map((p) => ({ id: p, name: t(`profile.${p}`) })) || [];
+});
+
+const selectedItem = computed(() => {
+  if (props.selected) {
+    return { id: props.selected || "", name: t(`profile.${props.selected}`) };
+  }
+  return { id: "", name: "" };
+});
+
+const updateFilter = (e: DropdownSelectable) => {
+  emit("select", e.id);
+};
 </script>
 
 <template>
   <div class="flex-grow">
     <h5 class="mb-4">Zulassungsprofil:</h5>
     <div class="mb-4 flex gap-4">
-      <button
-        v-for="profile in profiles"
-        :key="profile"
-        :class="
-          selected == profile || !selected || selected === allProfile
-            ? 'tag-active'
-            : 'tag-inactive'
-        "
-        @click="$emit('select', profile)"
-      >
-        {{ $t(`profile.${profile}`) }}
-      </button>
+      <ItDropdownSelect
+        :items="items"
+        class="min-w-[18rem]"
+        :model-value="selectedItem"
+        @update:model-value="updateFilter"
+      />
     </div>
-    <a class="link" @click="$emit('select', allProfile)">
-      Alle anzeigen ({{ $t(`profile.${allProfile}`) }})
-    </a>
   </div>
 </template>
diff --git a/server/vbv_lernwelt/course/graphql/types.py b/server/vbv_lernwelt/course/graphql/types.py
index cbec6854..934fa119 100644
--- a/server/vbv_lernwelt/course/graphql/types.py
+++ b/server/vbv_lernwelt/course/graphql/types.py
@@ -136,9 +136,7 @@ class CourseObjectType(DjangoObjectType):
     @staticmethod
     def resolve_profiles(root: Course, info, **kwargs):
         if root.configuration.is_vv:
-            return CourseProfile.objects.exclude(id=COURSE_PROFILE_ALL_ID).values_list(
-                "code", flat=True
-            )
+            return CourseProfile.objects.values_list("code", flat=True)
         return []
 
     @staticmethod