From e2347d8571a571ce1dfaad04553cf81d5bf6f12a Mon Sep 17 00:00:00 2001
From: Daniel Egger <daniel.egger@gmail.com>
Date: Mon, 8 May 2023 16:03:26 +0200
Subject: [PATCH] Rename `courseSessionStore` to `courseSessionsStore`

---
 .../src/pages/cockpit/CockpitParentPage.vue   |  4 +--
 client/src/pages/cockpit/FeedbackPage.vue     |  4 +--
 .../AssignmentEvaluationPage.vue              |  8 ++---
 .../EvaluationContainer.vue                   | 31 ++-----------------
 .../EvaluationIntro.vue                       |  4 +--
 .../EvaluationSummary.vue                     |  4 +--
 .../EvaluationTask.vue                        |  4 +--
 .../assignmentsPage/AssignmentsPage.vue       | 16 +++++++---
 .../pages/cockpit/cockpitPage/CockpitPage.vue | 10 +++---
 .../circlePage/DocumentSection.vue            |  4 +--
 .../assignment/AssignmentSubmissionView.vue   |  6 ++--
 .../assignment/AssignmentTaskView.vue         |  6 ++--
 .../assignment/AssignmentView.vue             |  4 +--
 client/src/router/index.ts                    |  6 ++--
 client/src/stores/assignmentStore.ts          | 28 +++++++++++++++++
 15 files changed, 74 insertions(+), 65 deletions(-)

diff --git a/client/src/pages/cockpit/CockpitParentPage.vue b/client/src/pages/cockpit/CockpitParentPage.vue
index 9417979f..9a3882be 100644
--- a/client/src/pages/cockpit/CockpitParentPage.vue
+++ b/client/src/pages/cockpit/CockpitParentPage.vue
@@ -16,13 +16,13 @@ const props = defineProps<{
 const cockpitStore = useCockpitStore();
 const competenceStore = useCompetenceStore();
 const learningPathStore = useLearningPathStore();
-const courseSessionStore = useCourseSessionsStore();
+const courseSessionsStore = useCourseSessionsStore();
 
 onMounted(async () => {
   log.debug("CockpitParentPage mounted", props.courseSlug);
 
   try {
-    const currentCourseSession = courseSessionStore.currentCourseSession;
+    const currentCourseSession = courseSessionsStore.currentCourseSession;
     if (currentCourseSession?.id) {
       await cockpitStore.loadCourseSessionUsers(currentCourseSession.id);
       cockpitStore.courseSessionUsers?.forEach((csu) => {
diff --git a/client/src/pages/cockpit/FeedbackPage.vue b/client/src/pages/cockpit/FeedbackPage.vue
index cf8f6996..63b5eb58 100644
--- a/client/src/pages/cockpit/FeedbackPage.vue
+++ b/client/src/pages/cockpit/FeedbackPage.vue
@@ -79,7 +79,7 @@ const props = defineProps<{
 
 log.debug("FeedbackPage created", props.circleId);
 
-const courseSessionStore = useCourseSessionsStore();
+const courseSessionsStore = useCourseSessionsStore();
 const { t } = useI18n();
 
 const orderedQuestions = [
@@ -149,7 +149,7 @@ const feedbackData = reactive<FeedbackData>({ amount: 0, questions: {} });
 onMounted(async () => {
   log.debug("FeedbackPage mounted");
   const data = await itGet(
-    `/api/core/feedback/${courseSessionStore.currentCourseSession?.course.id}/${props.circleId}`
+    `/api/core/feedback/${courseSessionsStore.currentCourseSession?.course.id}/${props.circleId}`
   );
   Object.assign(feedbackData, data);
 });
diff --git a/client/src/pages/cockpit/assignmentEvaluationPage/AssignmentEvaluationPage.vue b/client/src/pages/cockpit/assignmentEvaluationPage/AssignmentEvaluationPage.vue
index d258e32e..a700e108 100644
--- a/client/src/pages/cockpit/assignmentEvaluationPage/AssignmentEvaluationPage.vue
+++ b/client/src/pages/cockpit/assignmentEvaluationPage/AssignmentEvaluationPage.vue
@@ -34,14 +34,14 @@ const state: StateInterface = reactive({
 });
 
 const assignmentStore = useAssignmentStore();
-const courseSessionStore = useCourseSessionsStore();
+const courseSessionsStore = useCourseSessionsStore();
 const router = useRouter();
 
 onMounted(async () => {
   log.debug("AssignmentView mounted", props.assignmentId, props.userId);
 
-  if (courseSessionStore.currentCourseSession) {
-    state.assignmentUser = courseSessionStore.currentCourseSession.users.find(
+  if (courseSessionsStore.currentCourseSession) {
+    state.assignmentUser = courseSessionsStore.currentCourseSession.users.find(
       (user) => user.user_id === Number(props.userId)
     );
   }
@@ -50,7 +50,7 @@ onMounted(async () => {
     state.assignment = await assignmentStore.loadAssignment(props.assignmentId);
     await assignmentStore.loadAssignmentCompletion(
       props.assignmentId,
-      courseSessionStore.currentCourseSession!.id,
+      courseSessionsStore.currentCourseSession!.id,
       props.userId
     );
   } catch (error) {
diff --git a/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationContainer.vue b/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationContainer.vue
index bce6829a..2e64c352 100644
--- a/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationContainer.vue
+++ b/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationContainer.vue
@@ -2,11 +2,7 @@
 import EvaluationIntro from "@/pages/cockpit/assignmentEvaluationPage/EvaluationIntro.vue";
 import EvaluationSummary from "@/pages/cockpit/assignmentEvaluationPage/EvaluationSummary.vue";
 import EvaluationTask from "@/pages/cockpit/assignmentEvaluationPage/EvaluationTask.vue";
-import { calcAssignmentLearningContents } from "@/services/assignmentService";
 import { useAssignmentStore } from "@/stores/assignmentStore";
-import { useCourseSessionsStore } from "@/stores/courseSessions";
-import { useLearningPathStore } from "@/stores/learningPath";
-import { useUserStore } from "@/stores/user";
 import type {
   Assignment,
   AssignmentCompletion,
@@ -35,7 +31,6 @@ const state: StateInterface = reactive({
   pageIndex: 0,
 });
 
-const courseSessionStore = useCourseSessionsStore();
 const assignmentStore = useAssignmentStore();
 
 const numTasks = computed(() => props.assignment.evaluation_tasks?.length ?? 0);
@@ -70,29 +65,9 @@ function editTask(task: AssignmentEvaluationTask) {
   state.pageIndex = taskIndex + 1;
 }
 
-function findAssignmentDetail() {
-  const learningPathStore = useLearningPathStore();
-  const userStore = useUserStore();
-  // TODO: filter by selected circle
-  if (!courseSessionStore.currentCourseSession) {
-    return undefined;
-  }
-
-  const learningContents = calcAssignmentLearningContents(
-    learningPathStore.learningPathForUser(
-      courseSessionStore.currentCourseSession.course.slug,
-      userStore.id
-    )
-  );
-
-  const learningContent = learningContents.find(
-    (lc) => lc.assignmentId === props.assignment.id
-  );
-
-  return courseSessionStore.findAssignmentDetails(learningContent?.id);
-}
-
-const assignmentDetail = computed(() => findAssignmentDetail());
+const assignmentDetail = computed(() =>
+  assignmentStore.findAssignmentDetail(props.assignment.id)
+);
 
 const dueDate = computed(() =>
   dayjs(assignmentDetail.value?.evaluationDeadlineDateTimeUtc)
diff --git a/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationIntro.vue b/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationIntro.vue
index 1a79b042..7fea4bb7 100644
--- a/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationIntro.vue
+++ b/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationIntro.vue
@@ -16,7 +16,7 @@ const emit = defineEmits(["startEvaluation"]);
 
 log.debug("EvaluationIntro setup");
 
-const courseSessionStore = useCourseSessionsStore();
+const courseSessionsStore = useCourseSessionsStore();
 const assignmentStore = useAssignmentStore();
 
 async function startEvaluation() {
@@ -24,7 +24,7 @@ async function startEvaluation() {
   await assignmentStore.evaluateAssignmentCompletion({
     assignment_user_id: Number(props.assignmentUser.user_id),
     assignment_id: props.assignment.id,
-    course_session_id: courseSessionStore.currentCourseSession!.id,
+    course_session_id: courseSessionsStore.currentCourseSession!.id,
     completion_data: {},
     completion_status: "evaluation_in_progress",
   });
diff --git a/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationSummary.vue b/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationSummary.vue
index 3b5d9f3b..c6d58d65 100644
--- a/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationSummary.vue
+++ b/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationSummary.vue
@@ -32,7 +32,7 @@ const state = reactive({
 
 log.debug("EvaluationSummary setup");
 
-const courseSessionStore = useCourseSessionsStore();
+const courseSessionsStore = useCourseSessionsStore();
 const assignmentStore = useAssignmentStore();
 
 async function submitEvaluation() {
@@ -40,7 +40,7 @@ async function submitEvaluation() {
   await assignmentStore.evaluateAssignmentCompletion({
     assignment_user_id: Number(props.assignmentUser.user_id),
     assignment_id: props.assignment.id,
-    course_session_id: courseSessionStore.currentCourseSession!.id,
+    course_session_id: courseSessionsStore.currentCourseSession!.id,
     completion_data: {},
     completion_status: "evaluation_submitted",
     evaluation_grade: grade.value,
diff --git a/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationTask.vue b/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationTask.vue
index b9ac4c82..d30590e4 100644
--- a/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationTask.vue
+++ b/client/src/pages/cockpit/assignmentEvaluationPage/EvaluationTask.vue
@@ -20,7 +20,7 @@ const props = defineProps<{
 
 log.debug("EvaluationTask setup", props.taskIndex);
 
-const courseSessionStore = useCourseSessionsStore();
+const courseSessionsStore = useCourseSessionsStore();
 const assignmentStore = useAssignmentStore();
 
 const task = computed(() => props.assignment.evaluation_tasks[props.taskIndex]);
@@ -60,7 +60,7 @@ async function evaluateAssignmentCompletion(completionData: AssignmentCompletion
   return assignmentStore.evaluateAssignmentCompletion({
     assignment_user_id: Number(props.assignmentUser.user_id),
     assignment_id: props.assignment.id,
-    course_session_id: courseSessionStore.currentCourseSession!.id,
+    course_session_id: courseSessionsStore.currentCourseSession!.id,
     completion_data: completionData,
     completion_status: "evaluation_in_progress",
   });
diff --git a/client/src/pages/cockpit/assignmentsPage/AssignmentsPage.vue b/client/src/pages/cockpit/assignmentsPage/AssignmentsPage.vue
index f91b5663..74e896e7 100644
--- a/client/src/pages/cockpit/assignmentsPage/AssignmentsPage.vue
+++ b/client/src/pages/cockpit/assignmentsPage/AssignmentsPage.vue
@@ -1,6 +1,7 @@
 <script setup lang="ts">
 import AssignmentDetails from "@/pages/cockpit/assignmentsPage/AssignmentDetails.vue";
 import { calcAssignmentLearningContents } from "@/services/assignmentService";
+import { useAssignmentStore } from "@/stores/assignmentStore";
 import { useCourseSessionsStore } from "@/stores/courseSessions";
 import { useLearningPathStore } from "@/stores/learningPath";
 import { useUserStore } from "@/stores/user";
@@ -14,8 +15,9 @@ const props = defineProps<{
 log.debug("AssignmentsPage created", props.courseSlug);
 
 const learningPathStore = useLearningPathStore();
-const courseSessionStore = useCourseSessionsStore();
+const courseSessionsStore = useCourseSessionsStore();
 const userStore = useUserStore();
+const assignmentStore = useAssignmentStore();
 
 onMounted(async () => {
   log.debug("AssignmentsPage mounted");
@@ -23,22 +25,26 @@ onMounted(async () => {
 
 const assignments = computed(() => {
   // TODO: filter by selected circle
-  if (!courseSessionStore.currentCourseSession) {
+  if (!courseSessionsStore.currentCourseSession) {
     return [];
   }
 
   return calcAssignmentLearningContents(
     learningPathStore.learningPathForUser(
-      courseSessionStore.currentCourseSession.course.slug,
+      courseSessionsStore.currentCourseSession.course.slug,
       userStore.id
     )
   );
 });
+
+const assignmentDetail = computed(
+  () => (assignmentId) => assignmentStore.findAssignmentDetail(assignmentId)
+);
 </script>
 
 <template>
   <div class="bg-gray-200">
-    <div v-if="courseSessionStore.currentCourseSession" class="container-large">
+    <div v-if="courseSessionsStore.currentCourseSession" class="container-large">
       <nav class="py-4 pb-4">
         <router-link
           class="btn-text inline-flex items-center pl-0"
@@ -58,7 +64,7 @@ const assignments = computed(() => {
         <div v-for="assignment in assignments" :key="assignment.id">
           <div class="bg-white p-6">
             <AssignmentDetails
-              :course-session="courseSessionStore.currentCourseSession"
+              :course-session="courseSessionsStore.currentCourseSession"
               :assignment="assignment"
             />
           </div>
diff --git a/client/src/pages/cockpit/cockpitPage/CockpitPage.vue b/client/src/pages/cockpit/cockpitPage/CockpitPage.vue
index 52a49f69..931bebf1 100644
--- a/client/src/pages/cockpit/cockpitPage/CockpitPage.vue
+++ b/client/src/pages/cockpit/cockpitPage/CockpitPage.vue
@@ -25,7 +25,7 @@ const userStore = useUserStore();
 const cockpitStore = useCockpitStore();
 const competenceStore = useCompetenceStore();
 const learningPathStore = useLearningPathStore();
-const courseSessionStore = useCourseSessionsStore();
+const courseSessionsStore = useCourseSessionsStore();
 
 function userCountStatusForCircle(userId: number, translationKey: string) {
   const criteria = competenceStore.flatPerformanceCriteria(
@@ -103,8 +103,8 @@ function setActiveClasses(translationKey: string) {
       <!-- Status -->
       <div class="mb-4 grid grid-rows-2 gap-4 lg:grid-cols-2 lg:grid-rows-none">
         <AssignmentsTile
-          v-if="courseSessionStore.currentCourseSession"
-          :course-session="courseSessionStore.currentCourseSession"
+          v-if="courseSessionsStore.currentCourseSession"
+          :course-session="courseSessionsStore.currentCourseSession"
         />
         <div class="bg-white px-6 py-5">
           <h3 class="heading-3 mb-4 flex items-center gap-2">
@@ -124,8 +124,8 @@ function setActiveClasses(translationKey: string) {
           learningPathStore.learningPathForUser(props.courseSlug, userStore.id)
             ?.circles || []
         "
-        :course-id="courseSessionStore.currentCourseSession?.course.id || 0"
-        :url="courseSessionStore.currentCourseSession?.course_url || ''"
+        :course-id="courseSessionsStore.currentCourseSession?.course.id || 0"
+        :url="courseSessionsStore.currentCourseSession?.course_url || ''"
       ></FeedbackSummary>
       <div>
         <!-- progress -->
diff --git a/client/src/pages/learningPath/circlePage/DocumentSection.vue b/client/src/pages/learningPath/circlePage/DocumentSection.vue
index 3275fded..e22eb289 100644
--- a/client/src/pages/learningPath/circlePage/DocumentSection.vue
+++ b/client/src/pages/learningPath/circlePage/DocumentSection.vue
@@ -115,8 +115,8 @@ async function uploadDocument(data: DocumentUploadData) {
       data,
       courseSessionsStore.currentCourseSession.id
     );
-    const courseSessionStore = useCourseSessionsStore();
-    courseSessionStore.addDocument(newDocument);
+    const courseSessionsStore = useCourseSessionsStore();
+    courseSessionsStore.addDocument(newDocument);
     showUploadModal.value = false;
     isUploading.value = false;
   } catch (error) {
diff --git a/client/src/pages/learningPath/learningContentPage/assignment/AssignmentSubmissionView.vue b/client/src/pages/learningPath/learningContentPage/assignment/AssignmentSubmissionView.vue
index 306f1ae1..140cb3b1 100644
--- a/client/src/pages/learningPath/learningContentPage/assignment/AssignmentSubmissionView.vue
+++ b/client/src/pages/learningPath/learningContentPage/assignment/AssignmentSubmissionView.vue
@@ -23,7 +23,7 @@ const emit = defineEmits<{
 }>();
 
 const assignmentStore = useAssignmentStore();
-const courseSessionStore = useCourseSessionsStore();
+const courseSessionsStore = useCourseSessionsStore();
 const { t } = useI18n();
 
 const state = reactive({
@@ -32,7 +32,7 @@ const state = reactive({
 });
 
 const circleExpert = computed(() => {
-  return courseSessionStore.circleExperts[0];
+  return courseSessionsStore.circleExperts[0];
 });
 
 const circleExpertName = computed(() => {
@@ -49,7 +49,7 @@ const onEditTask = (task: AssignmentTask) => {
 
 const onSubmit = async () => {
   try {
-    const courseSessionId = courseSessionStore.currentCourseSession?.id;
+    const courseSessionId = courseSessionsStore.currentCourseSession?.id;
     if (!courseSessionId) {
       log.error("Invalid courseSessionId");
       return;
diff --git a/client/src/pages/learningPath/learningContentPage/assignment/AssignmentTaskView.vue b/client/src/pages/learningPath/learningContentPage/assignment/AssignmentTaskView.vue
index e1a43322..8ae9bac1 100644
--- a/client/src/pages/learningPath/learningContentPage/assignment/AssignmentTaskView.vue
+++ b/client/src/pages/learningPath/learningContentPage/assignment/AssignmentTaskView.vue
@@ -23,12 +23,12 @@ const lastSaveUnsuccessful = ref(false);
 
 const checkboxState = reactive({} as Record<string, boolean>);
 
-const courseSessionStore = useCourseSessionsStore();
+const courseSessionsStore = useCourseSessionsStore();
 const assignmentStore = useAssignmentStore();
 
 async function upsertAssignmentCompletion(completion_data: AssignmentCompletionData) {
   try {
-    const courseSessionId = courseSessionStore.currentCourseSession?.id;
+    const courseSessionId = courseSessionsStore.currentCourseSession?.id;
     if (!courseSessionId) {
       console.error("Invalid courseSessionId");
       return;
@@ -113,9 +113,9 @@ const completionStatus = computed(() => {
       </div>
       <div v-if="block.type === 'user_text_input'">
         <p
+          v-if="block.value.text"
           class="text-large pb-4"
           v-html="block.value.text"
-          v-if="block.value.text"
         ></p>
         <ItTextarea
           :model-value="(getBlockData(block.id) as string) ?? ''"
diff --git a/client/src/pages/learningPath/learningContentPage/assignment/AssignmentView.vue b/client/src/pages/learningPath/learningContentPage/assignment/AssignmentView.vue
index f7533084..bb88bf32 100644
--- a/client/src/pages/learningPath/learningContentPage/assignment/AssignmentView.vue
+++ b/client/src/pages/learningPath/learningContentPage/assignment/AssignmentView.vue
@@ -17,7 +17,7 @@ import { computed, onMounted, reactive } from "vue";
 import { useI18n } from "vue-i18n";
 
 const { t } = useI18n();
-const courseSessionStore = useCourseSessionsStore();
+const courseSessionsStore = useCourseSessionsStore();
 const assignmentStore = useAssignmentStore();
 
 interface State {
@@ -79,7 +79,7 @@ const dueDate = computed(() =>
   dayjs(state.courseSessionAssignmentDetails?.submissionDeadlineDateTimeUtc)
 );
 const courseSessionId = computed(
-  () => courseSessionStore.currentCourseSession?.id ?? 0
+  () => courseSessionsStore.currentCourseSession?.id ?? 0
 );
 const currentTask = computed(() => {
   if (state.pageIndex > 0 && state.pageIndex <= numTasks.value) {
diff --git a/client/src/router/index.ts b/client/src/router/index.ts
index 8cbca9dc..81e2ab16 100644
--- a/client/src/router/index.ts
+++ b/client/src/router/index.ts
@@ -183,11 +183,11 @@ router.beforeEach(updateLoggedIn);
 router.beforeEach(redirectToLoginIfRequired);
 
 router.beforeEach((to) => {
-  const courseSessionStore = useCourseSessionsStore();
+  const courseSessionsStore = useCourseSessionsStore();
   if (to.params.courseSlug) {
-    courseSessionStore._currentCourseSlug = to.params.courseSlug as string;
+    courseSessionsStore._currentCourseSlug = to.params.courseSlug as string;
   } else {
-    courseSessionStore._currentCourseSlug = "";
+    courseSessionsStore._currentCourseSlug = "";
   }
 });
 
diff --git a/client/src/stores/assignmentStore.ts b/client/src/stores/assignmentStore.ts
index 5eecf7f7..c0ebb6d3 100644
--- a/client/src/stores/assignmentStore.ts
+++ b/client/src/stores/assignmentStore.ts
@@ -1,4 +1,8 @@
 import { itGet, itPost } from "@/fetchHelpers";
+import { calcAssignmentLearningContents } from "@/services/assignmentService";
+import { useCourseSessionsStore } from "@/stores/courseSessions";
+import { useLearningPathStore } from "@/stores/learningPath";
+import { useUserStore } from "@/stores/user";
 import type {
   Assignment,
   AssignmentCompletion,
@@ -78,5 +82,29 @@ export const useAssignmentStore = defineStore({
       }
       return responseData;
     },
+
+    findAssignmentDetail(assignmentId: number) {
+      const learningPathStore = useLearningPathStore();
+      const userStore = useUserStore();
+      const courseSessionsStore = useCourseSessionsStore();
+
+      // TODO: filter by selected circle
+      if (!courseSessionsStore.currentCourseSession) {
+        return undefined;
+      }
+
+      const learningContents = calcAssignmentLearningContents(
+        learningPathStore.learningPathForUser(
+          courseSessionsStore.currentCourseSession.course.slug,
+          userStore.id
+        )
+      );
+
+      const learningContent = learningContents.find(
+        (lc) => lc.assignmentId === assignmentId
+      );
+
+      return courseSessionsStore.findAssignmentDetails(learningContent?.id);
+    },
   },
 });