ramon
/
vbv
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove filter condition for filtering MEMBERS only

This commit is contained in:
Christian Cueni 2023-10-19 11:47:44 +02:00
parent 799ea85815
commit 5904df6634
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
server/vbv_lernwelt/feedback/views.py
View File

@ -5,7 +5,6 @@ from rest_framework.decorators import api_view
from rest_framework.exceptions import PermissionDenied from rest_framework.exceptions import PermissionDenied
from rest_framework.response import Response from rest_framework.response import Response
from vbv_lernwelt.course.models import CourseSessionUser
from vbv_lernwelt.course.permissions import is_course_session_expert from vbv_lernwelt.course.permissions import is_course_session_expert
from vbv_lernwelt.feedback.models import FeedbackResponse from vbv_lernwelt.feedback.models import FeedbackResponse
@ -59,9 +58,10 @@ def get_feedback_for_circle(request, course_session_id, circle_id):
submitted=True, submitted=True,
circle_id=circle_id, circle_id=circle_id,
# filter out experts that might have submitted just for testing # filter out experts that might have submitted just for testing
feedback_user__in=CourseSessionUser.objects.filter( # important: the commented code causes to return no feedbacks with prod data
course_session_id=course_session_id, role=CourseSessionUser.Role.MEMBER # feedback_user__in=CourseSessionUser.objects.filter(
).values_list("user", flat=True), # course_session_id=course_session_id, role=CourseSessionUser.Role.MEMBER
# ).values_list("user", flat=True),
).order_by("created_at") ).order_by("created_at")
# I guess this is ok for the üK case # I guess this is ok for the üK case