ramon
/
vbv
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: use same function to check performance criteria status

This commit is contained in:
Livio Bieri 2024-03-22 11:29:45 +01:00
parent 1831dcc363
commit 5d14bde805
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
client/src/services/circle.ts
View File

@ -58,9 +58,8 @@ export function allFinishedInLearningSequence(ls: LearningSequence) {
); );
const somePerformanceCriteriaRanked = const somePerformanceCriteriaRanked =
performanceCriteria.some((pc) => pc.completion_status === "SUCCESS") || performanceCriteriaHasStatus(performanceCriteria) ||
performanceCriteria.some((pc) => pc.completion_status === "FAIL") || performanceCriteria.length === 0; // no performance criteria -> treat as completed
performanceCriteria.length === 0;
return allLearningContentsCompleted && somePerformanceCriteriaRanked; return allLearningContentsCompleted && somePerformanceCriteriaRanked;
} }