ramon
/
vbv
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove automatic feedback creation in prepare scripts

This commit is contained in:
Daniel Egger 2023-09-26 13:40:51 +02:00
parent 3ae215296b
commit 7a037e05ec
3 changed files with 21 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
client/src/pages/learningPath/learningContentPage/feedback/FeedbackBlock.vue
View File

@ -50,7 +50,7 @@ const stepLabels = [
const numSteps = stepLabels.length; const numSteps = stepLabels.length;
// noinspection GraphQLUnresolvedReference // noinspection GraphQLUnresolvedReference -> mute IntelliJ warning
const sendFeedbackMutation = graphql(` const sendFeedbackMutation = graphql(`
mutation SendFeedbackMutation( mutation SendFeedbackMutation(
$courseSessionId: ID! $courseSessionId: ID!

37
server/vbv_lernwelt/course/management/commands/create_default_courses.py
View File

@ -86,7 +86,6 @@ from vbv_lernwelt.course_session.models import (
CourseSessionAssignment, CourseSessionAssignment,
CourseSessionAttendanceCourse, CourseSessionAttendanceCourse,
) )
from vbv_lernwelt.feedback.creators.create_demo_feedback import create_feedback
from vbv_lernwelt.importer.services import ( from vbv_lernwelt.importer.services import (
import_course_sessions_from_excel, import_course_sessions_from_excel,
import_students_from_excel, import_students_from_excel,
@ -237,10 +236,11 @@ def create_versicherungsvermittlerin_course(
circles = Circle.objects.filter( circles = Circle.objects.filter(
slug__startswith="versicherungsvermittler-in-lp" slug__startswith="versicherungsvermittler-in-lp"
) )
for i, circle in enumerate(circles):
expert = experts[i % len(experts)] # for i, circle in enumerate(circles):
expert.expert.add(circle) # expert = experts[i % len(experts)]
create_feedback(circle, cs, 3) # expert.expert.add(circle)
# create_feedback(circle, cs, 3)
for admin_email in ADMIN_EMAILS: for admin_email in ADMIN_EMAILS:
CourseSessionUser.objects.create( CourseSessionUser.objects.create(
@ -395,19 +395,20 @@ def create_course_uk_de_course_sessions():
user=User.objects.get(username="patrick.muster@eiger-versicherungen.ch"), user=User.objects.get(username="patrick.muster@eiger-versicherungen.ch"),
) )
create_feedback( # TODO: feedback must now contain a `feedback_user`
Circle.objects.get(slug="überbetriebliche-kurse-lp-circle-kickoff"), # create_feedback(
cs, # Circle.objects.get(slug="überbetriebliche-kurse-lp-circle-kickoff"),
3, # cs,
) # 3,
create_feedback( # )
Circle.objects.get(slug="überbetriebliche-kurse-lp-circle-haushalt-teil-2"), # create_feedback(
cs, # Circle.objects.get(slug="überbetriebliche-kurse-lp-circle-haushalt-teil-2"),
14, # cs,
) # 14,
create_feedback( # )
Circle.objects.get(slug="überbetriebliche-kurse-lp-circle-basis"), cs, 4 # create_feedback(
) # Circle.objects.get(slug="überbetriebliche-kurse-lp-circle-basis"), cs, 4
# )
def create_course_uk_fr(): def create_course_uk_fr():

1
server/vbv_lernwelt/feedback/creators/create_demo_feedback.py
View File

@ -5,4 +5,5 @@ from vbv_lernwelt.learnpath.models import Circle
def create_feedback(circle: Circle, course_session: CourseSession, amount: int): def create_feedback(circle: Circle, course_session: CourseSession, amount: int):
for _i in range(amount): for _i in range(amount):
# FIXME needs `feedback_user` to work again
FeedbackResponseFactory(circle=circle, course_session=course_session).save() FeedbackResponseFactory(circle=circle, course_session=course_session).save()