ramon
/
vbv
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merged in feature/VBV-635-invalid-emails (pull request #273) 

Handle invalid recipient email addresses

Approved-by: Daniel Egger
This commit is contained in:
Christian Cueni 2024-01-24 06:36:59 +00:00
parent b2c1e30b47 b1631b6b28
commit 7c89751850
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
server/vbv_lernwelt/notify/services.py
View File

@ -3,6 +3,8 @@ from __future__ import annotations
from typing import TYPE_CHECKING from typing import TYPE_CHECKING
import structlog import structlog
from django.core.exceptions import ValidationError
from django.core.validators import validate_email
from django.db.models import Model from django.db.models import Model
from notifications.signals import notify from notifications.signals import notify
@ -281,6 +283,13 @@ class NotificationService:
template_data=template_data, template_data=template_data,
) )
emailed = False emailed = False
try:
validate_email(recipient.email)
except ValidationError:
log.info("Recipient email is invalid")
return f"{notification_identifier}_invalid_email"
try: try:
notification = NotificationService._find_duplicate_notification( notification = NotificationService._find_duplicate_notification(
recipient=recipient, recipient=recipient,