ramon
/
vbv
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: cleanup

This commit is contained in:
Livio Bieri 2024-03-22 11:34:09 +01:00
parent 5d14bde805
commit e232aa4820
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
client/src/services/circle.ts
View File

@ -44,9 +44,8 @@ export function someFinishedInLearningSequence(ls: LearningSequence) {
}
/**
* Completed is defined as having completed all learning contents,
* ranked at least one performance criteria (but not necessarily all)
* was ranked as success or fail.
* Completed is defined as having completed all learning contents, ranked at
* least one performance criteria (but not necessarily all) as success or fail.
*/
export function allFinishedInLearningSequence(ls: LearningSequence) {
const allLearningContentsCompleted = ls.learning_units
@ -59,7 +58,7 @@ export function allFinishedInLearningSequence(ls: LearningSequence) {
const somePerformanceCriteriaRanked =
performanceCriteriaHasStatus(performanceCriteria) ||
performanceCriteria.length === 0; // no performance criteria -> treat as completed
performanceCriteria.length === 0; // -> treat as completed
return allLearningContentsCompleted && somePerformanceCriteriaRanked;
}