chore: cleanup
This commit is contained in:
parent
5d14bde805
commit
e232aa4820
|
|
@ -44,9 +44,8 @@ export function someFinishedInLearningSequence(ls: LearningSequence) {
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Completed is defined as having completed all learning contents,
|
* Completed is defined as having completed all learning contents, ranked at
|
||||||
* ranked at least one performance criteria (but not necessarily all)
|
* least one performance criteria (but not necessarily all) as success or fail.
|
||||||
* was ranked as success or fail.
|
|
||||||
*/
|
*/
|
||||||
export function allFinishedInLearningSequence(ls: LearningSequence) {
|
export function allFinishedInLearningSequence(ls: LearningSequence) {
|
||||||
const allLearningContentsCompleted = ls.learning_units
|
const allLearningContentsCompleted = ls.learning_units
|
||||||
|
|
@ -59,7 +58,7 @@ export function allFinishedInLearningSequence(ls: LearningSequence) {
|
||||||
|
|
||||||
const somePerformanceCriteriaRanked =
|
const somePerformanceCriteriaRanked =
|
||||||
performanceCriteriaHasStatus(performanceCriteria) ||
|
performanceCriteriaHasStatus(performanceCriteria) ||
|
||||||
performanceCriteria.length === 0; // no performance criteria -> treat as completed
|
performanceCriteria.length === 0; // -> treat as completed
|
||||||
|
|
||||||
return allLearningContentsCompleted && somePerformanceCriteriaRanked;
|
return allLearningContentsCompleted && somePerformanceCriteriaRanked;
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue